Re: [RFC PATCH v5 3/4] x86/acrn: Use HYPERVISOR_CALLBACK_VECTOR for ACRN guest upcall vector

2019-04-25 Thread Ingo Molnar
* Zhao, Yakui wrote: > > > > Does the hypervisor model the APIC EOI command, i.e. does it require the > > > > APIC to be acked? I.e. would not acking the APIC create an IRQ storm? > > > > > > The hypervisor requires that the APIC EOI should be acked. If the EOI APIC > > > is not acked, the API

Re: [RFC PATCH v5 3/4] x86/acrn: Use HYPERVISOR_CALLBACK_VECTOR for ACRN guest upcall vector

2019-04-25 Thread Zhao, Yakui
On 2019年04月26日 03:45, Ingo Molnar wrote: * Zhao, Yakui wrote: + alloc_intr_gate(HYPERVISOR_CALLBACK_VECTOR, + acrn_hv_callback_vector); Why is this on two lines, not a single line? At first it used the long function name for acrn_hv_callback_vector. As it ex

Re: [RFC PATCH v5 3/4] x86/acrn: Use HYPERVISOR_CALLBACK_VECTOR for ACRN guest upcall vector

2019-04-25 Thread Ingo Molnar
* Zhao, Yakui wrote: > > > + alloc_intr_gate(HYPERVISOR_CALLBACK_VECTOR, > > > + acrn_hv_callback_vector); > > > > Why is this on two lines, not a single line? > > At first it used the long function name for acrn_hv_callback_vector. > As it exceeds 80 columns, it is split into

Re: [RFC PATCH v5 3/4] x86/acrn: Use HYPERVISOR_CALLBACK_VECTOR for ACRN guest upcall vector

2019-04-25 Thread Zhao, Yakui
On 2019年04月25日 15:17, Ingo Molnar wrote: * Zhao Yakui wrote: Linux kernel uses the HYPERVISOR_CALLBACK_VECTOR for hypervisor upcall vector. And it is already used for Xen and HyperV. English sentences should not be started with 'and'. OK. I will remove it. After ACRN hypervisor is

Re: [RFC PATCH v5 3/4] x86/acrn: Use HYPERVISOR_CALLBACK_VECTOR for ACRN guest upcall vector

2019-04-25 Thread Ingo Molnar
* Zhao Yakui wrote: > Linux kernel uses the HYPERVISOR_CALLBACK_VECTOR for hypervisor upcall > vector. And it is already used for Xen and HyperV. English sentences should not be started with 'and'. > After ACRN hypervisor is detected, it will also use this defined vector > to notify ACRN gues

[RFC PATCH v5 3/4] x86/acrn: Use HYPERVISOR_CALLBACK_VECTOR for ACRN guest upcall vector

2019-04-23 Thread Zhao Yakui
Linux kernel uses the HYPERVISOR_CALLBACK_VECTOR for hypervisor upcall vector. And it is already used for Xen and HyperV. After ACRN hypervisor is detected, it will also use this defined vector to notify ACRN guest. Co-developed-by: Jason Chen CJ Signed-off-by: Jason Chen CJ Signed-off-by: Zhao