Re: [RFC PATCH v8 4/7] of/irq: Adjust of pci irq parsing for multiple interrupts

2017-10-30 Thread Brian Norris
On Mon, Oct 30, 2017 at 10:05:51AM +0800, Jeffy Chen wrote: > On 10/27/2017 10:38 PM, Rob Herring wrote: > >>+ prop = of_find_property(dn, "interrupt-names", NULL); > >>>+ for (name = of_prop_next_string(prop, NULL); name; > >>>+ name = of_prop_next_string(prop, nam

Re: [RFC PATCH v8 4/7] of/irq: Adjust of pci irq parsing for multiple interrupts

2017-10-29 Thread jeffy
Hi Rob, On 10/27/2017 10:38 PM, Rob Herring wrote: + prop = of_find_property(dn, "interrupt-names", NULL); >+ for (name = of_prop_next_string(prop, NULL); name; >+name = of_prop_next_string(prop, name), index++) { >+ if (!strcmp(name, "pc

Re: [RFC PATCH v8 4/7] of/irq: Adjust of pci irq parsing for multiple interrupts

2017-10-27 Thread Rob Herring
On Thu, Oct 26, 2017 at 09:28:37PM +0800, Jeffy Chen wrote: > Currently we are considering the first irq as the PCI interrupt pin, > but a pci device may have multiple interrupts(e.g. PCIe WAKE# pin). > > Only parse the PCI interrupt pin when the irq is unnamed or named as > "pci". > > Signed-off

Re: [RFC PATCH v8 4/7] of/irq: Adjust of pci irq parsing for multiple interrupts

2017-10-26 Thread jeffy
Hi Rob, On 10/27/2017 04:02 AM, Rob Herring wrote: Why do you need this patch? You're moving the wakeup handling from the PCI device to the bridge. The bridge device is not PCI interrupts, but a platform device so this function doesn't matter. because it's possible we have multiple PCI device

Re: [RFC PATCH v8 4/7] of/irq: Adjust of pci irq parsing for multiple interrupts

2017-10-26 Thread Rob Herring
On Thu, Oct 26, 2017 at 8:28 AM, Jeffy Chen wrote: > Currently we are considering the first irq as the PCI interrupt pin, > but a pci device may have multiple interrupts(e.g. PCIe WAKE# pin). > > Only parse the PCI interrupt pin when the irq is unnamed or named as > "pci". Why do you need this pa

[RFC PATCH v8 4/7] of/irq: Adjust of pci irq parsing for multiple interrupts

2017-10-26 Thread Jeffy Chen
Currently we are considering the first irq as the PCI interrupt pin, but a pci device may have multiple interrupts(e.g. PCIe WAKE# pin). Only parse the PCI interrupt pin when the irq is unnamed or named as "pci". Signed-off-by: Jeffy Chen --- Changes in v8: None Changes in v7: None Changes in v