Re: [RFC PATCH v9 5/7] perf: cavium: Support memory controller PMU counters

2017-08-31 Thread Jan Glauber
On Thu, Aug 31, 2017 at 02:26:22PM +0100, Suzuki K Poulose wrote: > On 31/08/17 12:35, Jan Glauber wrote: > >On Wed, Aug 30, 2017 at 11:03:00AM +0100, Suzuki K Poulose wrote: > >>On 29/08/17 14:12, Jan Glauber wrote: [...] > >>>+/* LMC events */ > >>>+#define LMC_EVENT_IFB_CNT 0x1d0 > >>>

Re: [RFC PATCH v9 5/7] perf: cavium: Support memory controller PMU counters

2017-08-31 Thread Suzuki K Poulose
On 31/08/17 12:35, Jan Glauber wrote: On Wed, Aug 30, 2017 at 11:03:00AM +0100, Suzuki K Poulose wrote: On 29/08/17 14:12, Jan Glauber wrote: Add support for the PMU counters on Cavium SOC memory controllers. This patch also adds generic functions to allow supporting more devices with PMU coun

Re: [RFC PATCH v9 5/7] perf: cavium: Support memory controller PMU counters

2017-08-31 Thread Jan Glauber
On Wed, Aug 30, 2017 at 11:03:00AM +0100, Suzuki K Poulose wrote: > On 29/08/17 14:12, Jan Glauber wrote: > >Add support for the PMU counters on Cavium SOC memory controllers. > > > >This patch also adds generic functions to allow supporting more > >devices with PMU counters. > > > >Properties of t

Re: [RFC PATCH v9 5/7] perf: cavium: Support memory controller PMU counters

2017-08-31 Thread Jan Glauber
On Thu, Aug 31, 2017 at 11:31:20AM +0100, Mark Rutland wrote: > On Thu, Aug 31, 2017 at 11:57:46AM +0200, Jan Glauber wrote: > > On Wed, Aug 30, 2017 at 10:54:03AM +0800, Zhangshaokun wrote: > > > On 2017/8/29 21:12, Jan Glauber wrote: [...] > > > > diff --git a/include/linux/cpuhotplug.h b/inclu

Re: [RFC PATCH v9 5/7] perf: cavium: Support memory controller PMU counters

2017-08-31 Thread Jan Glauber
On Thu, Aug 31, 2017 at 11:31:20AM +0100, Mark Rutland wrote: > On Thu, Aug 31, 2017 at 11:57:46AM +0200, Jan Glauber wrote: > > On Wed, Aug 30, 2017 at 10:54:03AM +0800, Zhangshaokun wrote: > > > On 2017/8/29 21:12, Jan Glauber wrote: > > > > Add support for the PMU counters on Cavium SOC memory c

Re: [RFC PATCH v9 5/7] perf: cavium: Support memory controller PMU counters

2017-08-31 Thread Mark Rutland
On Thu, Aug 31, 2017 at 11:57:46AM +0200, Jan Glauber wrote: > On Wed, Aug 30, 2017 at 10:54:03AM +0800, Zhangshaokun wrote: > > On 2017/8/29 21:12, Jan Glauber wrote: > > > Add support for the PMU counters on Cavium SOC memory controllers. > > > > > > This patch also adds generic functions to all

Re: [RFC PATCH v9 5/7] perf: cavium: Support memory controller PMU counters

2017-08-31 Thread Jan Glauber
On Wed, Aug 30, 2017 at 10:54:03AM +0800, Zhangshaokun wrote: > Hi Jan, > > Some trivial things i noticed, please consider if you are glad. > > Thanks, > Shaokun Hi Shaokun, thanks for the review. > On 2017/8/29 21:12, Jan Glauber wrote: > > Add support for the PMU counters on Cavium SOC memory

Re: [RFC PATCH v9 5/7] perf: cavium: Support memory controller PMU counters

2017-08-30 Thread Suzuki K Poulose
On 29/08/17 14:12, Jan Glauber wrote: Add support for the PMU counters on Cavium SOC memory controllers. This patch also adds generic functions to allow supporting more devices with PMU counters. Properties of the LMC PMU counters: - not stoppable - fixed purpose - read-only - one PCI device pe

Re: [RFC PATCH v9 5/7] perf: cavium: Support memory controller PMU counters

2017-08-29 Thread Zhangshaokun
Hi Jan, Some trivial things i noticed, please consider if you are glad. Thanks, Shaokun On 2017/8/29 21:12, Jan Glauber wrote: > Add support for the PMU counters on Cavium SOC memory controllers. > > This patch also adds generic functions to allow supporting more > devices with PMU counters. >

[RFC PATCH v9 5/7] perf: cavium: Support memory controller PMU counters

2017-08-29 Thread Jan Glauber
Add support for the PMU counters on Cavium SOC memory controllers. This patch also adds generic functions to allow supporting more devices with PMU counters. Properties of the LMC PMU counters: - not stoppable - fixed purpose - read-only - one PCI device per memory controller Signed-off-by: Jan