Re: [RFC PATCHv3 3/4] x86/pci: Initial commit for new VMD device driver

2015-11-05 Thread Keith Busch
On Thu, Nov 05, 2015 at 02:35:31PM +0800, Jiang Liu wrote: > Hi Keith, > Could you please try the attached patch? > Thanks! > Gerry Thanks! I anticipated this and tested the same thing yesterday, and it is successful. I'll apply to the series and send a new revision hopefully today. Not req

Re: [RFC PATCHv3 3/4] x86/pci: Initial commit for new VMD device driver

2015-11-04 Thread Jiang Liu
On 2015/11/4 23:14, Thomas Gleixner wrote: > On Wed, 4 Nov 2015, Keith Busch wrote: > >> On Tue, Nov 03, 2015 at 12:42:02PM +0100, Thomas Gleixner wrote: >>> On Tue, 3 Nov 2015, Keith Busch wrote: >> +msi_irqdomain = pci_msi_create_irq_domain(NULL, >> &pci_chained_msi_domain_inf

Re: [RFC PATCHv3 3/4] x86/pci: Initial commit for new VMD device driver

2015-11-04 Thread Thomas Gleixner
On Wed, 4 Nov 2015, Keith Busch wrote: > On Tue, Nov 03, 2015 at 12:42:02PM +0100, Thomas Gleixner wrote: > > On Tue, 3 Nov 2015, Keith Busch wrote: > > > > > + msi_irqdomain = pci_msi_create_irq_domain(NULL, > > > > > &pci_chained_msi_domain_info, > > > > > +

Re: [RFC PATCHv3 3/4] x86/pci: Initial commit for new VMD device driver

2015-11-04 Thread Keith Busch
On Tue, Nov 03, 2015 at 12:42:02PM +0100, Thomas Gleixner wrote: > On Tue, 3 Nov 2015, Keith Busch wrote: > > > > + msi_irqdomain = pci_msi_create_irq_domain(NULL, > > > > &pci_chained_msi_domain_info, > > > > + vmd_irqdomain); > > But that pa

Re: [RFC PATCHv3 3/4] x86/pci: Initial commit for new VMD device driver

2015-11-03 Thread Thomas Gleixner
Keith, On Tue, 3 Nov 2015, Keith Busch wrote: > On Mon, Nov 02, 2015 at 07:35:15PM +0100, Thomas Gleixner wrote: > > On Tue, 27 Oct 2015, Keith Busch wrote: > > > +config HAVE_VMDDEV > > > + bool > > > > Why do you need a seperate config symbol here? > > This is to split the kernel vs. module p

Re: [RFC PATCHv3 3/4] x86/pci: Initial commit for new VMD device driver

2015-11-02 Thread Keith Busch
On Mon, Nov 02, 2015 at 07:35:15PM +0100, Thomas Gleixner wrote: > On Tue, 27 Oct 2015, Keith Busch wrote: Thomas, Thanks a bunch for the feedback! I'll reply what I can right now, and will take more time to consider or fix the rest for the next revision. > I'm just looking at the interrupt par

Re: [RFC PATCHv3 3/4] x86/pci: Initial commit for new VMD device driver

2015-11-02 Thread Thomas Gleixner
Keith! On Tue, 27 Oct 2015, Keith Busch wrote: I'm just looking at the interrupt part of the patch and it's way better than the first version I looked at. > 4) Interrupts: Part of VMD's BAR 4 is reserved for VMD's MSI-X Table and > PBA. MSIs from VMD domain devices and ports are remapped to

[RFC PATCHv3 3/4] x86/pci: Initial commit for new VMD device driver

2015-10-27 Thread Keith Busch
The Intel Volume Management Device (VMD) is an integrated endpoint on the platform's PCIe root complex that acts as a host bridge to a secondary PCIe domain. BIOS can reassign one or more root ports to appear within a VMD domain instead of the primary domain. The immediate benefit is that additiona