Re: [RFC Part1 PATCH 04/13] x86/sev-snp: define page state change VMGEXIT structure

2021-04-02 Thread Borislav Petkov
On Thu, Apr 01, 2021 at 09:11:34AM -0500, Brijesh Singh wrote: > I guess I was trying to keep it in consistent with sev-es.h macro > definitions in which the command is used before the fields. In next > version, I will use the msb to lsb ordering. Yes pls. And then you could fix the sev-es.h

Re: [RFC Part1 PATCH 04/13] x86/sev-snp: define page state change VMGEXIT structure

2021-04-01 Thread Brijesh Singh
On 4/1/21 5:32 AM, Borislav Petkov wrote: > On Wed, Mar 24, 2021 at 11:44:15AM -0500, Brijesh Singh wrote: >> An SNP-active guest will use the page state change VNAE MGEXIT defined in > I guess this was supposed to mean "NAE VMGEXIT" but pls write "NAE" out > at least once so that reader can

Re: [RFC Part1 PATCH 04/13] x86/sev-snp: define page state change VMGEXIT structure

2021-04-01 Thread Borislav Petkov
On Wed, Mar 24, 2021 at 11:44:15AM -0500, Brijesh Singh wrote: > An SNP-active guest will use the page state change VNAE MGEXIT defined in I guess this was supposed to mean "NAE VMGEXIT" but pls write "NAE" out at least once so that reader can find its way around the spec. > the GHCB

[RFC Part1 PATCH 04/13] x86/sev-snp: define page state change VMGEXIT structure

2021-03-24 Thread Brijesh Singh
An SNP-active guest will use the page state change VNAE MGEXIT defined in the GHCB specification section 4.1.6 to ask the hypervisor to make the guest page private or shared in the RMP table. In addition to the private/shared, the guest can also ask the hypervisor to split or combine multiple 4K