Re: [RFC Part2 PATCH v3 19/26] KVM: svm: Add support for SEV GUEST_STATUS command

2017-09-14 Thread Brijesh Singh
On 9/14/17 5:35 AM, Borislav Petkov wrote: ... > + >> +if (copy_from_user(¶ms, (void *) argp->data, >> +sizeof(struct kvm_sev_guest_status))) > Let me try to understand what's going on here. You copy user data into > params... This is wrong -- since all the param

Re: [RFC Part2 PATCH v3 19/26] KVM: svm: Add support for SEV GUEST_STATUS command

2017-09-14 Thread Borislav Petkov
On Mon, Jul 24, 2017 at 03:02:56PM -0500, Brijesh Singh wrote: > The command is used for querying the SEV guest status. > > Signed-off-by: Brijesh Singh > --- > arch/x86/kvm/svm.c | 38 ++ > 1 file changed, 38 insertions(+) > > diff --git a/arch/x86/kvm/svm.c

[RFC Part2 PATCH v3 19/26] KVM: svm: Add support for SEV GUEST_STATUS command

2017-07-24 Thread Brijesh Singh
The command is used for querying the SEV guest status. Signed-off-by: Brijesh Singh --- arch/x86/kvm/svm.c | 38 ++ 1 file changed, 38 insertions(+) diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c index 7a77197..21f85e1 100644 --- a/arch/x86/kvm/svm.c ++