Re: [RFC Patch 0/2] mm: Add parameters to make kernel behavior at memory error on dirty cache selectable

2013-04-17 Thread Simon Jeons
Hi Naoya, On 04/17/2013 10:55 PM, Naoya Horiguchi wrote: > On Wed, Apr 17, 2013 at 03:14:36PM +0800, Simon Jeons wrote: >> Hi Naoya, >> On 04/11/2013 03:11 PM, Naoya Horiguchi wrote: >>> Hi Tanino-san, >>> >>> On Thu, Apr 11, 2013 at 12:26:19PM +0900, Mitsuhiro Tanino wrote: >>> ... Solution >

Re: [RFC Patch 0/2] mm: Add parameters to make kernel behavior at memory error on dirty cache selectable

2013-04-17 Thread Naoya Horiguchi
On Wed, Apr 17, 2013 at 03:14:36PM +0800, Simon Jeons wrote: > Hi Naoya, > On 04/11/2013 03:11 PM, Naoya Horiguchi wrote: > > Hi Tanino-san, > > > > On Thu, Apr 11, 2013 at 12:26:19PM +0900, Mitsuhiro Tanino wrote: > > ... > >> Solution > >> - > >> The patch proposes a new sysctl interface,

Re: [RFC Patch 0/2] mm: Add parameters to make kernel behavior at memory error on dirty cache selectable

2013-04-17 Thread Naoya Horiguchi
On Wed, Apr 17, 2013 at 02:42:51PM +0800, Simon Jeons wrote: > Hi Naoya, > On 04/11/2013 11:23 PM, Naoya Horiguchi wrote: > > On Thu, Apr 11, 2013 at 03:49:16PM +0200, Andi Kleen wrote: > >>> As a result, if the dirty cache includes user data, the data is lost, > >>> and data corruption occurs if a

Re: [RFC Patch 0/2] mm: Add parameters to make kernel behavior at memory error on dirty cache selectable

2013-04-17 Thread Naoya Horiguchi
On Fri, Apr 12, 2013 at 11:13:03AM -0400, Naoya Horiguchi wrote: ... > > So my proposal is as follows, > > For short term solution to care both memory error and I/O error: > > - I will resend a panic knob to handle data lost related to dirty cache > > which is caused by memory error and

Re: [RFC Patch 0/2] mm: Add parameters to make kernel behavior at memory error on dirty cache selectable

2013-04-17 Thread Simon Jeons
Hi Naoya, On 04/11/2013 03:11 PM, Naoya Horiguchi wrote: > Hi Tanino-san, > > On Thu, Apr 11, 2013 at 12:26:19PM +0900, Mitsuhiro Tanino wrote: > ... >> Solution >> - >> The patch proposes a new sysctl interface, vm.memory_failure_dirty_panic, >> in order to prevent data corruption comes fr

Re: [RFC Patch 0/2] mm: Add parameters to make kernel behavior at memory error on dirty cache selectable

2013-04-16 Thread Simon Jeons
Hi Naoya, On 04/11/2013 11:23 PM, Naoya Horiguchi wrote: > On Thu, Apr 11, 2013 at 03:49:16PM +0200, Andi Kleen wrote: >>> As a result, if the dirty cache includes user data, the data is lost, >>> and data corruption occurs if an application uses old data. >> The application cannot use old data, th

Re: [RFC Patch 0/2] mm: Add parameters to make kernel behavior at memory error on dirty cache selectable

2013-04-16 Thread Simon Jeons
Hi Mitsuhiro, On 04/12/2013 09:43 PM, Mitsuhiro Tanino wrote: (2013/04/11 22:00), Ric Mason wrote: Hi Mitsuhiro, On 04/11/2013 08:51 PM, Mitsuhiro Tanino wrote: (2013/04/11 12:53), Simon Jeons wrote: One question against mce instead of the patchset. ;-) When check memory is bad? Before memory

Re: [RFC Patch 0/2] mm: Add parameters to make kernel behavior at memory error on dirty cache selectable

2013-04-16 Thread Simon Jeons
On 04/11/2013 09:49 PM, Andi Kleen wrote: As a result, if the dirty cache includes user data, the data is lost, and data corruption occurs if an application uses old data. Hi Andi, Could you give me the link of your mce testcase? The application cannot use old data, the kernel code kills it

Re: [RFC Patch 0/2] mm: Add parameters to make kernel behavior at memory error on dirty cache selectable

2013-04-12 Thread Naoya Horiguchi
On Fri, Apr 12, 2013 at 10:38:43PM +0900, Mitsuhiro Tanino wrote: > (2013/04/12 3:10), Andi Kleen wrote: > > On Thu, Apr 11, 2013 at 11:23:08AM -0400, Naoya Horiguchi wrote: > >> On Thu, Apr 11, 2013 at 03:49:16PM +0200, Andi Kleen wrote: > As a result, if the dirty cache includes user data, t

Re: [RFC Patch 0/2] mm: Add parameters to make kernel behavior at memory error on dirty cache selectable

2013-04-12 Thread Naoya Horiguchi
On Fri, Apr 12, 2013 at 10:24:48PM +0900, Mitsuhiro Tanino wrote: > (2013/04/11 16:11), Naoya Horiguchi wrote: > > Hi Tanino-san, > > > > On Thu, Apr 11, 2013 at 12:26:19PM +0900, Mitsuhiro Tanino wrote: > > ... > >> Solution > >> - > >> The patch proposes a new sysctl interface, vm.memory

Re: [RFC Patch 0/2] mm: Add parameters to make kernel behavior at memory error on dirty cache selectable

2013-04-12 Thread Mitsuhiro Tanino
(2013/04/11 22:00), Ric Mason wrote: > Hi Mitsuhiro, > On 04/11/2013 08:51 PM, Mitsuhiro Tanino wrote: >> (2013/04/11 12:53), Simon Jeons wrote: >>> One question against mce instead of the patchset. ;-) >>> >>> When check memory is bad? Before memory access? Is there a process scan it >>> period?

Re: [RFC Patch 0/2] mm: Add parameters to make kernel behavior at memory error on dirty cache selectable

2013-04-12 Thread Mitsuhiro Tanino
(2013/04/12 3:10), Andi Kleen wrote: > On Thu, Apr 11, 2013 at 11:23:08AM -0400, Naoya Horiguchi wrote: >> On Thu, Apr 11, 2013 at 03:49:16PM +0200, Andi Kleen wrote: As a result, if the dirty cache includes user data, the data is lost, and data corruption occurs if an application uses ol

Re: [RFC Patch 0/2] mm: Add parameters to make kernel behavior at memory error on dirty cache selectable

2013-04-12 Thread Mitsuhiro Tanino
(2013/04/11 16:11), Naoya Horiguchi wrote: > Hi Tanino-san, > > On Thu, Apr 11, 2013 at 12:26:19PM +0900, Mitsuhiro Tanino wrote: > ... >> Solution >> - >> The patch proposes a new sysctl interface, vm.memory_failure_dirty_panic, >> in order to prevent data corruption comes from data lost

Re: [RFC Patch 0/2] mm: Add parameters to make kernel behavior at memory error on dirty cache selectable

2013-04-11 Thread Andi Kleen
On Thu, Apr 11, 2013 at 11:23:08AM -0400, Naoya Horiguchi wrote: > On Thu, Apr 11, 2013 at 03:49:16PM +0200, Andi Kleen wrote: > > > As a result, if the dirty cache includes user data, the data is lost, > > > and data corruption occurs if an application uses old data. > > > > The application canno

Re: [RFC Patch 0/2] mm: Add parameters to make kernel behavior at memory error on dirty cache selectable

2013-04-11 Thread Naoya Horiguchi
On Thu, Apr 11, 2013 at 03:49:16PM +0200, Andi Kleen wrote: > > As a result, if the dirty cache includes user data, the data is lost, > > and data corruption occurs if an application uses old data. > > The application cannot use old data, the kernel code kills it if it > would do that. And if it's

Re: [RFC Patch 0/2] mm: Add parameters to make kernel behavior at memory error on dirty cache selectable

2013-04-11 Thread KOSAKI Motohiro
(4/10/13 11:26 PM), Mitsuhiro Tanino wrote: > Hi All, > Please find a patch set that introduces these new sysctl interfaces, > to handle a case when an memory error is detected on dirty page cache. > > - vm.memory_failure_dirty_panic Panic knob is ok to me. However I agree with Andi. If we need p

Re: [RFC Patch 0/2] mm: Add parameters to make kernel behavior at memory error on dirty cache selectable

2013-04-11 Thread Andi Kleen
> As a result, if the dirty cache includes user data, the data is lost, > and data corruption occurs if an application uses old data. The application cannot use old data, the kernel code kills it if it would do that. And if it's IO data there is an EIO triggered. iirc the only concern in the past

Re: [RFC Patch 0/2] mm: Add parameters to make kernel behavior at memory error on dirty cache selectable

2013-04-11 Thread Ric Mason
Hi Mitsuhiro, On 04/11/2013 08:51 PM, Mitsuhiro Tanino wrote: (2013/04/11 12:53), Simon Jeons wrote: One question against mce instead of the patchset. ;-) When check memory is bad? Before memory access? Is there a process scan it period? Hi Simon-san, Yes, there is a process to scan memory p

Re: [RFC Patch 0/2] mm: Add parameters to make kernel behavior at memory error on dirty cache selectable

2013-04-11 Thread Mitsuhiro Tanino
(2013/04/11 12:53), Simon Jeons wrote: > One question against mce instead of the patchset. ;-) > > When check memory is bad? Before memory access? Is there a process scan it > period? Hi Simon-san, Yes, there is a process to scan memory periodically. At Intel Nehalem-EX and CPUs after Nehalem-

Re: [RFC Patch 0/2] mm: Add parameters to make kernel behavior at memory error on dirty cache selectable

2013-04-11 Thread Naoya Horiguchi
Hi Tanino-san, On Thu, Apr 11, 2013 at 12:26:19PM +0900, Mitsuhiro Tanino wrote: ... > Solution > - > The patch proposes a new sysctl interface, vm.memory_failure_dirty_panic, > in order to prevent data corruption comes from data lost problem. > Also this patch displays information of affe

Re: [RFC Patch 0/2] mm: Add parameters to make kernel behavior at memory error on dirty cache selectable

2013-04-10 Thread Simon Jeons
Hi Mitsuhiro, On 04/11/2013 11:26 AM, Mitsuhiro Tanino wrote: Hi All, Please find a patch set that introduces these new sysctl interfaces, to handle a case when an memory error is detected on dirty page cache. - vm.memory_failure_dirty_panic - vm.memory_failure_print_ratelimit - vm.memory_failur

[RFC Patch 0/2] mm: Add parameters to make kernel behavior at memory error on dirty cache selectable

2013-04-10 Thread Mitsuhiro Tanino
Hi All, Please find a patch set that introduces these new sysctl interfaces, to handle a case when an memory error is detected on dirty page cache. - vm.memory_failure_dirty_panic - vm.memory_failure_print_ratelimit - vm.memory_failure_print_ratelimit_burst Problem - Recently, it is commo