Re: [RFC V1 1/7] genirq/msi: Differentiate between various MSI based interrupts

2019-09-26 Thread Bjorn Helgaas
On Thu, Sep 12, 2019 at 06:32:02PM -0700, Megha Dey wrote: > Since a device can support both MSI-X and IMS interrupts simultaneously, > do away with is_msix and introduce a new enum msi_desc_tag to > differentiate between the various types of msi_descs. > > Signed-off-by: Megha Dey Acked-by: Bjo

Re: [RFC V1 1/7] genirq/msi: Differentiate between various MSI based interrupts

2019-09-13 Thread Jason Gunthorpe
On Thu, Sep 12, 2019 at 06:32:02PM -0700, Megha Dey wrote: > Since a device can support both MSI-X and IMS interrupts simultaneously, > do away with is_msix and introduce a new enum msi_desc_tag to > differentiate between the various types of msi_descs. It would be clearer if this commit message e

Re: [RFC V1 1/7] genirq/msi: Differentiate between various MSI based interrupts

2019-09-12 Thread Greg KH
On Thu, Sep 12, 2019 at 06:32:02PM -0700, Megha Dey wrote: > +enum msi_desc_tags { > + IRQ_MSI_TAG_MSI, > + IRQ_MSI_TAG_MSIX, > + IRQ_MSI_TAG_IMS, > + IRQ_MSI_TAG_PLAT, > + IRQ_MSI_TAG_FSL, > + IRQ_MSI_TAG_SCI, > +}; What does any of these mean? Can you please provide comm

[RFC V1 1/7] genirq/msi: Differentiate between various MSI based interrupts

2019-09-12 Thread Megha Dey
Since a device can support both MSI-X and IMS interrupts simultaneously, do away with is_msix and introduce a new enum msi_desc_tag to differentiate between the various types of msi_descs. Signed-off-by: Megha Dey --- arch/mips/pci/msi-xlp.c| 2 +- arch/s390/pci/pci_irq.c| 2 +- arch/x