Re: [RFC V2] mm/vmstat: Add events for HugeTLB migration

2020-10-06 Thread Michal Hocko
On Tue 06-10-20 08:26:35, Anshuman Khandual wrote: > > > On 10/05/2020 11:35 AM, Michal Hocko wrote: > > On Mon 05-10-20 07:59:12, Anshuman Khandual wrote: > >> > >> > >> On 10/02/2020 05:34 PM, Michal Hocko wrote: > >>> On Wed 30-09-20 11:30:49, Anshuman Khandual wrote: > Add following new

Re: [RFC V2] mm/vmstat: Add events for HugeTLB migration

2020-10-05 Thread Anshuman Khandual
On 10/05/2020 11:35 AM, Michal Hocko wrote: > On Mon 05-10-20 07:59:12, Anshuman Khandual wrote: >> >> >> On 10/02/2020 05:34 PM, Michal Hocko wrote: >>> On Wed 30-09-20 11:30:49, Anshuman Khandual wrote: Add following new vmstat events which will track HugeTLB page migration. 1.

Re: [RFC V2] mm/vmstat: Add events for HugeTLB migration

2020-10-05 Thread Michal Hocko
On Mon 05-10-20 07:59:12, Anshuman Khandual wrote: > > > On 10/02/2020 05:34 PM, Michal Hocko wrote: > > On Wed 30-09-20 11:30:49, Anshuman Khandual wrote: > >> Add following new vmstat events which will track HugeTLB page migration. > >> > >> 1. HUGETLB_MIGRATION_SUCCESS > >> 2.

Re: [RFC V2] mm/vmstat: Add events for HugeTLB migration

2020-10-04 Thread Anshuman Khandual
On 10/02/2020 05:34 PM, Michal Hocko wrote: > On Wed 30-09-20 11:30:49, Anshuman Khandual wrote: >> Add following new vmstat events which will track HugeTLB page migration. >> >> 1. HUGETLB_MIGRATION_SUCCESS >> 2. HUGETLB_MIGRATION_FAILURE >> >> It follows the existing semantics to accommodate

Re: [RFC V2] mm/vmstat: Add events for HugeTLB migration

2020-10-02 Thread Michal Hocko
On Wed 30-09-20 11:30:49, Anshuman Khandual wrote: > Add following new vmstat events which will track HugeTLB page migration. > > 1. HUGETLB_MIGRATION_SUCCESS > 2. HUGETLB_MIGRATION_FAILURE > > It follows the existing semantics to accommodate HugeTLB subpages in total > page migration

Re: [RFC V2] mm/vmstat: Add events for HugeTLB migration

2020-10-01 Thread Mike Kravetz
On 9/29/20 11:00 PM, Anshuman Khandual wrote: > Add following new vmstat events which will track HugeTLB page migration. > > 1. HUGETLB_MIGRATION_SUCCESS > 2. HUGETLB_MIGRATION_FAILURE > > It follows the existing semantics to accommodate HugeTLB subpages in total > page migration statistics.

Re: [RFC V2] mm/vmstat: Add events for HugeTLB migration

2020-09-30 Thread Oscar Salvador
On Wed, Sep 30, 2020 at 03:32:10PM +0530, Anshuman Khandual wrote: > Right, it would be simple. But as Mike had mentioned before PageHuge() > check is more expensive than PageTransHuge(). This proposal just tries > not to call PageHuge() unless the page first clears PageTransHuge(), > saving some

Re: [RFC V2] mm/vmstat: Add events for HugeTLB migration

2020-09-30 Thread Anshuman Khandual
On 09/30/2020 01:16 PM, Oscar Salvador wrote: > On Wed, Sep 30, 2020 at 11:30:49AM +0530, Anshuman Khandual wrote: >> -is_thp = PageTransHuge(page) && !PageHuge(page); >> -nr_subpages = thp_nr_pages(page); >> +is_thp = false; >> +

Re: [RFC V2] mm/vmstat: Add events for HugeTLB migration

2020-09-30 Thread Oscar Salvador
On Wed, Sep 30, 2020 at 11:30:49AM +0530, Anshuman Khandual wrote: > - is_thp = PageTransHuge(page) && !PageHuge(page); > - nr_subpages = thp_nr_pages(page); > + is_thp = false; > + is_hugetlb = false; > +

[RFC V2] mm/vmstat: Add events for HugeTLB migration

2020-09-30 Thread Anshuman Khandual
Add following new vmstat events which will track HugeTLB page migration. 1. HUGETLB_MIGRATION_SUCCESS 2. HUGETLB_MIGRATION_FAILURE It follows the existing semantics to accommodate HugeTLB subpages in total page migration statistics. While here, this updates current trace event 'mm_migrate_pages'