Re: [RFC V3 1/3] perf, tools: Support wildcards on pmu name in dynamic pmu events

Em Wed, Mar 07, 2018 at 03:09:08PM -0500, Agustin Vega-Frias escreveu: > On 2018-03-07 14:58, Arnaldo Carvalho de Melo wrote: > > Em Wed, Mar 07, 2018 at 02:49:50PM -0500, Agustin Vega-Frias escreveu: > > > On 2018-03-07 14:39, Arnaldo Carvalho de Melo wrote: > > > > Em Wed, Mar 07, 2018 at

Re: [RFC V3 1/3] perf, tools: Support wildcards on pmu name in dynamic pmu events

Em Wed, Mar 07, 2018 at 03:09:08PM -0500, Agustin Vega-Frias escreveu: > On 2018-03-07 14:58, Arnaldo Carvalho de Melo wrote: > > Em Wed, Mar 07, 2018 at 02:49:50PM -0500, Agustin Vega-Frias escreveu: > > > On 2018-03-07 14:39, Arnaldo Carvalho de Melo wrote: > > > > Em Wed, Mar 07, 2018 at

Re: [RFC V3 1/3] perf, tools: Support wildcards on pmu name in dynamic pmu events

On Wed, Mar 07, 2018 at 03:09:08PM -0500, Agustin Vega-Frias wrote: SNIP > > > > #include > > > > +/* > > > > + * GNU extension, so better define it to 0 for systems such > > > > + * as Android and Alpine Linux. > > > > + */ > > > > +#ifndef FNM_EXTMATCH > > > > +#define FNM_EXTMATCH 0 > > > >

Re: [RFC V3 1/3] perf, tools: Support wildcards on pmu name in dynamic pmu events

On Wed, Mar 07, 2018 at 03:09:08PM -0500, Agustin Vega-Frias wrote: SNIP > > > > #include > > > > +/* > > > > + * GNU extension, so better define it to 0 for systems such > > > > + * as Android and Alpine Linux. > > > > + */ > > > > +#ifndef FNM_EXTMATCH > > > > +#define FNM_EXTMATCH 0 > > > >

Re: [RFC V3 1/3] perf, tools: Support wildcards on pmu name in dynamic pmu events

On 2018-03-07 14:58, Arnaldo Carvalho de Melo wrote: Em Wed, Mar 07, 2018 at 02:49:50PM -0500, Agustin Vega-Frias escreveu: On 2018-03-07 14:39, Arnaldo Carvalho de Melo wrote: > Em Wed, Mar 07, 2018 at 04:05:43PM -0300, Arnaldo Carvalho de Melo > escreveu: > > Em Wed, Mar 07, 2018 at

Re: [RFC V3 1/3] perf, tools: Support wildcards on pmu name in dynamic pmu events

On 2018-03-07 14:58, Arnaldo Carvalho de Melo wrote: Em Wed, Mar 07, 2018 at 02:49:50PM -0500, Agustin Vega-Frias escreveu: On 2018-03-07 14:39, Arnaldo Carvalho de Melo wrote: > Em Wed, Mar 07, 2018 at 04:05:43PM -0300, Arnaldo Carvalho de Melo > escreveu: > > Em Wed, Mar 07, 2018 at

Re: [RFC V3 1/3] perf, tools: Support wildcards on pmu name in dynamic pmu events

Em Wed, Mar 07, 2018 at 02:49:50PM -0500, Agustin Vega-Frias escreveu: > On 2018-03-07 14:39, Arnaldo Carvalho de Melo wrote: > > Em Wed, Mar 07, 2018 at 04:05:43PM -0300, Arnaldo Carvalho de Melo > > escreveu: > > > Em Wed, Mar 07, 2018 at 04:05:09PM -0300, Arnaldo Carvalho de Melo > > >

Re: [RFC V3 1/3] perf, tools: Support wildcards on pmu name in dynamic pmu events

Em Wed, Mar 07, 2018 at 02:49:50PM -0500, Agustin Vega-Frias escreveu: > On 2018-03-07 14:39, Arnaldo Carvalho de Melo wrote: > > Em Wed, Mar 07, 2018 at 04:05:43PM -0300, Arnaldo Carvalho de Melo > > escreveu: > > > Em Wed, Mar 07, 2018 at 04:05:09PM -0300, Arnaldo Carvalho de Melo > > >

Re: [RFC V3 1/3] perf, tools: Support wildcards on pmu name in dynamic pmu events

On 2018-03-07 14:39, Arnaldo Carvalho de Melo wrote: Em Wed, Mar 07, 2018 at 04:05:43PM -0300, Arnaldo Carvalho de Melo escreveu: Em Wed, Mar 07, 2018 at 04:05:09PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Wed, Mar 07, 2018 at 10:54:15AM -0800, Andi Kleen escreveu: > > > Sorry about

Re: [RFC V3 1/3] perf, tools: Support wildcards on pmu name in dynamic pmu events

On 2018-03-07 14:39, Arnaldo Carvalho de Melo wrote: Em Wed, Mar 07, 2018 at 04:05:43PM -0300, Arnaldo Carvalho de Melo escreveu: Em Wed, Mar 07, 2018 at 04:05:09PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Wed, Mar 07, 2018 at 10:54:15AM -0800, Andi Kleen escreveu: > > > Sorry about

Re: [RFC V3 1/3] perf, tools: Support wildcards on pmu name in dynamic pmu events

Em Wed, Mar 07, 2018 at 04:05:43PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Wed, Mar 07, 2018 at 04:05:09PM -0300, Arnaldo Carvalho de Melo escreveu: > > Em Wed, Mar 07, 2018 at 10:54:15AM -0800, Andi Kleen escreveu: > > > > Sorry about that. That's probably because FNM_EXTMATCH is a GNU >

Re: [RFC V3 1/3] perf, tools: Support wildcards on pmu name in dynamic pmu events

Em Wed, Mar 07, 2018 at 04:05:43PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Wed, Mar 07, 2018 at 04:05:09PM -0300, Arnaldo Carvalho de Melo escreveu: > > Em Wed, Mar 07, 2018 at 10:54:15AM -0800, Andi Kleen escreveu: > > > > Sorry about that. That's probably because FNM_EXTMATCH is a GNU >

Re: [RFC V3 1/3] perf, tools: Support wildcards on pmu name in dynamic pmu events

Em Wed, Mar 07, 2018 at 04:05:09PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Wed, Mar 07, 2018 at 10:54:15AM -0800, Andi Kleen escreveu: > > > Sorry about that. That's probably because FNM_EXTMATCH is a GNU extension, > > > not POSIX, and the Alpine and Android runtimes likely don't implement

Re: [RFC V3 1/3] perf, tools: Support wildcards on pmu name in dynamic pmu events

Em Wed, Mar 07, 2018 at 04:05:09PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Wed, Mar 07, 2018 at 10:54:15AM -0800, Andi Kleen escreveu: > > > Sorry about that. That's probably because FNM_EXTMATCH is a GNU extension, > > > not POSIX, and the Alpine and Android runtimes likely don't implement

Re: [RFC V3 1/3] perf, tools: Support wildcards on pmu name in dynamic pmu events

Em Wed, Mar 07, 2018 at 10:54:15AM -0800, Andi Kleen escreveu: > > Sorry about that. That's probably because FNM_EXTMATCH is a GNU extension, > > not POSIX, and the Alpine and Android runtimes likely don't implement > > that... > > I'll send a fix reverting back to the strncmp to ignore the

Re: [RFC V3 1/3] perf, tools: Support wildcards on pmu name in dynamic pmu events

Em Wed, Mar 07, 2018 at 10:54:15AM -0800, Andi Kleen escreveu: > > Sorry about that. That's probably because FNM_EXTMATCH is a GNU extension, > > not POSIX, and the Alpine and Android runtimes likely don't implement > > that... > > I'll send a fix reverting back to the strncmp to ignore the

Re: [RFC V3 1/3] perf, tools: Support wildcards on pmu name in dynamic pmu events

> Sorry about that. That's probably because FNM_EXTMATCH is a GNU extension, > not POSIX, and the Alpine and Android runtimes likely don't implement > that... > I'll send a fix reverting back to the strncmp to ignore the uncore_ prefix, > and dropping that extension. Just don't set it? Even the

Re: [RFC V3 1/3] perf, tools: Support wildcards on pmu name in dynamic pmu events

> Sorry about that. That's probably because FNM_EXTMATCH is a GNU extension, > not POSIX, and the Alpine and Android runtimes likely don't implement > that... > I'll send a fix reverting back to the strncmp to ignore the uncore_ prefix, > and dropping that extension. Just don't set it? Even the

Re: [RFC V3 1/3] perf, tools: Support wildcards on pmu name in dynamic pmu events

On 2018-03-07 11:02, Arnaldo Carvalho de Melo wrote: Em Tue, Mar 06, 2018 at 09:04:42AM -0500, Agustin Vega-Frias escreveu: [snip] This breaks the build in at least Alpine Linux 3.4, 3.5 and 3.6 and android-ndk:r15c-arm Alpine 3.6 build failure: CC

Re: [RFC V3 1/3] perf, tools: Support wildcards on pmu name in dynamic pmu events

On 2018-03-07 11:02, Arnaldo Carvalho de Melo wrote: Em Tue, Mar 06, 2018 at 09:04:42AM -0500, Agustin Vega-Frias escreveu: [snip] This breaks the build in at least Alpine Linux 3.4, 3.5 and 3.6 and android-ndk:r15c-arm Alpine 3.6 build failure: CC

Re: [RFC V3 1/3] perf, tools: Support wildcards on pmu name in dynamic pmu events

Em Tue, Mar 06, 2018 at 09:04:42AM -0500, Agustin Vega-Frias escreveu: > Starting on v4.12 event parsing code for dynamic pmu events already > supports prefix-based matching of multiple pmus when creating dynamic > events. E.g., in a system with the following dynamic pmus: > > mypmu_0 >

Re: [RFC V3 1/3] perf, tools: Support wildcards on pmu name in dynamic pmu events

Em Tue, Mar 06, 2018 at 09:04:42AM -0500, Agustin Vega-Frias escreveu: > Starting on v4.12 event parsing code for dynamic pmu events already > supports prefix-based matching of multiple pmus when creating dynamic > events. E.g., in a system with the following dynamic pmus: > > mypmu_0 >

[RFC V3 1/3] perf, tools: Support wildcards on pmu name in dynamic pmu events

Starting on v4.12 event parsing code for dynamic pmu events already supports prefix-based matching of multiple pmus when creating dynamic events. E.g., in a system with the following dynamic pmus: mypmu_0 mypmu_1 mypmu_2 mypmu_4 passing mypmu// as an event spec will result in the

[RFC V3 1/3] perf, tools: Support wildcards on pmu name in dynamic pmu events

Starting on v4.12 event parsing code for dynamic pmu events already supports prefix-based matching of multiple pmus when creating dynamic events. E.g., in a system with the following dynamic pmus: mypmu_0 mypmu_1 mypmu_2 mypmu_4 passing mypmu// as an event spec will result in the