Re: [RFC internal PATCH] mfd/mc13xxx: drop modifying driver's id_table in probe

2012-07-16 Thread Samuel Ortiz
Hi Uwe, On Wed, Jul 11, 2012 at 01:36:48PM +0200, Uwe Kleine-König wrote: > This was introduced in commit > > 876989d (mfd: Add device tree probe support for mc13xxx) > > for spi and later while introducing support for i2c copied to the i2c > driver. > > Modifying driver details is very

Re: [RFC internal PATCH] mfd/mc13xxx: drop modifying driver's id_table in probe

2012-07-16 Thread Samuel Ortiz
Hi Uwe, On Wed, Jul 11, 2012 at 01:36:48PM +0200, Uwe Kleine-König wrote: This was introduced in commit 876989d (mfd: Add device tree probe support for mc13xxx) for spi and later while introducing support for i2c copied to the i2c driver. Modifying driver details is very strange,

Re: [RFC internal PATCH] mfd/mc13xxx: drop modifying driver's id_table in probe

2012-07-11 Thread Shawn Guo
On Wed, Jul 11, 2012 at 01:36:48PM +0200, Uwe Kleine-König wrote: > This was introduced in commit > > 876989d (mfd: Add device tree probe support for mc13xxx) > > for spi and later while introducing support for i2c copied to the i2c > driver. > > Modifying driver details is very strange,

[RFC internal PATCH] mfd/mc13xxx: drop modifying driver's id_table in probe

2012-07-11 Thread Uwe Kleine-König
This was introduced in commit 876989d (mfd: Add device tree probe support for mc13xxx) for spi and later while introducing support for i2c copied to the i2c driver. Modifying driver details is very strange, for example probing an mc13892 device (instantiated via dt) removes the driver's

[RFC internal PATCH] mfd/mc13xxx: drop modifying driver's id_table in probe

2012-07-11 Thread Uwe Kleine-König
This was introduced in commit 876989d (mfd: Add device tree probe support for mc13xxx) for spi and later while introducing support for i2c copied to the i2c driver. Modifying driver details is very strange, for example probing an mc13892 device (instantiated via dt) removes the driver's

Re: [RFC internal PATCH] mfd/mc13xxx: drop modifying driver's id_table in probe

2012-07-11 Thread Shawn Guo
On Wed, Jul 11, 2012 at 01:36:48PM +0200, Uwe Kleine-König wrote: This was introduced in commit 876989d (mfd: Add device tree probe support for mc13xxx) for spi and later while introducing support for i2c copied to the i2c driver. Modifying driver details is very strange, for