Re: [RFC v1 7/9] ASoC: msm8x16: Add sound mixer controls.

On Wed, Feb 17, 2016 at 10:58:02AM +, Srinivas Kandagatla wrote: > I will relook into the modern codec drivers and rewrite the driver to be > inline with them. It probably doesn't need a complete rewrite but it does need a review and update to meet modern standards. signature.asc

Re: [RFC v1 7/9] ASoC: msm8x16: Add sound mixer controls.

On Wed, Feb 17, 2016 at 10:58:02AM +, Srinivas Kandagatla wrote: > I will relook into the modern codec drivers and rewrite the driver to be > inline with them. It probably doesn't need a complete rewrite but it does need a review and update to meet modern standards. signature.asc

Re: [RFC v1 7/9] ASoC: msm8x16: Add sound mixer controls.

Thanks for your comments on the patch series. On 16/02/16 20:21, Mark Brown wrote: On Tue, Feb 16, 2016 at 05:33:28PM +, Srinivas Kandagatla wrote: +static const char * const msm8x16_wcd_spk_boost_ctrl_text[] = { + "DISABLE", "ENABLE"}; On/off switches should be presented

Re: [RFC v1 7/9] ASoC: msm8x16: Add sound mixer controls.

Thanks for your comments on the patch series. On 16/02/16 20:21, Mark Brown wrote: On Tue, Feb 16, 2016 at 05:33:28PM +, Srinivas Kandagatla wrote: +static const char * const msm8x16_wcd_spk_boost_ctrl_text[] = { + "DISABLE", "ENABLE"}; On/off switches should be presented

Re: [RFC v1 7/9] ASoC: msm8x16: Add sound mixer controls.

On Tue, Feb 16, 2016 at 05:33:28PM +, Srinivas Kandagatla wrote: > +static const char * const msm8x16_wcd_spk_boost_ctrl_text[] = { > + "DISABLE", "ENABLE"}; On/off switches should be presented to usersrpace as on/off switches with "Switch" at the end of their name not as

Re: [RFC v1 7/9] ASoC: msm8x16: Add sound mixer controls.

On Tue, Feb 16, 2016 at 05:33:28PM +, Srinivas Kandagatla wrote: > +static const char * const msm8x16_wcd_spk_boost_ctrl_text[] = { > + "DISABLE", "ENABLE"}; On/off switches should be presented to usersrpace as on/off switches with "Switch" at the end of their name not as

[RFC v1 7/9] ASoC: msm8x16: Add sound mixer controls.

This patch adds basic mixer controls found in the codec. Signed-off-by: Srinivas Kandagatla --- sound/soc/codecs/msm8x16-wcd.c | 99 ++ 1 file changed, 99 insertions(+) diff --git a/sound/soc/codecs/msm8x16-wcd.c

[RFC v1 7/9] ASoC: msm8x16: Add sound mixer controls.

This patch adds basic mixer controls found in the codec. Signed-off-by: Srinivas Kandagatla --- sound/soc/codecs/msm8x16-wcd.c | 99 ++ 1 file changed, 99 insertions(+) diff --git a/sound/soc/codecs/msm8x16-wcd.c b/sound/soc/codecs/msm8x16-wcd.c index