Re: [RFC v2] memory-hotplug: remove MIGRATE_ISOLATE from free_area->free_list

2012-09-13 Thread Minchan Kim
Hi Bart, On Thu, Sep 13, 2012 at 04:21:42PM +0200, Bartlomiej Zolnierkiewicz wrote: > On Thursday 06 September 2012 18:34:35 Bartlomiej Zolnierkiewicz wrote: > > > > Hi, > > > > On Thursday 06 September 2012 04:53:38 Minchan Kim wrote: > > > Normally, MIGRATE_ISOLATE type is used for

Re: [RFC v2] memory-hotplug: remove MIGRATE_ISOLATE from free_area->free_list

2012-09-13 Thread Bartlomiej Zolnierkiewicz
On Thursday 06 September 2012 18:34:35 Bartlomiej Zolnierkiewicz wrote: > > Hi, > > On Thursday 06 September 2012 04:53:38 Minchan Kim wrote: > > Normally, MIGRATE_ISOLATE type is used for memory-hotplug. > > But it's irony type because the pages isolated would exist > > as free page in

Re: [RFC v2] memory-hotplug: remove MIGRATE_ISOLATE from free_area-free_list

2012-09-13 Thread Bartlomiej Zolnierkiewicz
On Thursday 06 September 2012 18:34:35 Bartlomiej Zolnierkiewicz wrote: Hi, On Thursday 06 September 2012 04:53:38 Minchan Kim wrote: Normally, MIGRATE_ISOLATE type is used for memory-hotplug. But it's irony type because the pages isolated would exist as free page in

Re: [RFC v2] memory-hotplug: remove MIGRATE_ISOLATE from free_area-free_list

2012-09-13 Thread Minchan Kim
Hi Bart, On Thu, Sep 13, 2012 at 04:21:42PM +0200, Bartlomiej Zolnierkiewicz wrote: On Thursday 06 September 2012 18:34:35 Bartlomiej Zolnierkiewicz wrote: Hi, On Thursday 06 September 2012 04:53:38 Minchan Kim wrote: Normally, MIGRATE_ISOLATE type is used for memory-hotplug. But

Re: [RFC v2] memory-hotplug: remove MIGRATE_ISOLATE from free_area->free_list

2012-09-11 Thread Minchan Kim
On Tue, Sep 11, 2012 at 09:37:54AM +0800, Wen Congyang wrote: > At 09/11/2012 08:52 AM, Minchan Kim Wrote: > > Hello Wen, > > > > On Fri, Sep 07, 2012 at 03:28:22PM +0800, Wen Congyang wrote: > >> At 09/06/2012 10:53 AM, Minchan Kim Wrote: > >>> Normally, MIGRATE_ISOLATE type is used for

Re: [RFC v2] memory-hotplug: remove MIGRATE_ISOLATE from free_area-free_list

2012-09-11 Thread Minchan Kim
On Tue, Sep 11, 2012 at 09:37:54AM +0800, Wen Congyang wrote: At 09/11/2012 08:52 AM, Minchan Kim Wrote: Hello Wen, On Fri, Sep 07, 2012 at 03:28:22PM +0800, Wen Congyang wrote: At 09/06/2012 10:53 AM, Minchan Kim Wrote: Normally, MIGRATE_ISOLATE type is used for memory-hotplug. But

Re: [RFC v2] memory-hotplug: remove MIGRATE_ISOLATE from free_area->free_list

2012-09-10 Thread Wen Congyang
At 09/11/2012 08:52 AM, Minchan Kim Wrote: > Hello Wen, > > On Fri, Sep 07, 2012 at 03:28:22PM +0800, Wen Congyang wrote: >> At 09/06/2012 10:53 AM, Minchan Kim Wrote: >>> Normally, MIGRATE_ISOLATE type is used for memory-hotplug. >>> But it's irony type because the pages isolated would exist >>>

Re: [RFC v2] memory-hotplug: remove MIGRATE_ISOLATE from free_area->free_list

2012-09-10 Thread Minchan Kim
Hello Wen, On Fri, Sep 07, 2012 at 03:28:22PM +0800, Wen Congyang wrote: > At 09/06/2012 10:53 AM, Minchan Kim Wrote: > > Normally, MIGRATE_ISOLATE type is used for memory-hotplug. > > But it's irony type because the pages isolated would exist > > as free page in

Re: [RFC v2] memory-hotplug: remove MIGRATE_ISOLATE from free_area->free_list

2012-09-10 Thread Minchan Kim
Hi Bart, On Thu, Sep 06, 2012 at 06:34:35PM +0200, Bartlomiej Zolnierkiewicz wrote: > > Hi, > > On Thursday 06 September 2012 04:53:38 Minchan Kim wrote: > > Normally, MIGRATE_ISOLATE type is used for memory-hotplug. > > But it's irony type because the pages isolated would exist > > as free

Re: [RFC v2] memory-hotplug: remove MIGRATE_ISOLATE from free_area-free_list

2012-09-10 Thread Minchan Kim
Hi Bart, On Thu, Sep 06, 2012 at 06:34:35PM +0200, Bartlomiej Zolnierkiewicz wrote: Hi, On Thursday 06 September 2012 04:53:38 Minchan Kim wrote: Normally, MIGRATE_ISOLATE type is used for memory-hotplug. But it's irony type because the pages isolated would exist as free page in

Re: [RFC v2] memory-hotplug: remove MIGRATE_ISOLATE from free_area-free_list

2012-09-10 Thread Minchan Kim
Hello Wen, On Fri, Sep 07, 2012 at 03:28:22PM +0800, Wen Congyang wrote: At 09/06/2012 10:53 AM, Minchan Kim Wrote: Normally, MIGRATE_ISOLATE type is used for memory-hotplug. But it's irony type because the pages isolated would exist as free page in free_area-free_list[MIGRATE_ISOLATE] so

Re: [RFC v2] memory-hotplug: remove MIGRATE_ISOLATE from free_area-free_list

2012-09-10 Thread Wen Congyang
At 09/11/2012 08:52 AM, Minchan Kim Wrote: Hello Wen, On Fri, Sep 07, 2012 at 03:28:22PM +0800, Wen Congyang wrote: At 09/06/2012 10:53 AM, Minchan Kim Wrote: Normally, MIGRATE_ISOLATE type is used for memory-hotplug. But it's irony type because the pages isolated would exist as free page

Re: [RFC v2] memory-hotplug: remove MIGRATE_ISOLATE from free_area->free_list

2012-09-07 Thread Wen Congyang
At 09/06/2012 10:53 AM, Minchan Kim Wrote: > Normally, MIGRATE_ISOLATE type is used for memory-hotplug. > But it's irony type because the pages isolated would exist > as free page in free_area->free_list[MIGRATE_ISOLATE] so people > can think of it as allocatable pages but it is *never*

Re: [RFC v2] memory-hotplug: remove MIGRATE_ISOLATE from free_area-free_list

2012-09-07 Thread Wen Congyang
At 09/06/2012 10:53 AM, Minchan Kim Wrote: Normally, MIGRATE_ISOLATE type is used for memory-hotplug. But it's irony type because the pages isolated would exist as free page in free_area-free_list[MIGRATE_ISOLATE] so people can think of it as allocatable pages but it is *never* allocatable.

Re: [RFC v2] memory-hotplug: remove MIGRATE_ISOLATE from free_area->free_list

2012-09-06 Thread Bartlomiej Zolnierkiewicz
Hi, On Thursday 06 September 2012 04:53:38 Minchan Kim wrote: > Normally, MIGRATE_ISOLATE type is used for memory-hotplug. > But it's irony type because the pages isolated would exist > as free page in free_area->free_list[MIGRATE_ISOLATE] so people > can think of it as allocatable pages but it

Re: [RFC v2] memory-hotplug: remove MIGRATE_ISOLATE from free_area->free_list

2012-09-06 Thread Michal Nazarewicz
>> +pfn = page_to_pfn(page); >> +if (pfn >= end_pfn) >> +return false; >> +if (pfn >= start_pfn) >> +goto found; On Thu, Sep 06 2012, Lai Jiangshan wrote: > this test is wrong. > > use this: > > if ((pfn <= start_pfn) &&

Re: [RFC v2] memory-hotplug: remove MIGRATE_ISOLATE from free_area->free_list

2012-09-06 Thread Michal Nazarewicz
On Thu, Sep 06 2012, Lai Jiangshan wrote: > +found: > + next_pfn = page_to_pfn(page); > + list_for_each_entry_from(page, _pages, lru) { > + if (page_to_pfn(page) != next_pfn) > + return false; > + pfn = page_to_pfn(page); + pfn =

Re: [RFC v2] memory-hotplug: remove MIGRATE_ISOLATE from free_area->free_list

2012-09-06 Thread Michal Nazarewicz
On Thu, Sep 06 2012, Minchan Kim wrote: > Normally, MIGRATE_ISOLATE type is used for memory-hotplug. > But it's irony type because the pages isolated would exist > as free page in free_area->free_list[MIGRATE_ISOLATE] so people > can think of it as allocatable pages but it is *never* allocatable.

Re: [RFC v2] memory-hotplug: remove MIGRATE_ISOLATE from free_area->free_list

2012-09-06 Thread Lai Jiangshan
On 09/06/2012 04:18 PM, Minchan Kim wrote: > Hello Lai, > > On Thu, Sep 06, 2012 at 04:14:51PM +0800, Lai Jiangshan wrote: >> On 09/06/2012 10:53 AM, Minchan Kim wrote: >>> Normally, MIGRATE_ISOLATE type is used for memory-hotplug. >>> But it's irony type because the pages isolated would exist

Re: [RFC v2] memory-hotplug: remove MIGRATE_ISOLATE from free_area->free_list

2012-09-06 Thread Lai Jiangshan
On 09/06/2012 04:18 PM, Minchan Kim wrote: > Hello Lai, > > On Thu, Sep 06, 2012 at 04:14:51PM +0800, Lai Jiangshan wrote: >> On 09/06/2012 10:53 AM, Minchan Kim wrote: >>> Normally, MIGRATE_ISOLATE type is used for memory-hotplug. >>> But it's irony type because the pages isolated would exist

Re: [RFC v2] memory-hotplug: remove MIGRATE_ISOLATE from free_area->free_list

2012-09-06 Thread Minchan Kim
Hello Lai, On Thu, Sep 06, 2012 at 04:14:51PM +0800, Lai Jiangshan wrote: > On 09/06/2012 10:53 AM, Minchan Kim wrote: > > Normally, MIGRATE_ISOLATE type is used for memory-hotplug. > > But it's irony type because the pages isolated would exist > > as free page in

Re: [RFC v2] memory-hotplug: remove MIGRATE_ISOLATE from free_area->free_list

2012-09-06 Thread Lai Jiangshan
On 09/06/2012 10:53 AM, Minchan Kim wrote: > Normally, MIGRATE_ISOLATE type is used for memory-hotplug. > But it's irony type because the pages isolated would exist > as free page in free_area->free_list[MIGRATE_ISOLATE] so people > can think of it as allocatable pages but it is *never*

Re: [RFC v2] memory-hotplug: remove MIGRATE_ISOLATE from free_area-free_list

2012-09-06 Thread Lai Jiangshan
On 09/06/2012 10:53 AM, Minchan Kim wrote: Normally, MIGRATE_ISOLATE type is used for memory-hotplug. But it's irony type because the pages isolated would exist as free page in free_area-free_list[MIGRATE_ISOLATE] so people can think of it as allocatable pages but it is *never* allocatable.

Re: [RFC v2] memory-hotplug: remove MIGRATE_ISOLATE from free_area-free_list

2012-09-06 Thread Minchan Kim
Hello Lai, On Thu, Sep 06, 2012 at 04:14:51PM +0800, Lai Jiangshan wrote: On 09/06/2012 10:53 AM, Minchan Kim wrote: Normally, MIGRATE_ISOLATE type is used for memory-hotplug. But it's irony type because the pages isolated would exist as free page in free_area-free_list[MIGRATE_ISOLATE] so

Re: [RFC v2] memory-hotplug: remove MIGRATE_ISOLATE from free_area-free_list

2012-09-06 Thread Lai Jiangshan
On 09/06/2012 04:18 PM, Minchan Kim wrote: Hello Lai, On Thu, Sep 06, 2012 at 04:14:51PM +0800, Lai Jiangshan wrote: On 09/06/2012 10:53 AM, Minchan Kim wrote: Normally, MIGRATE_ISOLATE type is used for memory-hotplug. But it's irony type because the pages isolated would exist as free page

Re: [RFC v2] memory-hotplug: remove MIGRATE_ISOLATE from free_area-free_list

2012-09-06 Thread Lai Jiangshan
On 09/06/2012 04:18 PM, Minchan Kim wrote: Hello Lai, On Thu, Sep 06, 2012 at 04:14:51PM +0800, Lai Jiangshan wrote: On 09/06/2012 10:53 AM, Minchan Kim wrote: Normally, MIGRATE_ISOLATE type is used for memory-hotplug. But it's irony type because the pages isolated would exist as free page

Re: [RFC v2] memory-hotplug: remove MIGRATE_ISOLATE from free_area-free_list

2012-09-06 Thread Michal Nazarewicz
On Thu, Sep 06 2012, Minchan Kim wrote: Normally, MIGRATE_ISOLATE type is used for memory-hotplug. But it's irony type because the pages isolated would exist as free page in free_area-free_list[MIGRATE_ISOLATE] so people can think of it as allocatable pages but it is *never* allocatable. It

Re: [RFC v2] memory-hotplug: remove MIGRATE_ISOLATE from free_area-free_list

2012-09-06 Thread Michal Nazarewicz
On Thu, Sep 06 2012, Lai Jiangshan wrote: +found: + next_pfn = page_to_pfn(page); + list_for_each_entry_from(page, isolated_pages, lru) { + if (page_to_pfn(page) != next_pfn) + return false; + pfn = page_to_pfn(page); + pfn =

Re: [RFC v2] memory-hotplug: remove MIGRATE_ISOLATE from free_area-free_list

2012-09-06 Thread Michal Nazarewicz
+pfn = page_to_pfn(page); +if (pfn = end_pfn) +return false; +if (pfn = start_pfn) +goto found; On Thu, Sep 06 2012, Lai Jiangshan wrote: this test is wrong. use this: if ((pfn = start_pfn) (start_pfn pfn +

Re: [RFC v2] memory-hotplug: remove MIGRATE_ISOLATE from free_area-free_list

2012-09-06 Thread Bartlomiej Zolnierkiewicz
Hi, On Thursday 06 September 2012 04:53:38 Minchan Kim wrote: Normally, MIGRATE_ISOLATE type is used for memory-hotplug. But it's irony type because the pages isolated would exist as free page in free_area-free_list[MIGRATE_ISOLATE] so people can think of it as allocatable pages but it is

[RFC v2] memory-hotplug: remove MIGRATE_ISOLATE from free_area->free_list

2012-09-05 Thread Minchan Kim
Normally, MIGRATE_ISOLATE type is used for memory-hotplug. But it's irony type because the pages isolated would exist as free page in free_area->free_list[MIGRATE_ISOLATE] so people can think of it as allocatable pages but it is *never* allocatable. It ends up confusing NR_FREE_PAGES vmstat so it

[RFC v2] memory-hotplug: remove MIGRATE_ISOLATE from free_area-free_list

2012-09-05 Thread Minchan Kim
Normally, MIGRATE_ISOLATE type is used for memory-hotplug. But it's irony type because the pages isolated would exist as free page in free_area-free_list[MIGRATE_ISOLATE] so people can think of it as allocatable pages but it is *never* allocatable. It ends up confusing NR_FREE_PAGES vmstat so it