Re: [RFC v2 1/1] RTL8712 alignment bug in 3.6 and up on ARMV5

2012-12-15 Thread Dan Carpenter
Thanks for fixing this bug. Your patch works but it's not the right way to do it. The original code here adds 4 to pointers which are currently aligned instead of leaving them as is. We have a kernel ALIGN() macro which works correctly, but actually, it's not needed. On arm, the pointer returne

Re: [RFC v2 1/1] RTL8712 alignment bug in 3.6 and up on ARMV5

2012-12-14 Thread Josh Coombs
Given 3.7 has shipped, should I rebase on release and put a new RFC post up, rebase on linux-next, wait for a 3.8-rc or just post it up as v2 for submission this time as is? Josh C On Mon, Nov 26, 2012 at 4:38 PM, Josh Coombs wrote: > I've been banging on my test setup for the past week. I have

[RFC v2 1/1] RTL8712 alignment bug in 3.6 and up on ARMV5

2012-11-26 Thread Josh Coombs
I've been banging on my test setup for the past week. I haven't tracked down the cause yet, but something in my prior build system results in this problem being masked with some builds. Doing pure vanilla builds from git I'm able to reproduce with 3.6 and the 3.7-rc series reliably. Support for