Re: [RFC v3 1/9] sysrq: Implement __handle_sysrq_nolock to avoid recursive locking in kdb

2014-04-29 Thread Colin Cross
On Tue, Apr 29, 2014 at 1:59 AM, Daniel Thompson wrote: > On 28/04/14 18:44, Colin Cross wrote: Is that case documented somewhere in the code comments? >>> >>> Perhaps not near enough to the _nolock but the primary bit of comment is >>> here (and in same file as kdb_sr). >>> --- cut here ---

Re: [RFC v3 1/9] sysrq: Implement __handle_sysrq_nolock to avoid recursive locking in kdb

2014-04-29 Thread Daniel Thompson
On 28/04/14 18:44, Colin Cross wrote: >>> Is that case documented somewhere in the code comments? >> >> Perhaps not near enough to the _nolock but the primary bit of comment is >> here (and in same file as kdb_sr). >> --- cut here --- >> * kdb_main_loop - After initial setup and assignment of the

Re: [RFC v3 1/9] sysrq: Implement __handle_sysrq_nolock to avoid recursive locking in kdb

2014-04-29 Thread Daniel Thompson
On 28/04/14 18:44, Colin Cross wrote: Is that case documented somewhere in the code comments? Perhaps not near enough to the _nolock but the primary bit of comment is here (and in same file as kdb_sr). --- cut here --- * kdb_main_loop - After initial setup and assignment of the *

Re: [RFC v3 1/9] sysrq: Implement __handle_sysrq_nolock to avoid recursive locking in kdb

2014-04-29 Thread Colin Cross
On Tue, Apr 29, 2014 at 1:59 AM, Daniel Thompson daniel.thomp...@linaro.org wrote: On 28/04/14 18:44, Colin Cross wrote: Is that case documented somewhere in the code comments? Perhaps not near enough to the _nolock but the primary bit of comment is here (and in same file as kdb_sr). --- cut

Re: [RFC v3 1/9] sysrq: Implement __handle_sysrq_nolock to avoid recursive locking in kdb

2014-04-28 Thread Daniel Thompson
On 28/04/14 18:44, Colin Cross wrote: >>> Is that case documented somewhere in the code comments? >> >> Perhaps not near enough to the _nolock but the primary bit of comment is >> here (and in same file as kdb_sr). >> --- cut here --- >> * kdb_main_loop - After initial setup and assignment of the

Re: [RFC v3 1/9] sysrq: Implement __handle_sysrq_nolock to avoid recursive locking in kdb

2014-04-28 Thread Colin Cross
On Mon, Apr 28, 2014 at 3:24 AM, Daniel Thompson wrote: > On 25/04/14 17:45, Steven Rostedt wrote: >> On Fri, 25 Apr 2014 17:29:22 +0100 >> Daniel Thompson wrote: >> >>> If kdb is triggered using SysRq-g then any use of the sr command results >>> in the SysRq key table lock being recursively

Re: [RFC v3 1/9] sysrq: Implement __handle_sysrq_nolock to avoid recursive locking in kdb

2014-04-28 Thread Daniel Thompson
On 25/04/14 17:45, Steven Rostedt wrote: > On Fri, 25 Apr 2014 17:29:22 +0100 > Daniel Thompson wrote: > >> If kdb is triggered using SysRq-g then any use of the sr command results >> in the SysRq key table lock being recursively acquired, killing the debug >> session. That patch resolves the

Re: [RFC v3 1/9] sysrq: Implement __handle_sysrq_nolock to avoid recursive locking in kdb

2014-04-28 Thread Daniel Thompson
On 25/04/14 17:45, Steven Rostedt wrote: On Fri, 25 Apr 2014 17:29:22 +0100 Daniel Thompson daniel.thomp...@linaro.org wrote: If kdb is triggered using SysRq-g then any use of the sr command results in the SysRq key table lock being recursively acquired, killing the debug session. That

Re: [RFC v3 1/9] sysrq: Implement __handle_sysrq_nolock to avoid recursive locking in kdb

2014-04-28 Thread Colin Cross
On Mon, Apr 28, 2014 at 3:24 AM, Daniel Thompson daniel.thomp...@linaro.org wrote: On 25/04/14 17:45, Steven Rostedt wrote: On Fri, 25 Apr 2014 17:29:22 +0100 Daniel Thompson daniel.thomp...@linaro.org wrote: If kdb is triggered using SysRq-g then any use of the sr command results in the

Re: [RFC v3 1/9] sysrq: Implement __handle_sysrq_nolock to avoid recursive locking in kdb

2014-04-28 Thread Daniel Thompson
On 28/04/14 18:44, Colin Cross wrote: Is that case documented somewhere in the code comments? Perhaps not near enough to the _nolock but the primary bit of comment is here (and in same file as kdb_sr). --- cut here --- * kdb_main_loop - After initial setup and assignment of the *

Re: [RFC v3 1/9] sysrq: Implement __handle_sysrq_nolock to avoid recursive locking in kdb

2014-04-25 Thread Steven Rostedt
On Fri, 25 Apr 2014 17:29:22 +0100 Daniel Thompson wrote: > If kdb is triggered using SysRq-g then any use of the sr command results > in the SysRq key table lock being recursively acquired, killing the debug > session. That patch resolves the problem by introducing a _nolock > alternative for

[RFC v3 1/9] sysrq: Implement __handle_sysrq_nolock to avoid recursive locking in kdb

2014-04-25 Thread Daniel Thompson
If kdb is triggered using SysRq-g then any use of the sr command results in the SysRq key table lock being recursively acquired, killing the debug session. That patch resolves the problem by introducing a _nolock alternative for __handle_sysrq. Strictly speaking this approach risks racing on the

[RFC v3 1/9] sysrq: Implement __handle_sysrq_nolock to avoid recursive locking in kdb

2014-04-25 Thread Daniel Thompson
If kdb is triggered using SysRq-g then any use of the sr command results in the SysRq key table lock being recursively acquired, killing the debug session. That patch resolves the problem by introducing a _nolock alternative for __handle_sysrq. Strictly speaking this approach risks racing on the

Re: [RFC v3 1/9] sysrq: Implement __handle_sysrq_nolock to avoid recursive locking in kdb

2014-04-25 Thread Steven Rostedt
On Fri, 25 Apr 2014 17:29:22 +0100 Daniel Thompson daniel.thomp...@linaro.org wrote: If kdb is triggered using SysRq-g then any use of the sr command results in the SysRq key table lock being recursively acquired, killing the debug session. That patch resolves the problem by introducing a