Re: [RFC v3 19/45] richacl: Also recognize nontrivial mode-equivalent acls

2015-05-27 Thread J. Bruce Fields
On Wed, May 27, 2015 at 11:24:49AM +0200, Andreas Grünbacher wrote: > Bruce, > > 2015-05-15 22:51 GMT+02:00 J. Bruce Fields : > > On Fri, Apr 24, 2015 at 01:04:16PM +0200, Andreas Gruenbacher wrote: > > This comment is a little confusing: > > > >> + * This function does not consider the masks in @

Re: [RFC v3 19/45] richacl: Also recognize nontrivial mode-equivalent acls

2015-05-27 Thread Andreas Grünbacher
Bruce, 2015-05-15 22:51 GMT+02:00 J. Bruce Fields : > On Fri, Apr 24, 2015 at 01:04:16PM +0200, Andreas Gruenbacher wrote: > This comment is a little confusing: > >> + * This function does not consider the masks in @acl. > > Given that we do this later: > >> + if (acl->a_flags & RICHACL_MASKED

Re: [RFC v3 19/45] richacl: Also recognize nontrivial mode-equivalent acls

2015-05-15 Thread J. Bruce Fields
On Fri, Apr 24, 2015 at 01:04:16PM +0200, Andreas Gruenbacher wrote: > So far, richacl_equiv_mode() is relatively limited in the types of acl it > considers equivalent to a file mode: it only accepts masked acls with a single > everyone@:rwpxd::allow entry. > > Change this to consider all acls equ

Re: [RFC v3 19/45] richacl: Also recognize nontrivial mode-equivalent acls

2015-05-15 Thread J. Bruce Fields
On Thu, May 14, 2015 at 03:28:06PM -0400, bfields wrote: > On Fri, Apr 24, 2015 at 01:04:16PM +0200, Andreas Gruenbacher wrote: > > So far, richacl_equiv_mode() is relatively limited in the types of acl it > > considers equivalent to a file mode: it only accepts masked acls with a > > single > > e

Re: [RFC v3 19/45] richacl: Also recognize nontrivial mode-equivalent acls

2015-05-14 Thread J. Bruce Fields
On Fri, Apr 24, 2015 at 01:04:16PM +0200, Andreas Gruenbacher wrote: > So far, richacl_equiv_mode() is relatively limited in the types of acl it > considers equivalent to a file mode: it only accepts masked acls with a single > everyone@:rwpxd::allow entry. > > Change this to consider all acls equ

[RFC v3 19/45] richacl: Also recognize nontrivial mode-equivalent acls

2015-04-24 Thread Andreas Gruenbacher
So far, richacl_equiv_mode() is relatively limited in the types of acl it considers equivalent to a file mode: it only accepts masked acls with a single everyone@:rwpxd::allow entry. Change this to consider all acls equivalent to file modes if they only consist of owner@, group@, and everyone@ ent