2015-05-29 0:24 GMT+02:00 Trond Myklebust :
> ...and I'd prefer that we don't keep rewriting code that works.
Sure, go ahead.
Thanks,
Andreas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at
On Thu, May 28, 2015 at 6:09 PM, Andreas Grünbacher
wrote:
> 2015-05-28 23:55 GMT+02:00 Trond Myklebust :
>>> We already do this kind of check with the existing code. What's wrong with
>>> it?
>>
>> Actually, you're right, we don't check for the previous word, however
>> fixing that is a
2015-05-28 23:55 GMT+02:00 Trond Myklebust :
>> We already do this kind of check with the existing code. What's wrong with
>> it?
>
> Actually, you're right, we don't check for the previous word, however
> fixing that is a question of adding 2 extra checks in
> decode_getfattr_attrs(), one in
On Thu, May 28, 2015 at 5:40 PM, Trond Myklebust
wrote:
> On Thu, May 28, 2015 at 5:05 PM, Andreas Grünbacher
> wrote:
>> 2015-05-28 22:50 GMT+02:00 Trond Myklebust :
>>> On Thu, May 28, 2015 at 4:33 PM, J. Bruce Fields
>>> wrote:
On Fri, Apr 24, 2015 at 01:04:33PM +0200, Andreas
On Thu, May 28, 2015 at 5:05 PM, Andreas Grünbacher
wrote:
> 2015-05-28 22:50 GMT+02:00 Trond Myklebust :
>> On Thu, May 28, 2015 at 4:33 PM, J. Bruce Fields
>> wrote:
>>> On Fri, Apr 24, 2015 at 01:04:33PM +0200, Andreas Gruenbacher wrote:
The NFSv4 client sends the server GETATTR
2015-05-28 22:33 GMT+02:00 J. Bruce Fields :
> This is the same list as in nfs4-xdr_enc_server_caps. Could we avoid
> that duplication?
I don't think it matters at all.
Thanks,
Andreas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
2015-05-28 22:33 GMT+02:00 J. Bruce Fields :
> On Fri, Apr 24, 2015 at 01:04:33PM +0200, Andreas Gruenbacher wrote:
>> The client fails to detect when unexpected attributes are sent after the last
>> expected attribute in each word in the bitmap.
>
> Is it important that the client catch that?
2015-05-28 22:50 GMT+02:00 Trond Myklebust :
> On Thu, May 28, 2015 at 4:33 PM, J. Bruce Fields wrote:
>> On Fri, Apr 24, 2015 at 01:04:33PM +0200, Andreas Gruenbacher wrote:
>>> The NFSv4 client sends the server GETATTR requests with different sets of
>>> requested attributes depending on the
On Thu, May 28, 2015 at 4:33 PM, J. Bruce Fields wrote:
> On Fri, Apr 24, 2015 at 01:04:33PM +0200, Andreas Gruenbacher wrote:
>> The NFSv4 client sends the server GETATTR requests with different sets of
>> requested attributes depending on the situation. The requested set of
>> attributes is
On Fri, Apr 24, 2015 at 01:04:33PM +0200, Andreas Gruenbacher wrote:
> The NFSv4 client sends the server GETATTR requests with different sets of
> requested attributes depending on the situation. The requested set of
> attributes is encoded in a bitmap; the server replies with the set of
>
2015-05-28 22:33 GMT+02:00 J. Bruce Fields bfie...@fieldses.org:
On Fri, Apr 24, 2015 at 01:04:33PM +0200, Andreas Gruenbacher wrote:
The client fails to detect when unexpected attributes are sent after the last
expected attribute in each word in the bitmap.
Is it important that the client
On Thu, May 28, 2015 at 5:40 PM, Trond Myklebust
trond.mykleb...@primarydata.com wrote:
On Thu, May 28, 2015 at 5:05 PM, Andreas Grünbacher
andreas.gruenbac...@gmail.com wrote:
2015-05-28 22:50 GMT+02:00 Trond Myklebust trond.mykleb...@primarydata.com:
On Thu, May 28, 2015 at 4:33 PM, J. Bruce
2015-05-28 22:50 GMT+02:00 Trond Myklebust trond.mykleb...@primarydata.com:
On Thu, May 28, 2015 at 4:33 PM, J. Bruce Fields bfie...@fieldses.org wrote:
On Fri, Apr 24, 2015 at 01:04:33PM +0200, Andreas Gruenbacher wrote:
The NFSv4 client sends the server GETATTR requests with different sets of
On Thu, May 28, 2015 at 5:05 PM, Andreas Grünbacher
andreas.gruenbac...@gmail.com wrote:
2015-05-28 22:50 GMT+02:00 Trond Myklebust trond.mykleb...@primarydata.com:
On Thu, May 28, 2015 at 4:33 PM, J. Bruce Fields bfie...@fieldses.org
wrote:
On Fri, Apr 24, 2015 at 01:04:33PM +0200, Andreas
2015-05-28 22:33 GMT+02:00 J. Bruce Fields bfie...@fieldses.org:
This is the same list as in nfs4-xdr_enc_server_caps. Could we avoid
that duplication?
I don't think it matters at all.
Thanks,
Andreas
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a
On Thu, May 28, 2015 at 6:09 PM, Andreas Grünbacher
andreas.gruenbac...@gmail.com wrote:
2015-05-28 23:55 GMT+02:00 Trond Myklebust trond.mykleb...@primarydata.com:
We already do this kind of check with the existing code. What's wrong with
it?
Actually, you're right, we don't check for the
2015-05-28 23:55 GMT+02:00 Trond Myklebust trond.mykleb...@primarydata.com:
We already do this kind of check with the existing code. What's wrong with
it?
Actually, you're right, we don't check for the previous word, however
fixing that is a question of adding 2 extra checks in
On Fri, Apr 24, 2015 at 01:04:33PM +0200, Andreas Gruenbacher wrote:
The NFSv4 client sends the server GETATTR requests with different sets of
requested attributes depending on the situation. The requested set of
attributes is encoded in a bitmap; the server replies with the set of
attributes
On Thu, May 28, 2015 at 4:33 PM, J. Bruce Fields bfie...@fieldses.org wrote:
On Fri, Apr 24, 2015 at 01:04:33PM +0200, Andreas Gruenbacher wrote:
The NFSv4 client sends the server GETATTR requests with different sets of
requested attributes depending on the situation. The requested set of
2015-05-29 0:24 GMT+02:00 Trond Myklebust trond.mykleb...@primarydata.com:
...and I'd prefer that we don't keep rewriting code that works.
Sure, go ahead.
Thanks,
Andreas
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to
The NFSv4 client sends the server GETATTR requests with different sets of
requested attributes depending on the situation. The requested set of
attributes is encoded in a bitmap; the server replies with the set of
attributes it could return. These bitmaps can be several words wide. The
bitmap
The NFSv4 client sends the server GETATTR requests with different sets of
requested attributes depending on the situation. The requested set of
attributes is encoded in a bitmap; the server replies with the set of
attributes it could return. These bitmaps can be several words wide. The
bitmap
22 matches
Mail list logo
