Re: [RFC v9 PATCH 2/4] mm: mmap: zap pages with read mmap_sem in munmap

2018-09-12 Thread Yang Shi
On 9/12/18 2:11 AM, Michal Hocko wrote: On Tue 11-09-18 19:29:21, Matthew Wilcox wrote: On Tue, Sep 11, 2018 at 04:35:03PM -0700, Yang Shi wrote: [...] I didn't get to read the patch yet. If you guys think this is the better way I could convert my patches to go this way. It is simple to

Re: [RFC v9 PATCH 2/4] mm: mmap: zap pages with read mmap_sem in munmap

2018-09-12 Thread Michal Hocko
On Tue 11-09-18 19:29:21, Matthew Wilcox wrote: > On Tue, Sep 11, 2018 at 04:35:03PM -0700, Yang Shi wrote: [...] I didn't get to read the patch yet. > > And, Michal prefers have VM_HUGETLB and VM_PFNMAP handled separately for > > safe and bisectable sake, which needs call the regular do_munmap()

Re: [RFC v9 PATCH 2/4] mm: mmap: zap pages with read mmap_sem in munmap

2018-09-11 Thread Matthew Wilcox
On Tue, Sep 11, 2018 at 04:35:03PM -0700, Yang Shi wrote: > On 9/11/18 2:16 PM, Matthew Wilcox wrote: > > On Wed, Sep 12, 2018 at 04:58:11AM +0800, Yang Shi wrote: > > > mm/mmap.c | 97 > > > +-- > > I really think you're going about thi

Re: [RFC v9 PATCH 2/4] mm: mmap: zap pages with read mmap_sem in munmap

2018-09-11 Thread Yang Shi
On 9/11/18 2:16 PM, Matthew Wilcox wrote: On Wed, Sep 12, 2018 at 04:58:11AM +0800, Yang Shi wrote: mm/mmap.c | 97 +-- I really think you're going about this the wrong way by duplicating vm_munmap(). If we don't duplicate vm_mun

Re: [RFC v9 PATCH 2/4] mm: mmap: zap pages with read mmap_sem in munmap

2018-09-11 Thread Matthew Wilcox
On Wed, Sep 12, 2018 at 04:58:11AM +0800, Yang Shi wrote: > mm/mmap.c | 97 > +-- I really think you're going about this the wrong way by duplicating vm_munmap().

[RFC v9 PATCH 2/4] mm: mmap: zap pages with read mmap_sem in munmap

2018-09-11 Thread Yang Shi
When running some mmap/munmap scalability tests with large memory (i.e. > 300GB), the below hung task issue may happen occasionally. INFO: task ps:14018 blocked for more than 120 seconds. Tainted: GE 4.9.79-009.ali3000.alios7.x86_64 #1 "echo 0 > /proc/sys/kernel/hung_task_timeo