Hi Sjur,
On Wed, Sep 19, 2012 at 1:08 PM, Sjur BRENDELAND
wrote:
>> > include/linux/modem_shm/ste_modem.h | 71 ++
>>
>> Why did you decide to create a separate folder for this header ? if
>> it's STE specific, maybe use an 'ste' prefix for it too ?
>
> There has been some attempt to upstr
Hi Ohad,
> Very nice driver, thanks for all your work. I have some comments below.
Thank you :-). I'll try to make a new spin asap.
> > include/linux/modem_shm/ste_modem.h | 71 ++
>
> Why did you decide to create a separate folder for this header ? if
> it's STE specific, maybe use an 's
Hi Sjur,
On Tue, Sep 18, 2012 at 9:29 PM, wrote:
> From: Sjur Brændeland
>
> Add support for the STE modem shared memory driver.
> This driver hooks into the remoteproc framework
> in order to manage configuration and the virtio
> devices.
>
> This driver adds custom firmware handlers, because
On Tue, Sep 18, 2012 at 8:48 PM, Alan Cox wrote:
> > +/* make sure the offsets array isn't truncated */
>> + if (table->num * sizeof(table->offset[0]) +
>> + sizeof(struct resource_table) > entry->size) {
>> + sproc_err(sproc, "resource table incomplete\n");
>> +
O> +/* make sure the offsets array isn't truncated */
> + if (table->num * sizeof(table->offset[0]) +
> + sizeof(struct resource_table) > entry->size) {
> + sproc_err(sproc, "resource table incomplete\n");
> + return NULL;
None of these checks appear to be r
From: Sjur Brændeland
Add support for the STE modem shared memory driver.
This driver hooks into the remoteproc framework
in order to manage configuration and the virtio
devices.
This driver adds custom firmware handlers, because
STE modem uses a custom firmware layout.
Signed-off-by: Sjur Bræn
6 matches
Mail list logo
