RE: [RFCv2 07/11] remoteproc: Register virtio devices after vring allocation

2013-01-15 Thread Sjur BRENDELAND
Hi Ido, > On Fri, Dec 14, 2012 at 05:06:56PM +0100, Sjur Brændeland wrote: > > Postpone the registration of virtio devices until all > > vritio ring resource has been allocated. > > This fixes the following bug: The driver's start callback > > is called before all vring notify ids are allocated an

Re: [RFCv2 07/11] remoteproc: Register virtio devices after vring allocation

2012-12-21 Thread Ohad Ben-Cohen
Hi Sjur, On Fri, Dec 21, 2012 at 3:50 PM, Sjur BRENDELAND wrote: > Yes, but I think this will work if we allocate resources first, > and then in the next step register the virtio devices. > All the resources for all the vdevs will be allocated first > and then rproc_boot will be called. This sou

RE: [RFCv2 07/11] remoteproc: Register virtio devices after vring allocation

2012-12-21 Thread Sjur BRENDELAND
Hi Ido, > > Ugh, thanks I missed this. How about calling rproc_alloc_vring from > > rproc_parse_vring so that the resource allocation are done before > > the virtio devices are started? > I don't think that would solve it - rproc_parse_vring is called from > rproc_handle_vdev which is called more

Re: [RFCv2 07/11] remoteproc: Register virtio devices after vring allocation

2012-12-21 Thread Ido Yariv
Hi Sjur, On Fri, Dec 21, 2012 at 01:20:02PM +0100, Sjur BRENDELAND wrote: > Hi Ido, > > > From: Ido Yariv [mailto:i...@wizery.com] > > > Postpone the registration of virtio devices until all > > > vritio ring resource has been allocated. > > > This fixes the following bug: The driver's start call

RE: [RFCv2 07/11] remoteproc: Register virtio devices after vring allocation

2012-12-21 Thread Sjur BRENDELAND
Hi Ido, > From: Ido Yariv [mailto:i...@wizery.com] > > Postpone the registration of virtio devices until all > > vritio ring resource has been allocated. > > This fixes the following bug: The driver's start callback > > is called before all vring notify ids are allocated and > > max_notifyid will

Re: [RFCv2 07/11] remoteproc: Register virtio devices after vring allocation

2012-12-20 Thread Ido Yariv
Hi Sjur, On Fri, Dec 14, 2012 at 05:06:56PM +0100, Sjur Brændeland wrote: > Postpone the registration of virtio devices until all > vritio ring resource has been allocated. > This fixes the following bug: The driver's start callback > is called before all vring notify ids are allocated and > max_n

[RFCv2 07/11] remoteproc: Register virtio devices after vring allocation

2012-12-14 Thread Sjur Brændeland
Postpone the registration of virtio devices until all vritio ring resource has been allocated. This fixes the following bug: The driver's start callback is called before all vring notify ids are allocated and max_notifyid will be increased after starting the remoteproc. Signed-off-by: Sjur Brændel