Re: [RFT/PATCH] Input: bfin_rotary - introduce open and close methods

Acked-by: Sonic Zhang On Thu, Feb 12, 2015 at 3:54 PM, Dmitry Torokhov wrote: > Hi Sonic, > > On Fri, Feb 06, 2015 at 05:37:29PM +0800, Sonic Zhang wrote: >> Hi Dmitry, >> >> After apply your patch manually to my blackfin kernel tree, I got >> kernel panic when probe the rotary. > > Hmm, I found

Re: [RFT/PATCH] Input: bfin_rotary - introduce open and close methods

Hi Sonic, On Fri, Feb 06, 2015 at 05:37:29PM +0800, Sonic Zhang wrote: > Hi Dmitry, > > After apply your patch manually to my blackfin kernel tree, I got > kernel panic when probe the rotary. Hmm, I found one potential issue that might cause panic, but it was preexisting Anyway, I uploaded a

Re: [RFT/PATCH] Input: bfin_rotary - introduce open and close methods

Hi Dmitry, After apply your patch manually to my blackfin kernel tree, I got kernel panic when probe the rotary. NULL pointer access Kernel OOPS in progress Deferred Exception context CURRENT PROCESS: COMM=swapper PID=1 CPU=0 invalid mm return address: [0x00167648]; contents of: 0x00167620: f00

Re: [RFT/PATCH] Input: bfin_rotary - introduce open and close methods

Hi Dmitry, On Fri, Feb 6, 2015 at 2:56 PM, Dmitry Torokhov wrote: > Introduce open and close methods for the input device to postpone enabling > the device until it is needed. > > Signed-off-by: Dmitry Torokhov > --- > > Hi Sonic, > > Could you please tell me if the driver still works with this

[RFT/PATCH] Input: bfin_rotary - introduce open and close methods

Introduce open and close methods for the input device to postpone enabling the device until it is needed. Signed-off-by: Dmitry Torokhov --- Hi Sonic, Could you please tell me if the driver still works with this parch? Thanks! drivers/input/misc/bfin_rotary.c | 70 ---