Re: [RFT 1/1] single_chip test

2008-02-07 Thread Tino Keitel
On Thu, Feb 07, 2008 at 22:51:04 +0100, Jiri Slaby wrote: [...] > What's the srev a phy ver printed few lines above this, please? ath5k_pci :02:00.0: registered as 'phy0' SINGLE: 1, srev: a3, phy: phy0: Selected rate control algorithm 'pid' ath5k phy0: Atheros AR5424 chip found (MAC: 0xa3,

Re: [RFT 1/1] single_chip test

2008-02-07 Thread Jiri Slaby
On 02/07/2008 10:25 PM, Tino Keitel wrote: On Wed, Feb 06, 2008 at 10:46:39 -0500, Bob Copeland wrote: We failed to resume after a hardware reset here for a whole second. Is there any version of ath5k which worked for you (is this a regression)? I cannot speak for Tino, but my ath5k never

Re: [RFT 1/1] single_chip test

2008-02-07 Thread Tino Keitel
On Wed, Feb 06, 2008 at 10:46:39 -0500, Bob Copeland wrote: > > > We failed to resume after a hardware reset here for a whole second. Is > > > there any > > > version of ath5k which worked for you (is this a regression)? > > > > I cannot speak for Tino, but my ath5k never worked in MacBook -- it

Re: [RFT 1/1] single_chip test

2008-02-07 Thread Jiri Slaby
On 02/07/2008 10:25 PM, Tino Keitel wrote: On Wed, Feb 06, 2008 at 10:46:39 -0500, Bob Copeland wrote: We failed to resume after a hardware reset here for a whole second. Is there any version of ath5k which worked for you (is this a regression)? I cannot speak for Tino, but my ath5k never

Re: [RFT 1/1] single_chip test

2008-02-07 Thread Tino Keitel
On Wed, Feb 06, 2008 at 10:46:39 -0500, Bob Copeland wrote: We failed to resume after a hardware reset here for a whole second. Is there any version of ath5k which worked for you (is this a regression)? I cannot speak for Tino, but my ath5k never worked in MacBook -- it failed the

Re: [RFT 1/1] single_chip test

2008-02-07 Thread Tino Keitel
On Thu, Feb 07, 2008 at 22:51:04 +0100, Jiri Slaby wrote: [...] What's the srev a phy ver printed few lines above this, please? ath5k_pci :02:00.0: registered as 'phy0' SINGLE: 1, srev: a3, phy: phy0: Selected rate control algorithm 'pid' ath5k phy0: Atheros AR5424 chip found (MAC: 0xa3,

Re: [RFT 1/1] single_chip test

2008-02-06 Thread Bob Copeland
> > We failed to resume after a hardware reset here for a whole second. Is > > there any > > version of ath5k which worked for you (is this a regression)? > > I cannot speak for Tino, but my ath5k never worked in MacBook -- it > failed the same way, and I believe the hardware was the same. My >

Re: [RFT 1/1] single_chip test

2008-02-06 Thread Joseph Fannin
On Wed, Feb 06, 2008 at 11:42:40AM +0100, Jiri Slaby wrote: > On 02/05/2008 11:57 PM, Tino Keitel wrote: > > Hi, > > > > I tried the current git (9ef9dc69d4167276c04590d67ee55de8380bc1ad) and > > got the following error message from ath5k: > > > > ath5k_pci :02:00.0: registered as 'phy0' > >

Re: [RFT 1/1] single_chip test

2008-02-06 Thread Jiri Slaby
On 02/06/2008 11:48 AM, Andreas Schwab wrote: + ah->ah_single_chip = !!(srev >= AR5K_SREV_VER_AR2424 && ^^ This is useless. Amended locally, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL

Re: [RFT 1/1] single_chip test

2008-02-06 Thread Andreas Schwab
Jiri Slaby <[EMAIL PROTECTED]> writes: > @@ -210,12 +205,16 @@ struct ath5k_hw *ath5k_hw_attach(struct ath5k_softc > *sc, u8 mac_version) > } > > /* Identify single chip solutions */ > - if((srev <= AR5K_SREV_VER_AR5414) && > - (srev >= AR5K_SREV_VER_AR2424)) { > -

[RFT 1/1] single_chip test

2008-02-06 Thread Jiri Slaby
On 02/05/2008 11:57 PM, Tino Keitel wrote: > Hi, > > I tried the current git (9ef9dc69d4167276c04590d67ee55de8380bc1ad) and > got the following error message from ath5k: > > ath5k_pci :02:00.0: registered as 'phy0' > ath5k phy0: failed to resume the MAC Chip > ath5k_pci: probe of

Re: [RFT 1/1] single_chip test

2008-02-06 Thread Andreas Schwab
Jiri Slaby [EMAIL PROTECTED] writes: @@ -210,12 +205,16 @@ struct ath5k_hw *ath5k_hw_attach(struct ath5k_softc *sc, u8 mac_version) } /* Identify single chip solutions */ - if((srev = AR5K_SREV_VER_AR5414) - (srev = AR5K_SREV_VER_AR2424)) { -

Re: [RFT 1/1] single_chip test

2008-02-06 Thread Jiri Slaby
On 02/06/2008 11:48 AM, Andreas Schwab wrote: + ah-ah_single_chip = !!(srev = AR5K_SREV_VER_AR2424 ^^ This is useless. Amended locally, thanks. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL

[RFT 1/1] single_chip test

2008-02-06 Thread Jiri Slaby
On 02/05/2008 11:57 PM, Tino Keitel wrote: Hi, I tried the current git (9ef9dc69d4167276c04590d67ee55de8380bc1ad) and got the following error message from ath5k: ath5k_pci :02:00.0: registered as 'phy0' ath5k phy0: failed to resume the MAC Chip ath5k_pci: probe of :02:00.0 failed

Re: [RFT 1/1] single_chip test

2008-02-06 Thread Joseph Fannin
On Wed, Feb 06, 2008 at 11:42:40AM +0100, Jiri Slaby wrote: On 02/05/2008 11:57 PM, Tino Keitel wrote: Hi, I tried the current git (9ef9dc69d4167276c04590d67ee55de8380bc1ad) and got the following error message from ath5k: ath5k_pci :02:00.0: registered as 'phy0' ath5k phy0:

Re: [RFT 1/1] single_chip test

2008-02-06 Thread Bob Copeland
We failed to resume after a hardware reset here for a whole second. Is there any version of ath5k which worked for you (is this a regression)? I cannot speak for Tino, but my ath5k never worked in MacBook -- it failed the same way, and I believe the hardware was the same. My