Re: [RFT PATCH] regulator: s2mpa01: Use correct register for buck[36] ramp delay

2014-05-26 Thread Krzysztof Kozlowski
On pon, 2014-05-26 at 13:37 +0530, Sachin Kamat wrote: > Hi Krzysztof > > Apologies for the delay. I was on vacation during the early part of > this month and > got busy with some other stuff later and this mail fell through the cracks. > > > On 23 May 2014 19:49, Krzysztof Kozlowski wrote: >

Re: [RFT PATCH] regulator: s2mpa01: Use correct register for buck[36] ramp delay

2014-05-26 Thread Sachin Kamat
Hi Krzysztof Apologies for the delay. I was on vacation during the early part of this month and got busy with some other stuff later and this mail fell through the cracks. On 23 May 2014 19:49, Krzysztof Kozlowski wrote: > Hi Sachin, > > The s2mpa01 regulator driver uses wrong registers for

Re: [RFT PATCH] regulator: s2mpa01: Use correct register for buck[36] ramp delay

2014-05-26 Thread Sachin Kamat
Hi Krzysztof Apologies for the delay. I was on vacation during the early part of this month and got busy with some other stuff later and this mail fell through the cracks. On 23 May 2014 19:49, Krzysztof Kozlowski k.kozlow...@samsung.com wrote: Hi Sachin, The s2mpa01 regulator driver uses

Re: [RFT PATCH] regulator: s2mpa01: Use correct register for buck[36] ramp delay

2014-05-26 Thread Krzysztof Kozlowski
On pon, 2014-05-26 at 13:37 +0530, Sachin Kamat wrote: Hi Krzysztof Apologies for the delay. I was on vacation during the early part of this month and got busy with some other stuff later and this mail fell through the cracks. On 23 May 2014 19:49, Krzysztof Kozlowski

Re: [RFT PATCH] regulator: s2mpa01: Use correct register for buck[36] ramp delay

2014-05-23 Thread Krzysztof Kozlowski
Hi Sachin, The s2mpa01 regulator driver uses wrong registers for ramp delay (buck1 and buck3 in RAMP1, buck6 in RAMP2) but I am not sure which layout is proper (it seems that that buck1 should be in RAMP2 register). Could you check in S2MPA01 datasheet the registers for ramp delay for buck1,

Re: [RFT PATCH] regulator: s2mpa01: Use correct register for buck[36] ramp delay

2014-05-23 Thread Krzysztof Kozlowski
Hi Sachin, The s2mpa01 regulator driver uses wrong registers for ramp delay (buck1 and buck3 in RAMP1, buck6 in RAMP2) but I am not sure which layout is proper (it seems that that buck1 should be in RAMP2 register). Could you check in S2MPA01 datasheet the registers for ramp delay for buck1,

Re: [RFT PATCH] regulator: s2mpa01: Use correct register for buck[36] ramp delay

2014-05-07 Thread Krzysztof Kozlowski
Hi Sachin, I'm looking at SM-N7505 JB Open source code and it seems that I was wrong - the ramp delay for buck1 is set in wrong register, not buck3. I don't have the datasheet for S2MPA01 so could you confirm the registers for ramp delay of buck1, buck3 and buck6? Best regards, Krzysztof On

[RFT PATCH] regulator: s2mpa01: Use correct register for buck[36] ramp delay

2014-05-07 Thread Krzysztof Kozlowski
Buck1 and buck6 share the field (offset 4) in ramp delay register (S2MPA01_REG_RAMP1). The buck3 uses its own field in S2MPA01_REG_RAMP2 register, also at offset 4. The driver interchanged the registers for ramp delay of buck3 and buck6. This lead to updating ramp delay for wrong buck (buck3

[RFT PATCH] regulator: s2mpa01: Use correct register for buck[36] ramp delay

2014-05-07 Thread Krzysztof Kozlowski
Buck1 and buck6 share the field (offset 4) in ramp delay register (S2MPA01_REG_RAMP1). The buck3 uses its own field in S2MPA01_REG_RAMP2 register, also at offset 4. The driver interchanged the registers for ramp delay of buck3 and buck6. This lead to updating ramp delay for wrong buck (buck3

Re: [RFT PATCH] regulator: s2mpa01: Use correct register for buck[36] ramp delay

2014-05-07 Thread Krzysztof Kozlowski
Hi Sachin, I'm looking at SM-N7505 JB Open source code and it seems that I was wrong - the ramp delay for buck1 is set in wrong register, not buck3. I don't have the datasheet for S2MPA01 so could you confirm the registers for ramp delay of buck1, buck3 and buck6? Best regards, Krzysztof On