Re: [Regression?] fib_rules: Added NLM_F_EXCL support to fib_nl_newrule breaks Android userspace

From: Lorenzo Colitti Date: Wed, 3 Aug 2016 09:58:09 +0900 > The problem is that the UID routing patches were never accepted > upstream, and because FRA_xxx and RTA_xxx are enums, there's no safe > way to add a new value out of tree like there would be with other >

Re: [Regression?] fib_rules: Added NLM_F_EXCL support to fib_nl_newrule breaks Android userspace

From: Lorenzo Colitti Date: Wed, 3 Aug 2016 09:58:09 +0900 > The problem is that the UID routing patches were never accepted > upstream, and because FRA_xxx and RTA_xxx are enums, there's no safe > way to add a new value out of tree like there would be with other > identifiers such as setsockopt

Re: [Regression?] fib_rules: Added NLM_F_EXCL support to fib_nl_newrule breaks Android userspace

On Wed, Aug 3, 2016 at 3:00 AM, David Miller wrote: > > index 96161b8..ce19c5b 100644 > > --- a/include/uapi/linux/fib_rules.h > > +++ b/include/uapi/linux/fib_rules.h > > @@ -49,6 +49,8 @@ enum { > > FRA_TABLE, /* Extended table id */ > > FRA_FWMASK,

Re: [Regression?] fib_rules: Added NLM_F_EXCL support to fib_nl_newrule breaks Android userspace

On Wed, Aug 3, 2016 at 3:00 AM, David Miller wrote: > > index 96161b8..ce19c5b 100644 > > --- a/include/uapi/linux/fib_rules.h > > +++ b/include/uapi/linux/fib_rules.h > > @@ -49,6 +49,8 @@ enum { > > FRA_TABLE, /* Extended table id */ > > FRA_FWMASK, /* mask for

Re: [Regression?] fib_rules: Added NLM_F_EXCL support to fib_nl_newrule breaks Android userspace

On Tue, Aug 2, 2016 at 10:09 AM, David Ahern wrote: > On 8/2/16 11:03 AM, John Stultz wrote: >> >> So bisecting between v4.7 and linus/HEAD with the test above, it seems >> like: >> 96c63fa7393d ("net: Add l3mdev rule") is what breaks the tests. >> >> The l3mdev rule

Re: [Regression?] fib_rules: Added NLM_F_EXCL support to fib_nl_newrule breaks Android userspace

On Tue, Aug 2, 2016 at 10:09 AM, David Ahern wrote: > On 8/2/16 11:03 AM, John Stultz wrote: >> >> So bisecting between v4.7 and linus/HEAD with the test above, it seems >> like: >> 96c63fa7393d ("net: Add l3mdev rule") is what breaks the tests. >> >> The l3mdev rule patch is a bit tangled with

Re: [Regression?] fib_rules: Added NLM_F_EXCL support to fib_nl_newrule breaks Android userspace

On Tue, Aug 2, 2016 at 11:00 AM, David Miller wrote: > From: John Stultz > Date: Tue, 2 Aug 2016 10:51:26 -0700 > >> Yea, it looks like they do in their tree w/ their uid based routing: >>

Re: [Regression?] fib_rules: Added NLM_F_EXCL support to fib_nl_newrule breaks Android userspace

On Tue, Aug 2, 2016 at 11:00 AM, David Miller wrote: > From: John Stultz > Date: Tue, 2 Aug 2016 10:51:26 -0700 > >> Yea, it looks like they do in their tree w/ their uid based routing: >> https://android.googlesource.com/kernel/common.git/+/fd2cf795f3ab193752781be7372949ac1780d0ed%5E%21/ >> >>

Re: [Regression?] fib_rules: Added NLM_F_EXCL support to fib_nl_newrule breaks Android userspace

From: John Stultz Date: Tue, 2 Aug 2016 11:22:08 -0700 > Generating noise like this is the *opposite* of what I'm trying to > do. Understood.

Re: [Regression?] fib_rules: Added NLM_F_EXCL support to fib_nl_newrule breaks Android userspace

From: John Stultz Date: Tue, 2 Aug 2016 11:22:08 -0700 > Generating noise like this is the *opposite* of what I'm trying to > do. Understood.

Re: [Regression?] fib_rules: Added NLM_F_EXCL support to fib_nl_newrule breaks Android userspace

From: John Stultz Date: Tue, 2 Aug 2016 10:51:26 -0700 > Yea, it looks like they do in their tree w/ their uid based routing: > https://android.googlesource.com/kernel/common.git/+/fd2cf795f3ab193752781be7372949ac1780d0ed%5E%21/ > > index 96161b8..ce19c5b 100644 > ---

Re: [Regression?] fib_rules: Added NLM_F_EXCL support to fib_nl_newrule breaks Android userspace

From: John Stultz Date: Tue, 2 Aug 2016 10:51:26 -0700 > Yea, it looks like they do in their tree w/ their uid based routing: > https://android.googlesource.com/kernel/common.git/+/fd2cf795f3ab193752781be7372949ac1780d0ed%5E%21/ > > index 96161b8..ce19c5b 100644 > ---

Re: [Regression?] fib_rules: Added NLM_F_EXCL support to fib_nl_newrule breaks Android userspace

On 8/2/16 11:03 AM, John Stultz wrote: So bisecting between v4.7 and linus/HEAD with the test above, it seems like: 96c63fa7393d ("net: Add l3mdev rule") is what breaks the tests. The l3mdev rule patch is a bit tangled with the fib_rules one, but if I revert both of those, the only thing that

Re: [Regression?] fib_rules: Added NLM_F_EXCL support to fib_nl_newrule breaks Android userspace

On 8/2/16 11:03 AM, John Stultz wrote: So bisecting between v4.7 and linus/HEAD with the test above, it seems like: 96c63fa7393d ("net: Add l3mdev rule") is what breaks the tests. The l3mdev rule patch is a bit tangled with the fib_rules one, but if I revert both of those, the only thing that

Re: [Regression?] fib_rules: Added NLM_F_EXCL support to fib_nl_newrule breaks Android userspace

On Tue, Aug 2, 2016 at 9:37 AM, John Stultz wrote: > On Sun, Jul 31, 2016 at 6:42 PM, Lorenzo Colitti wrote: >> On Sat, Jul 30, 2016 at 1:57 AM, John Stultz wrote: >>> >>> With the patch reverted, and the system working, I

Re: [Regression?] fib_rules: Added NLM_F_EXCL support to fib_nl_newrule breaks Android userspace

On Tue, Aug 2, 2016 at 9:37 AM, John Stultz wrote: > On Sun, Jul 31, 2016 at 6:42 PM, Lorenzo Colitti wrote: >> On Sat, Jul 30, 2016 at 1:57 AM, John Stultz wrote: >>> >>> With the patch reverted, and the system working, I see: >>> >>> # ip rule ls >>> 0: from all lookup local >>> 1:

Re: [Regression?] fib_rules: Added NLM_F_EXCL support to fib_nl_newrule breaks Android userspace

On Sun, Jul 31, 2016 at 6:42 PM, Lorenzo Colitti wrote: > On Sat, Jul 30, 2016 at 1:57 AM, John Stultz wrote: >> >> With the patch reverted, and the system working, I see: >> >> # ip rule ls >> 0: from all lookup local >> 1: from all fwmark

Re: [Regression?] fib_rules: Added NLM_F_EXCL support to fib_nl_newrule breaks Android userspace

On Sun, Jul 31, 2016 at 6:42 PM, Lorenzo Colitti wrote: > On Sat, Jul 30, 2016 at 1:57 AM, John Stultz wrote: >> >> With the patch reverted, and the system working, I see: >> >> # ip rule ls >> 0: from all lookup local >> 1: from all fwmark 0xc/0xd lookup legacy_system >>

Re: [Regression?] fib_rules: Added NLM_F_EXCL support to fib_nl_newrule breaks Android userspace

On Sat, Jul 30, 2016 at 1:57 AM, John Stultz wrote: > > With the patch reverted, and the system working, I see: > > # ip rule ls > 0: from all lookup local > 1: from all fwmark 0xc/0xd lookup legacy_system > 13000: from all fwmark 0x10063/0x1 lookup

Re: [Regression?] fib_rules: Added NLM_F_EXCL support to fib_nl_newrule breaks Android userspace

On Sat, Jul 30, 2016 at 1:57 AM, John Stultz wrote: > > With the patch reverted, and the system working, I see: > > # ip rule ls > 0: from all lookup local > 1: from all fwmark 0xc/0xd lookup legacy_system > 13000: from all fwmark 0x10063/0x1 lookup local_network > 13000:

Re: [Regression?] fib_rules: Added NLM_F_EXCL support to fib_nl_newrule breaks Android userspace

On 7/29/16 10:57 AM, John Stultz wrote: I take Android userspace inserts the same rule multiple times? (ip rule ls) With the patch reverted, and the system working, I see: # ip rule ls 0: from all lookup local 1: from all fwmark 0xc/0xd lookup legacy_system 13000: from all

Re: [Regression?] fib_rules: Added NLM_F_EXCL support to fib_nl_newrule breaks Android userspace

On 7/29/16 10:57 AM, John Stultz wrote: I take Android userspace inserts the same rule multiple times? (ip rule ls) With the patch reverted, and the system working, I see: # ip rule ls 0: from all lookup local 1: from all fwmark 0xc/0xd lookup legacy_system 13000: from all

Re: [Regression?] fib_rules: Added NLM_F_EXCL support to fib_nl_newrule breaks Android userspace

On Fri, Jul 29, 2016 at 7:12 AM, David Ahern wrote: > On 7/28/16 10:20 PM, David Miller wrote: >> >> From: John Stultz >> Date: Thu, 28 Jul 2016 21:18:16 -0700 >> >>> After moving my HiKey tree to pre-v4.8-rc, I noticed when using >>> Android

Re: [Regression?] fib_rules: Added NLM_F_EXCL support to fib_nl_newrule breaks Android userspace

On Fri, Jul 29, 2016 at 7:12 AM, David Ahern wrote: > On 7/28/16 10:20 PM, David Miller wrote: >> >> From: John Stultz >> Date: Thu, 28 Jul 2016 21:18:16 -0700 >> >>> After moving my HiKey tree to pre-v4.8-rc, I noticed when using >>> Android that I was getting routing errors after toggling

Re: [Regression?] fib_rules: Added NLM_F_EXCL support to fib_nl_newrule breaks Android userspace

On 7/28/16 10:20 PM, David Miller wrote: From: John Stultz Date: Thu, 28 Jul 2016 21:18:16 -0700 After moving my HiKey tree to pre-v4.8-rc, I noticed when using Android that I was getting routing errors after toggling networking on and off (or entering suspend). Wifi

Re: [Regression?] fib_rules: Added NLM_F_EXCL support to fib_nl_newrule breaks Android userspace

On 7/28/16 10:20 PM, David Miller wrote: From: John Stultz Date: Thu, 28 Jul 2016 21:18:16 -0700 After moving my HiKey tree to pre-v4.8-rc, I noticed when using Android that I was getting routing errors after toggling networking on and off (or entering suspend). Wifi associated, but I got

Re: [Regression?] fib_rules: Added NLM_F_EXCL support to fib_nl_newrule breaks Android userspace

From: John Stultz Date: Thu, 28 Jul 2016 21:18:16 -0700 > After moving my HiKey tree to pre-v4.8-rc, I noticed when using > Android that I was getting routing errors after toggling networking on > and off (or entering suspend). Wifi associated, but I got some > rounting

Re: [Regression?] fib_rules: Added NLM_F_EXCL support to fib_nl_newrule breaks Android userspace

From: John Stultz Date: Thu, 28 Jul 2016 21:18:16 -0700 > After moving my HiKey tree to pre-v4.8-rc, I noticed when using > Android that I was getting routing errors after toggling networking on > and off (or entering suspend). Wifi associated, but I got some > rounting errors in the logcat the

[Regression?] fib_rules: Added NLM_F_EXCL support to fib_nl_newrule breaks Android userspace

After moving my HiKey tree to pre-v4.8-rc, I noticed when using Android that I was getting routing errors after toggling networking on and off (or entering suspend). Wifi associated, but I got some rounting errors in the logcat the connection manager wouldn't detect a valid network. Not being

[Regression?] fib_rules: Added NLM_F_EXCL support to fib_nl_newrule breaks Android userspace

After moving my HiKey tree to pre-v4.8-rc, I noticed when using Android that I was getting routing errors after toggling networking on and off (or entering suspend). Wifi associated, but I got some rounting errors in the logcat the connection manager wouldn't detect a valid network. Not being