Re: [Regression] "tpm: Require that all digests are present in TCG_PCR_EVENT2 structures" causes null pointer dereference

2020-10-26 Thread Tyler Hicks
On 2020-10-26 13:49:59, Kai-Heng Feng wrote: > > > > On Oct 21, 2020, at 13:48, Tyler Hicks wrote: > > > > On 2020-10-20 17:07:50, Mimi Zohar wrote: > >> On Tue, 2020-09-29 at 13:52 -0400, Mimi Zohar wrote: > >>> On Mon, 2020-09-28 at 22:16 +0800, Kai-Heng Feng wrote: > Hi Jarkko, >

Re: [Regression] "tpm: Require that all digests are present in TCG_PCR_EVENT2 structures" causes null pointer dereference

2020-10-20 Thread Tyler Hicks
On 2020-10-20 17:07:50, Mimi Zohar wrote: > On Tue, 2020-09-29 at 13:52 -0400, Mimi Zohar wrote: > > On Mon, 2020-09-28 at 22:16 +0800, Kai-Heng Feng wrote: > > > Hi Jarkko, > > > > > > > On Sep 28, 2020, at 22:06, Jarkko Sakkinen > > > > wrote: > > > > > > > > On Mon, Sep 28, 2020 at

Re: [Regression] "tpm: Require that all digests are present in TCG_PCR_EVENT2 structures" causes null pointer dereference

2020-10-20 Thread Mimi Zohar
On Tue, 2020-09-29 at 13:52 -0400, Mimi Zohar wrote: > On Mon, 2020-09-28 at 22:16 +0800, Kai-Heng Feng wrote: > > Hi Jarkko, > > > > > On Sep 28, 2020, at 22:06, Jarkko Sakkinen > > > wrote: > > > > > > On Mon, Sep 28, 2020 at 08:31:04PM +0800, Kai-Heng Feng wrote: > > >> Commit 7f3d176f5f7e

Re: [Regression] "tpm: Require that all digests are present in TCG_PCR_EVENT2 structures" causes null pointer dereference

2020-10-13 Thread Jarkko Sakkinen
On Tue, Oct 13, 2020 at 09:31:39AM -0500, Tyler Hicks wrote: > Sorry for coming in so late, I've been on an extended vacation with > little connectivity. > > On 2020-10-09 19:06:54, Jarkko Sakkinen wrote: > > On Thu, Oct 08, 2020 at 05:09:06PM +0800, Kai-Heng Feng wrote: > > > > I do not have yet

Re: [Regression] "tpm: Require that all digests are present in TCG_PCR_EVENT2 structures" causes null pointer dereference

2020-10-13 Thread Tyler Hicks
Sorry for coming in so late, I've been on an extended vacation with little connectivity. On 2020-10-09 19:06:54, Jarkko Sakkinen wrote: > On Thu, Oct 08, 2020 at 05:09:06PM +0800, Kai-Heng Feng wrote: > > > I do not have yet any reasonable answer to this and my v5.10 PR is > > > running late.

Re: [Regression] "tpm: Require that all digests are present in TCG_PCR_EVENT2 structures" causes null pointer dereference

2020-10-09 Thread Jarkko Sakkinen
On Thu, Oct 08, 2020 at 05:09:06PM +0800, Kai-Heng Feng wrote: > > I do not have yet any reasonable answer to this and my v5.10 PR is > > running late. Does everyone agree that I should revert the patch? > > Given that there are multiple users confirmed reverting the commit > helps, can you

Re: [Regression] "tpm: Require that all digests are present in TCG_PCR_EVENT2 structures" causes null pointer dereference

2020-10-08 Thread Kai-Heng Feng
> On Sep 30, 2020, at 10:20, Jarkko Sakkinen > wrote: > > On Tue, Sep 29, 2020 at 01:52:04PM -0400, Mimi Zohar wrote: >> On Mon, 2020-09-28 at 22:16 +0800, Kai-Heng Feng wrote: >>> Hi Jarkko, >>> On Sep 28, 2020, at 22:06, Jarkko Sakkinen wrote: On Mon, Sep 28, 2020 at

Re: [Regression] "tpm: Require that all digests are present in TCG_PCR_EVENT2 structures" causes null pointer dereference

2020-09-29 Thread Jarkko Sakkinen
On Tue, Sep 29, 2020 at 01:52:04PM -0400, Mimi Zohar wrote: > On Mon, 2020-09-28 at 22:16 +0800, Kai-Heng Feng wrote: > > Hi Jarkko, > > > > > On Sep 28, 2020, at 22:06, Jarkko Sakkinen > > > wrote: > > > > > > On Mon, Sep 28, 2020 at 08:31:04PM +0800, Kai-Heng Feng wrote: > > >> Commit

Re: [Regression] "tpm: Require that all digests are present in TCG_PCR_EVENT2 structures" causes null pointer dereference

2020-09-29 Thread Mimi Zohar
On Mon, 2020-09-28 at 22:16 +0800, Kai-Heng Feng wrote: > Hi Jarkko, > > > On Sep 28, 2020, at 22:06, Jarkko Sakkinen > > wrote: > > > > On Mon, Sep 28, 2020 at 08:31:04PM +0800, Kai-Heng Feng wrote: > >> Commit 7f3d176f5f7e "tpm: Require that all digests are present in > >> TCG_PCR_EVENT2

Re: [Regression] "tpm: Require that all digests are present in TCG_PCR_EVENT2 structures" causes null pointer dereference

2020-09-28 Thread Kenneth R. Crudup
On Mon, 28 Sep 2020, Jarkko Sakkinen wrote: > That's a good guess. Just a bit confused how that particular patch can > have the effect: it has two deferences to efispecid instead of one in > the same statement. Would be interesting to hear if the bug is triggered > in Kenneth's environment by

Re: [Regression] "tpm: Require that all digests are present in TCG_PCR_EVENT2 structures" causes null pointer dereference

2020-09-28 Thread Jarkko Sakkinen
On Mon, Sep 28, 2020 at 06:15:00PM +0200, Ard Biesheuvel wrote: > > > > It is possible but initially feels a bit weird: > > > > > > > > - sizeof(TCG_SPECID_SIG)) || count > > > > > efispecid->num_algs) { > > > > + sizeof(TCG_SPECID_SIG)) || > > > > +

Re: [Regression] "tpm: Require that all digests are present in TCG_PCR_EVENT2 structures" causes null pointer dereference

2020-09-28 Thread Ard Biesheuvel
On Mon, 28 Sep 2020 at 18:15, Ard Biesheuvel wrote: > > On Mon, 28 Sep 2020 at 17:52, Jarkko Sakkinen > wrote: > > > > On Mon, Sep 28, 2020 at 10:16:07PM +0800, Kai-Heng Feng wrote: > > > Hi Jarkko, > > > > > > > On Sep 28, 2020, at 22:06, Jarkko Sakkinen > > > > wrote: > > > > > > > > On Mon,

Re: [Regression] "tpm: Require that all digests are present in TCG_PCR_EVENT2 structures" causes null pointer dereference

2020-09-28 Thread Ard Biesheuvel
On Mon, 28 Sep 2020 at 17:52, Jarkko Sakkinen wrote: > > On Mon, Sep 28, 2020 at 10:16:07PM +0800, Kai-Heng Feng wrote: > > Hi Jarkko, > > > > > On Sep 28, 2020, at 22:06, Jarkko Sakkinen > > > wrote: > > > > > > On Mon, Sep 28, 2020 at 08:31:04PM +0800, Kai-Heng Feng wrote: > > >> Commit

Re: [Regression] "tpm: Require that all digests are present in TCG_PCR_EVENT2 structures" causes null pointer dereference

2020-09-28 Thread Kai-Heng Feng
Hi Jarkko, > On Sep 28, 2020, at 22:06, Jarkko Sakkinen > wrote: > > On Mon, Sep 28, 2020 at 08:31:04PM +0800, Kai-Heng Feng wrote: >> Commit 7f3d176f5f7e "tpm: Require that all digests are present in >> TCG_PCR_EVENT2 structures" causes a null pointer dereference on all >> laptops I have: >

Re: [Regression] "tpm: Require that all digests are present in TCG_PCR_EVENT2 structures" causes null pointer dereference

2020-09-28 Thread Jarkko Sakkinen
On Mon, Sep 28, 2020 at 08:31:04PM +0800, Kai-Heng Feng wrote: > Commit 7f3d176f5f7e "tpm: Require that all digests are present in > TCG_PCR_EVENT2 structures" causes a null pointer dereference on all > laptops I have: ... > [ 17.868849] BUG: kernel NULL pointer dereference, address:

[Regression] "tpm: Require that all digests are present in TCG_PCR_EVENT2 structures" causes null pointer dereference

2020-09-28 Thread Kai-Heng Feng
Commit 7f3d176f5f7e "tpm: Require that all digests are present in TCG_PCR_EVENT2 structures" causes a null pointer dereference on all laptops I have: [0.00] microcode: microcode updated early to revision 0xd6, date = 2020-04-27 [0.00] Linux version 5.8.0-rc6+ (gcc (Ubuntu