Re: [Regression] commit 8a4aeec8d(libata/ahci: accommodate tag ordered controllers)

2014-06-08 Thread Ming Lei
Hi Suman, On Sun, Jun 8, 2014 at 12:51 PM, Suman Tripathi wrote: > Hi Ming, > > I have attached the patches but it is not accepted by Tejun yet, So I will > post another version. OK, thanks. Since Tejun didn't think it is a workable approach, I am not going test the attachment, but I will

Re: [Regression] commit 8a4aeec8d(libata/ahci: accommodate tag ordered controllers)

2014-06-08 Thread Ming Lei
Hi Suman, On Sun, Jun 8, 2014 at 12:51 PM, Suman Tripathi stripa...@apm.com wrote: Hi Ming, I have attached the patches but it is not accepted by Tejun yet, So I will post another version. OK, thanks. Since Tejun didn't think it is a workable approach, I am not going test the attachment,

Re: [Regression] commit 8a4aeec8d(libata/ahci: accommodate tag ordered controllers)

2014-06-07 Thread Ming Lei
Hi Suman, Could you forward the patches to me so that I can give a test? I don't subscribe to linux-ide list. Thanks, -- Ming Lei On Sat, Jun 7, 2014 at 5:33 AM, Suman Tripathi wrote: > Hi , > > I have just posted 3 patches "ata: Fix the dma state machine lockup for APM > X-Gene SoC SATA

Re: [Regression] commit 8a4aeec8d(libata/ahci: accommodate tag ordered controllers)

2014-06-07 Thread Ming Lei
Hi Suman, Could you forward the patches to me so that I can give a test? I don't subscribe to linux-ide list. Thanks, -- Ming Lei On Sat, Jun 7, 2014 at 5:33 AM, Suman Tripathi stripa...@apm.com wrote: Hi , I have just posted 3 patches ata: Fix the dma state machine lockup for APM X-Gene

Re: [Regression] commit 8a4aeec8d(libata/ahci: accommodate tag ordered controllers)

2014-06-06 Thread Ming Lei
On Fri, Jun 6, 2014 at 10:57 AM, Dan Williams wrote: > On Fri, 2014-06-06 at 09:47 +0800, Ming Lei wrote: >> Hi Tejun, >> >> On Thu, Jun 5, 2014 at 9:41 PM, Tejun Heo wrote: >> > Hello, >> > >> > (cc'ing ahci_xgene folks) >> > >> > On Thu, Jun 05, 2014 at 09:24:04PM +0800, Ming Lei wrote: >> >>

Re: [Regression] commit 8a4aeec8d(libata/ahci: accommodate tag ordered controllers)

2014-06-06 Thread Ming Lei
On Fri, Jun 6, 2014 at 10:57 AM, Dan Williams dan.j.willi...@intel.com wrote: On Fri, 2014-06-06 at 09:47 +0800, Ming Lei wrote: Hi Tejun, On Thu, Jun 5, 2014 at 9:41 PM, Tejun Heo t...@kernel.org wrote: Hello, (cc'ing ahci_xgene folks) On Thu, Jun 05, 2014 at 09:24:04PM +0800, Ming

Re: [Regression] commit 8a4aeec8d(libata/ahci: accommodate tag ordered controllers)

2014-06-05 Thread Dan Williams
On Fri, 2014-06-06 at 09:47 +0800, Ming Lei wrote: > Hi Tejun, > > On Thu, Jun 5, 2014 at 9:41 PM, Tejun Heo wrote: > > Hello, > > > > (cc'ing ahci_xgene folks) > > > > On Thu, Jun 05, 2014 at 09:24:04PM +0800, Ming Lei wrote: > >> On Thu, Jun 5, 2014 at 9:12 PM, Dan Williams > >> wrote: > >>

Re: [Regression] commit 8a4aeec8d(libata/ahci: accommodate tag ordered controllers)

2014-06-05 Thread Ming Lei
Hi Tejun, On Thu, Jun 5, 2014 at 9:41 PM, Tejun Heo wrote: > Hello, > > (cc'ing ahci_xgene folks) > > On Thu, Jun 05, 2014 at 09:24:04PM +0800, Ming Lei wrote: >> On Thu, Jun 5, 2014 at 9:12 PM, Dan Williams >> wrote: >> > On Thu, Jun 5, 2014 at 1:53 AM, Ming Lei wrote: >> >> Hi Dan and

Re: [Regression] commit 8a4aeec8d(libata/ahci: accommodate tag ordered controllers)

2014-06-05 Thread Loc Ho
Hi Tejun, >> >> Looks the commit 8a4aeec8d(libata/ahci: accommodate tag ordered >> >> controllers) causes below sata failure[1] on APM AHCI controller. >> >> >> >> And the error does disappear after reverting the commit. >> > >> > Can you give some more details about the workload and the disk?

Re: [Regression] commit 8a4aeec8d(libata/ahci: accommodate tag ordered controllers)

2014-06-05 Thread Tejun Heo
Hello, (cc'ing ahci_xgene folks) On Thu, Jun 05, 2014 at 09:24:04PM +0800, Ming Lei wrote: > On Thu, Jun 5, 2014 at 9:12 PM, Dan Williams wrote: > > On Thu, Jun 5, 2014 at 1:53 AM, Ming Lei wrote: > >> Hi Dan and Tejun, > >> > >> Looks the commit 8a4aeec8d(libata/ahci: accommodate tag ordered

Re: [Regression] commit 8a4aeec8d(libata/ahci: accommodate tag ordered controllers)

2014-06-05 Thread Ming Lei
On Thu, Jun 5, 2014 at 9:12 PM, Dan Williams wrote: > On Thu, Jun 5, 2014 at 1:53 AM, Ming Lei wrote: >> Hi Dan and Tejun, >> >> Looks the commit 8a4aeec8d(libata/ahci: accommodate tag ordered >> controllers) causes below sata failure[1] on APM AHCI controller. >> >> And the error does disappear

Re: [Regression] commit 8a4aeec8d(libata/ahci: accommodate tag ordered controllers)

2014-06-05 Thread Dan Williams
On Thu, Jun 5, 2014 at 1:53 AM, Ming Lei wrote: > Hi Dan and Tejun, > > Looks the commit 8a4aeec8d(libata/ahci: accommodate tag ordered > controllers) causes below sata failure[1] on APM AHCI controller. > > And the error does disappear after reverting the commit. Can you give some more details

[Regression] commit 8a4aeec8d(libata/ahci: accommodate tag ordered controllers)

2014-06-05 Thread Ming Lei
Hi Dan and Tejun, Looks the commit 8a4aeec8d(libata/ahci: accommodate tag ordered controllers) causes below sata failure[1] on APM AHCI controller. And the error does disappear after reverting the commit. Thanks, -- Ming Lei [1], failure log [ 72.001579] ata4.00: exception Emask 0x40 SAct

[Regression] commit 8a4aeec8d(libata/ahci: accommodate tag ordered controllers)

2014-06-05 Thread Ming Lei
Hi Dan and Tejun, Looks the commit 8a4aeec8d(libata/ahci: accommodate tag ordered controllers) causes below sata failure[1] on APM AHCI controller. And the error does disappear after reverting the commit. Thanks, -- Ming Lei [1], failure log [ 72.001579] ata4.00: exception Emask 0x40 SAct

Re: [Regression] commit 8a4aeec8d(libata/ahci: accommodate tag ordered controllers)

2014-06-05 Thread Dan Williams
On Thu, Jun 5, 2014 at 1:53 AM, Ming Lei ming@canonical.com wrote: Hi Dan and Tejun, Looks the commit 8a4aeec8d(libata/ahci: accommodate tag ordered controllers) causes below sata failure[1] on APM AHCI controller. And the error does disappear after reverting the commit. Can you give

Re: [Regression] commit 8a4aeec8d(libata/ahci: accommodate tag ordered controllers)

2014-06-05 Thread Ming Lei
On Thu, Jun 5, 2014 at 9:12 PM, Dan Williams dan.j.willi...@intel.com wrote: On Thu, Jun 5, 2014 at 1:53 AM, Ming Lei ming@canonical.com wrote: Hi Dan and Tejun, Looks the commit 8a4aeec8d(libata/ahci: accommodate tag ordered controllers) causes below sata failure[1] on APM AHCI

Re: [Regression] commit 8a4aeec8d(libata/ahci: accommodate tag ordered controllers)

2014-06-05 Thread Tejun Heo
Hello, (cc'ing ahci_xgene folks) On Thu, Jun 05, 2014 at 09:24:04PM +0800, Ming Lei wrote: On Thu, Jun 5, 2014 at 9:12 PM, Dan Williams dan.j.willi...@intel.com wrote: On Thu, Jun 5, 2014 at 1:53 AM, Ming Lei ming@canonical.com wrote: Hi Dan and Tejun, Looks the commit

Re: [Regression] commit 8a4aeec8d(libata/ahci: accommodate tag ordered controllers)

2014-06-05 Thread Loc Ho
Hi Tejun, Looks the commit 8a4aeec8d(libata/ahci: accommodate tag ordered controllers) causes below sata failure[1] on APM AHCI controller. And the error does disappear after reverting the commit. Can you give some more details about the workload and the disk? What is the APM AHCI?

Re: [Regression] commit 8a4aeec8d(libata/ahci: accommodate tag ordered controllers)

2014-06-05 Thread Ming Lei
Hi Tejun, On Thu, Jun 5, 2014 at 9:41 PM, Tejun Heo t...@kernel.org wrote: Hello, (cc'ing ahci_xgene folks) On Thu, Jun 05, 2014 at 09:24:04PM +0800, Ming Lei wrote: On Thu, Jun 5, 2014 at 9:12 PM, Dan Williams dan.j.willi...@intel.com wrote: On Thu, Jun 5, 2014 at 1:53 AM, Ming Lei

Re: [Regression] commit 8a4aeec8d(libata/ahci: accommodate tag ordered controllers)

2014-06-05 Thread Dan Williams
On Fri, 2014-06-06 at 09:47 +0800, Ming Lei wrote: Hi Tejun, On Thu, Jun 5, 2014 at 9:41 PM, Tejun Heo t...@kernel.org wrote: Hello, (cc'ing ahci_xgene folks) On Thu, Jun 05, 2014 at 09:24:04PM +0800, Ming Lei wrote: On Thu, Jun 5, 2014 at 9:12 PM, Dan Williams