Re: [SLUB 2/2] i386 arch page size slab fixes

2007-04-02 Thread William Lee Irwin III
On Sat, Mar 31, 2007 at 11:31:07AM -0800, Christoph Lameter wrote: > Patch by William Irwin with only very minor modifications by me which are > 1. Removal of HIGHMEM64G slab caches. It seems that virtualization hosts >require a a full pgd page. The HIGHMEM64G slab allocations are

Re: [SLUB 2/2] i386 arch page size slab fixes

2007-04-02 Thread Christoph Lameter
On Mon, 2 Apr 2007, William Lee Irwin III wrote: > This doesn't quite cover all bases. The changes to pageattr.c and > fault.c are dubious and need verification at the very least. They were > largely slapped together to get the files past the compiler for the > performance comparisons that were

Re: [SLUB 2/2] i386 arch page size slab fixes

2007-04-02 Thread Christoph Lameter
On Sat, 31 Mar 2007, Andrew Morton wrote: > Can we disable SLUB on i386 in Kconfig until it gets sorted out? Found it. Another issue with relying on page size special casing in the SLAB. i386: Another case of i386 exploiting page sized slab cache special casing i386 uses kmalloc to allocate

Re: [SLUB 2/2] i386 arch page size slab fixes

2007-04-02 Thread Christoph Lameter
On Sat, 31 Mar 2007, Andrew Morton wrote: Can we disable SLUB on i386 in Kconfig until it gets sorted out? Found it. Another issue with relying on page size special casing in the SLAB. i386: Another case of i386 exploiting page sized slab cache special casing i386 uses kmalloc to allocate

Re: [SLUB 2/2] i386 arch page size slab fixes

2007-04-02 Thread William Lee Irwin III
On Sat, Mar 31, 2007 at 11:31:07AM -0800, Christoph Lameter wrote: Patch by William Irwin with only very minor modifications by me which are 1. Removal of HIGHMEM64G slab caches. It seems that virtualization hosts require a a full pgd page. The HIGHMEM64G slab allocations are meaningfully

Re: [SLUB 2/2] i386 arch page size slab fixes

2007-04-02 Thread Christoph Lameter
On Mon, 2 Apr 2007, William Lee Irwin III wrote: This doesn't quite cover all bases. The changes to pageattr.c and fault.c are dubious and need verification at the very least. They were largely slapped together to get the files past the compiler for the performance comparisons that were never

Re: [SLUB 2/2] i386 arch page size slab fixes

2007-03-31 Thread Christoph Lameter
On Sat, 31 Mar 2007, Andrew Morton wrote: > Can we disable SLUB on i386 in Kconfig until it gets sorted out? Yes just do not apply this patch. The first one disables SLUB on i386. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL

Re: [SLUB 2/2] i386 arch page size slab fixes

2007-03-31 Thread Andrew Morton
On Sat, 31 Mar 2007 11:31:07 -0800 (PST) Christoph Lameter <[EMAIL PROTECTED]> wrote: > Fixup i386 arch for SLUB support > > i386 arch code currently uses the page struct of slabs for various purposes. > This interferes with slub and so SLUB has been disabled for i386 by setting >

[SLUB 2/2] i386 arch page size slab fixes

2007-03-31 Thread Christoph Lameter
Fixup i386 arch for SLUB support i386 arch code currently uses the page struct of slabs for various purposes. This interferes with slub and so SLUB has been disabled for i386 by setting ARCH_USES_SLAB_PAGE_STRUCT. This patch removes the use of page sized slabs for maintaining pgds and pmds.

[SLUB 2/2] i386 arch page size slab fixes

2007-03-31 Thread Christoph Lameter
Fixup i386 arch for SLUB support i386 arch code currently uses the page struct of slabs for various purposes. This interferes with slub and so SLUB has been disabled for i386 by setting ARCH_USES_SLAB_PAGE_STRUCT. This patch removes the use of page sized slabs for maintaining pgds and pmds.

Re: [SLUB 2/2] i386 arch page size slab fixes

2007-03-31 Thread Andrew Morton
On Sat, 31 Mar 2007 11:31:07 -0800 (PST) Christoph Lameter [EMAIL PROTECTED] wrote: Fixup i386 arch for SLUB support i386 arch code currently uses the page struct of slabs for various purposes. This interferes with slub and so SLUB has been disabled for i386 by setting

Re: [SLUB 2/2] i386 arch page size slab fixes

2007-03-31 Thread Christoph Lameter
On Sat, 31 Mar 2007, Andrew Morton wrote: Can we disable SLUB on i386 in Kconfig until it gets sorted out? Yes just do not apply this patch. The first one disables SLUB on i386. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL