Re: [Suggestion] kernel/cgroup.c: about kfree after 'get_new_cssid'

2013-05-07 Thread Chen Gang
On 2013年05月08日 08:50, Li Zefan wrote: >>> There's a bug in cgroup_unload_subsys() that idr_destroy() should be called >>> after >>> >> ss->css_free(). That said, given there's no modular cgroup subsystem >>> >> using css_id, >>> >> and the whole css_id thing will be eliminated in 3.11, why

Re: [Suggestion] kernel/cgroup.c: about kfree after 'get_new_cssid'

2013-05-07 Thread Li Zefan
>> There's a bug in cgroup_unload_subsys() that idr_destroy() should be called >> after >> ss->css_free(). That said, given there's no modular cgroup subsystem using >> css_id, >> and the whole css_id thing will be eliminated in 3.11, why bother fixing it. >> > > I just find it by reading code

Re: [Suggestion] kernel/cgroup.c: about kfree after 'get_new_cssid'

2013-05-07 Thread Chen Gang
On 2013年05月07日 19:01, Li Zefan wrote: > On 2013/5/7 18:46, Chen Gang wrote: >> Hello Maintainers: >> >> After call get_new_cssid(), I can not find the related free function >> (it seems free_css_id() is for that, but not used). >> >> The memory location is: >> get_new_cssid() --> kzalloc() for

Re: [Suggestion] kernel/cgroup.c: about kfree after 'get_new_cssid'

2013-05-07 Thread Li Zefan
On 2013/5/7 18:46, Chen Gang wrote: > Hello Maintainers: > > After call get_new_cssid(), I can not find the related free function > (it seems free_css_id() is for that, but not used). > > The memory location is: > get_new_cssid() --> kzalloc() for 'struct css_id' > get_new_cssid() -->

[Suggestion] kernel/cgroup.c: about kfree after 'get_new_cssid'

2013-05-07 Thread Chen Gang
Hello Maintainers: After call get_new_cssid(), I can not find the related free function (it seems free_css_id() is for that, but not used). The memory location is: get_new_cssid() --> kzalloc() for 'struct css_id' get_new_cssid() --> idr_alloc() for 'ss->idr' One work flow:

[Suggestion] kernel/cgroup.c: about kfree after 'get_new_cssid'

2013-05-07 Thread Chen Gang
Hello Maintainers: After call get_new_cssid(), I can not find the related free function (it seems free_css_id() is for that, but not used). The memory location is: get_new_cssid() -- kzalloc() for 'struct css_id' get_new_cssid() -- idr_alloc() for 'ss-idr' One work flow:

Re: [Suggestion] kernel/cgroup.c: about kfree after 'get_new_cssid'

2013-05-07 Thread Li Zefan
On 2013/5/7 18:46, Chen Gang wrote: Hello Maintainers: After call get_new_cssid(), I can not find the related free function (it seems free_css_id() is for that, but not used). The memory location is: get_new_cssid() -- kzalloc() for 'struct css_id' get_new_cssid() -- idr_alloc() for

Re: [Suggestion] kernel/cgroup.c: about kfree after 'get_new_cssid'

2013-05-07 Thread Chen Gang
On 2013年05月07日 19:01, Li Zefan wrote: On 2013/5/7 18:46, Chen Gang wrote: Hello Maintainers: After call get_new_cssid(), I can not find the related free function (it seems free_css_id() is for that, but not used). The memory location is: get_new_cssid() -- kzalloc() for 'struct css_id'

Re: [Suggestion] kernel/cgroup.c: about kfree after 'get_new_cssid'

2013-05-07 Thread Li Zefan
There's a bug in cgroup_unload_subsys() that idr_destroy() should be called after ss-css_free(). That said, given there's no modular cgroup subsystem using css_id, and the whole css_id thing will be eliminated in 3.11, why bother fixing it. I just find it by reading code (I also want to

Re: [Suggestion] kernel/cgroup.c: about kfree after 'get_new_cssid'

2013-05-07 Thread Chen Gang
On 2013年05月08日 08:50, Li Zefan wrote: There's a bug in cgroup_unload_subsys() that idr_destroy() should be called after ss-css_free(). That said, given there's no modular cgroup subsystem using css_id, and the whole css_id thing will be eliminated in 3.11, why bother fixing it.