Re: [TESTING NEEDED] drivers/serial/sunzilog: Interrupt enable before ISR handler installed

2007-05-07 Thread David Miller
From: Mark Fortescue <[EMAIL PROTECTED]> Date: Sun, 29 Apr 2007 23:00:29 +0100 (BST) > I have altered the patch as advised and I have attached it to prevent my > email client from making a mess of it. > > The attached patch changes the interrupt enable sequence for the sunzilog > driver so

Re: [TESTING NEEDED] drivers/serial/sunzilog: Interrupt enable before ISR handler installed

2007-05-07 Thread Martin Habets
Mark, Gave this a spin on my SS20 today, have the console on the serial port. No problems seen. You will need to provide a signed-off-by line to get it accepted upstream, see Documentation/SubmittingPatches. ffd60050: ttyS0 at MMIO 0xf110 (irq = 44) is a zs (ESCC) Console: ttyS0 (SunZilog

Re: [TESTING NEEDED] drivers/serial/sunzilog: Interrupt enable before ISR handler installed

2007-05-07 Thread Martin Habets
Mark, Gave this a spin on my SS20 today, have the console on the serial port. No problems seen. You will need to provide a signed-off-by line to get it accepted upstream, see Documentation/SubmittingPatches. ffd60050: ttyS0 at MMIO 0xf110 (irq = 44) is a zs (ESCC) Console: ttyS0 (SunZilog

Re: [TESTING NEEDED] drivers/serial/sunzilog: Interrupt enable before ISR handler installed

2007-05-07 Thread David Miller
From: Mark Fortescue [EMAIL PROTECTED] Date: Sun, 29 Apr 2007 23:00:29 +0100 (BST) I have altered the patch as advised and I have attached it to prevent my email client from making a mess of it. The attached patch changes the interrupt enable sequence for the sunzilog driver so that

[TESTING NEEDED] drivers/serial/sunzilog: Interrupt enable before ISR handler installed

2007-05-02 Thread Mark Fortescue
Hi All, This patch changes the interrupt enable sequence for the sunzilog driver so that interrupts are not enabled untill after the interrupt handler has been installed. If this is not done, some SS1 and SS2 sun4c systems panic on un-handled interrupt before the handler gets installed

[TESTING NEEDED] drivers/serial/sunzilog: Interrupt enable before ISR handler installed

2007-05-02 Thread Mark Fortescue
Hi All, This patch changes the interrupt enable sequence for the sunzilog driver so that interrupts are not enabled untill after the interrupt handler has been installed. If this is not done, some SS1 and SS2 sun4c systems panic on un-handled interrupt before the handler gets installed

Re: [TESTING NEEDED] drivers/serial/sunzilog: Interrupt enable before ISR handler installed

2007-04-29 Thread Mark Fortescue
I have altered the patch as advised and I have attached it to prevent my email client from making a mess of it. The attached patch changes the interrupt enable sequence for the sunzilog driver so that interrupts are not enabled untill after the interrupt handler has been installed. If this is

Re: [TESTING NEEDED] drivers/serial/sunzilog: Interrupt enable before ISR handler installed

2007-04-29 Thread Mark Fortescue
I have altered the patch as advised and I have attached it to prevent my email client from making a mess of it. The attached patch changes the interrupt enable sequence for the sunzilog driver so that interrupts are not enabled untill after the interrupt handler has been installed. If this is

Re: [TESTING NEEDED] drivers/serial/sunzilog: Interrupt enable before ISR handler installed

2007-04-28 Thread David Miller
Your patch is extremely mangled, please try to email it to yourself and apply it if in doubt. Furthermore, the comment your patch adds is unnecessary. That kind of text belongs in the changelog comment, not the code. The changelog is also where you'll get credit for your change. There is no

Re: [TESTING NEEDED] drivers/serial/sunzilog: Interrupt enable before ISR handler installed

2007-04-28 Thread Jan Engelhardt
Hi, On Apr 28 2007 16:11, Mark Fortescue wrote: >Subject: [TESTING NEEDED] drivers/serial/sunzilog: Interrupt enable before ISR >handler installed I don't think I have a zilog, sorry. (You patch got the whitespaces fubared up, btw.) Regards, Jan -- - To unsubscribe from this list

Re: [TESTING NEEDED] drivers/serial/sunzilog: Interrupt enable before ISR handler installed

2007-04-28 Thread Jan Engelhardt
Hi, On Apr 28 2007 16:11, Mark Fortescue wrote: Subject: [TESTING NEEDED] drivers/serial/sunzilog: Interrupt enable before ISR handler installed I don't think I have a zilog, sorry. (You patch got the whitespaces fubared up, btw.) Regards, Jan -- - To unsubscribe from this list: send

Re: [TESTING NEEDED] drivers/serial/sunzilog: Interrupt enable before ISR handler installed

2007-04-28 Thread David Miller
Your patch is extremely mangled, please try to email it to yourself and apply it if in doubt. Furthermore, the comment your patch adds is unnecessary. That kind of text belongs in the changelog comment, not the code. The changelog is also where you'll get credit for your change. There is no