Re: [UPDATED PATCH] Support for Toshiba TMIO multifunction devices

2007-11-26 Thread Russell King - ARM Linux
On Thu, Nov 22, 2007 at 10:52:46AM +, ian wrote: > On Thu, 2007-11-22 at 00:52 +, Russell King - ARM Linux wrote: > > On Thu, Nov 22, 2007 at 12:34:09AM +, ian wrote: > > > Unfortunately, this is broken as designed (in fact this whole file is.) > > Fix attached below. Thanks. > +

Re: [UPDATED PATCH] Support for Toshiba TMIO multifunction devices

2007-11-22 Thread ian
On Thu, 2007-11-22 at 00:52 +, Russell King - ARM Linux wrote: > On Thu, Nov 22, 2007 at 12:34:09AM +, ian wrote: > Unfortunately, this is broken as designed (in fact this whole file is.) Fix attached below. > (Not looked at the rest because you really really need to get this > right fir

Re: [UPDATED PATCH] Support for Toshiba TMIO multifunction devices

2007-11-21 Thread Russell King - ARM Linux
On Thu, Nov 22, 2007 at 12:34:09AM +, ian wrote: > +void mfd_free_devices(struct platform_device *devices, int nr_devs) > +{ > + struct platform_device *dev = devices; > + int i; > + > + for (i = 0; i < nr_devs; i++) { > + struct resource *res = dev->resource; > +

[UPDATED PATCH] Support for Toshiba TMIO multifunction devices

2007-11-21 Thread ian
On Wed, 2007-11-21 at 12:05 +0800, eric miao wrote: > On Nov 21, 2007 11:54 AM, ian <[EMAIL PROTECTED]> wrote: > > On Wed, 2007-11-21 at 10:23 +0800, eric miao wrote: > > > Roughly went through the patch, looks good, here comes the remind, though > > > :-) > > > > > > 1. is it possible to use some