RE: [V3 2/2] ASoC: max98373: Added Amplifier Driver

2018-01-05 Thread Ryan Lee
supercraig0...@gmail.com; >jbru...@baylibre.com; dannenb...@ti.com; romain.per...@collabora.com; >bryce.fergu...@rockwellcollins.com; kuninori.morimoto...@renesas.com; m- >steckl...@ti.com; alsa-de...@alsa-project.org; linux-kernel@vger.kernel.org; >ryan.lee.ma...@gmail.com >Subj

RE: [V3 2/2] ASoC: max98373: Added Amplifier Driver

2018-01-05 Thread Ryan Lee
baylibre.com; dannenb...@ti.com; romain.per...@collabora.com; >bryce.fergu...@rockwellcollins.com; kuninori.morimoto...@renesas.com; m- >steckl...@ti.com; alsa-de...@alsa-project.org; linux-kernel@vger.kernel.org; >ryan.lee.ma...@gmail.com >Subject: Re: [V3 2/2] ASoC: max98373: Added A

Re: [V3 2/2] ASoC: max98373: Added Amplifier Driver

2018-01-04 Thread Mark Brown
On Wed, Jan 03, 2018 at 10:39:17AM -0800, Ryan Lee wrote: This looks mostly good. There are a few smaller issues but I think at this point it's most sensible to apply and fix those incrementally so I'll do that, please follow up with patches fixing the remaining issues. > --- /dev/null > +++

Re: [V3 2/2] ASoC: max98373: Added Amplifier Driver

2018-01-04 Thread Mark Brown
On Wed, Jan 03, 2018 at 10:39:17AM -0800, Ryan Lee wrote: This looks mostly good. There are a few smaller issues but I think at this point it's most sensible to apply and fix those incrementally so I'll do that, please follow up with patches fixing the remaining issues. > --- /dev/null > +++

[V3 2/2] ASoC: max98373: Added Amplifier Driver

2018-01-03 Thread Ryan Lee
Signed-off-by: Ryan Lee --- Changes since v2: * Splitted dt bindings to the separated patch * Changed 'interelave-mode' device property from u32 to boolean Changes since v1: * Removed 'codec' from 'max98373_priv' structure :

[V3 2/2] ASoC: max98373: Added Amplifier Driver

2018-01-03 Thread Ryan Lee
Signed-off-by: Ryan Lee --- Changes since v2: * Splitted dt bindings to the separated patch * Changed 'interelave-mode' device property from u32 to boolean Changes since v1: * Removed 'codec' from 'max98373_priv' structure : Now 'max98373_set_clock'