Re: [V3 PATCH] arm64: remove redundant FRAME_POINTER kconfig option and force to select it

2015-11-10 Thread Shi, Yang
On 11/10/2015 2:37 AM, Catalin Marinas wrote: On Mon, Nov 09, 2015 at 10:09:55AM -0800, Yang Shi wrote: FRAME_POINTER is defined in lib/Kconfig.debug, it is unnecessary to redefine it in arch/arm64/Kconfig.debug. Actually, the one defined in arm64 directory is never used. That's not true since

Re: [V3 PATCH] arm64: remove redundant FRAME_POINTER kconfig option and force to select it

2015-11-10 Thread Will Deacon
On Tue, Nov 10, 2015 at 07:43:35PM +0800, yalin wang wrote: > > On Nov 10, 2015, at 19:35, Catalin Marinas wrote: > > On Tue, Nov 10, 2015 at 07:09:00PM +0800, yalin wang wrote: > >> i have a question, > >> why FRAME_POINTER config must be enabled ? > >> and i see ARM arch can disable this confi

Re: [V3 PATCH] arm64: remove redundant FRAME_POINTER kconfig option and force to select it

2015-11-10 Thread yalin wang
> On Nov 10, 2015, at 19:35, Catalin Marinas wrote: > > On Tue, Nov 10, 2015 at 07:09:00PM +0800, yalin wang wrote: >>> On Nov 10, 2015, at 18:37, Catalin Marinas wrote: >>> >>> On Mon, Nov 09, 2015 at 10:09:55AM -0800, Yang Shi wrote: FRAME_POINTER is defined in lib/Kconfig.debug, it is

Re: [V3 PATCH] arm64: remove redundant FRAME_POINTER kconfig option and force to select it

2015-11-10 Thread Catalin Marinas
On Tue, Nov 10, 2015 at 07:09:00PM +0800, yalin wang wrote: > > On Nov 10, 2015, at 18:37, Catalin Marinas wrote: > > > > On Mon, Nov 09, 2015 at 10:09:55AM -0800, Yang Shi wrote: > >> FRAME_POINTER is defined in lib/Kconfig.debug, it is unnecessary to > >> redefine > >> it in arch/arm64/Kconfi

Re: [V3 PATCH] arm64: remove redundant FRAME_POINTER kconfig option and force to select it

2015-11-10 Thread yalin wang
> On Nov 10, 2015, at 18:37, Catalin Marinas wrote: > > On Mon, Nov 09, 2015 at 10:09:55AM -0800, Yang Shi wrote: >> FRAME_POINTER is defined in lib/Kconfig.debug, it is unnecessary to redefine >> it in arch/arm64/Kconfig.debug. Actually, the one defined in arm64 directory >> is never used. >

Re: [V3 PATCH] arm64: remove redundant FRAME_POINTER kconfig option and force to select it

2015-11-10 Thread Catalin Marinas
On Mon, Nov 09, 2015 at 10:09:55AM -0800, Yang Shi wrote: > FRAME_POINTER is defined in lib/Kconfig.debug, it is unnecessary to redefine > it in arch/arm64/Kconfig.debug. Actually, the one defined in arm64 directory > is never used. That's not true since the arm64 definition seems to take preceden

[V3 PATCH] arm64: remove redundant FRAME_POINTER kconfig option and force to select it

2015-11-09 Thread Yang Shi
FRAME_POINTER is defined in lib/Kconfig.debug, it is unnecessary to redefine it in arch/arm64/Kconfig.debug. Actually, the one defined in arm64 directory is never used. This adds a dependency on DEBUG_KERNEL for building with frame pointers. ARM64 depends on frame pointer to get correct stack back