Re: [V4 PATCH 3/6] pci: Generic function for setting up PCI device DMA coherency

2015-05-20 Thread Russell King - ARM Linux
On Wed, May 20, 2015 at 07:00:25AM -0500, Suravee Suthikulanit wrote: > On 5/20/2015 4:34 AM, Catalin Marinas wrote: > >We have a dummy of_dma_configure() already when !CONFIG_OF, otherwise > >we would need #ifndef here. I already replied, I think for other > >architectures we need this check to av

Re: [Linaro-acpi] [V4 PATCH 3/6] pci: Generic function for setting up PCI device DMA coherency

2015-05-20 Thread Arnd Bergmann
On Wednesday 20 May 2015 07:00:25 Suravee Suthikulanit wrote: > It seems that there are several places that have similar check. Would it > be good to convert this into a macro? Something like: > > #define OF_NODE_ENABLED(dev)(IS_ENABLED(CONFIG_OF) && dev->of_node) > > Thanks all for the revi

Re: [V4 PATCH 3/6] pci: Generic function for setting up PCI device DMA coherency

2015-05-20 Thread Suravee Suthikulanit
On 5/20/2015 4:34 AM, Catalin Marinas wrote: On Wed, May 20, 2015 at 11:27:54AM +0200, Arnd Bergmann wrote: On Wednesday 20 May 2015 10:24:15 Catalin Marinas wrote: On Sat, May 16, 2015 at 01:59:00AM +0200, Rafael J. Wysocki wrote: On Friday, May 15, 2015 04:23:11 PM Suravee Suthikulpanit wrot

Re: [V4 PATCH 3/6] pci: Generic function for setting up PCI device DMA coherency

2015-05-20 Thread Catalin Marinas
On Wed, May 20, 2015 at 11:27:54AM +0200, Arnd Bergmann wrote: > On Wednesday 20 May 2015 10:24:15 Catalin Marinas wrote: > > On Sat, May 16, 2015 at 01:59:00AM +0200, Rafael J. Wysocki wrote: > > > On Friday, May 15, 2015 04:23:11 PM Suravee Suthikulpanit wrote: > > > > +/** > > > > + * pci_dma_co

Re: [V4 PATCH 3/6] pci: Generic function for setting up PCI device DMA coherency

2015-05-20 Thread Catalin Marinas
On Wed, May 20, 2015 at 10:24:15AM +0100, Catalin Marinas wrote: > On Sat, May 16, 2015 at 01:59:00AM +0200, Rafael J. Wysocki wrote: > > On Friday, May 15, 2015 04:23:11 PM Suravee Suthikulpanit wrote: > > > +/** > > > + * pci_dma_configure - Setup DMA configuration > > > + * @pci_dev: ptr to pci_

Re: [V4 PATCH 3/6] pci: Generic function for setting up PCI device DMA coherency

2015-05-20 Thread Arnd Bergmann
On Wednesday 20 May 2015 10:24:15 Catalin Marinas wrote: > On Sat, May 16, 2015 at 01:59:00AM +0200, Rafael J. Wysocki wrote: > > On Friday, May 15, 2015 04:23:11 PM Suravee Suthikulpanit wrote: > > > +/** > > > + * pci_dma_configure - Setup DMA configuration > > > + * @pci_dev: ptr to pci_dev stru

Re: [V4 PATCH 3/6] pci: Generic function for setting up PCI device DMA coherency

2015-05-20 Thread Catalin Marinas
On Sat, May 16, 2015 at 01:59:00AM +0200, Rafael J. Wysocki wrote: > On Friday, May 15, 2015 04:23:11 PM Suravee Suthikulpanit wrote: > > +/** > > + * pci_dma_configure - Setup DMA configuration > > + * @pci_dev: ptr to pci_dev struct of the PCI device > > + * > > + * Function to update PCI devices

Re: [V4 PATCH 3/6] pci: Generic function for setting up PCI device DMA coherency

2015-05-16 Thread Suthikulpanit, Suravee
Hi Bjorn, On 5/16/15, 07:41, "Bjorn Helgaas" wrote: >On Fri, May 15, 2015 at 4:23 PM, Suravee Suthikulpanit > wrote: >> This patch refactors of_pci_dma_configure() into a more generic >> pci_dma_configure(), which can be reused by non-OF code. >> Then, it adds support for setting up PCI device D

Re: [V4 PATCH 3/6] pci: Generic function for setting up PCI device DMA coherency

2015-05-16 Thread Suthikulpanit, Suravee
Hi Rafael, On 5/15/15, 18:59, "Rafael J. Wysocki" wrote: >On Friday, May 15, 2015 04:23:11 PM Suravee Suthikulpanit wrote: >> This patch refactors of_pci_dma_configure() into a more generic >> pci_dma_configure(), which can be reused by non-OF code. >> Then, it adds support for setting up PCI de

Re: [V4 PATCH 3/6] pci: Generic function for setting up PCI device DMA coherency

2015-05-16 Thread Bjorn Helgaas
On Fri, May 15, 2015 at 4:23 PM, Suravee Suthikulpanit wrote: > This patch refactors of_pci_dma_configure() into a more generic > pci_dma_configure(), which can be reused by non-OF code. > Then, it adds support for setting up PCI device DMA coherency from > ACPI _CCA object that should normally be

Re: [V4 PATCH 3/6] pci: Generic function for setting up PCI device DMA coherency

2015-05-15 Thread Rafael J. Wysocki
On Friday, May 15, 2015 04:23:11 PM Suravee Suthikulpanit wrote: > This patch refactors of_pci_dma_configure() into a more generic > pci_dma_configure(), which can be reused by non-OF code. > Then, it adds support for setting up PCI device DMA coherency from > ACPI _CCA object that should normally

[V4 PATCH 3/6] pci: Generic function for setting up PCI device DMA coherency

2015-05-15 Thread Suravee Suthikulpanit
This patch refactors of_pci_dma_configure() into a more generic pci_dma_configure(), which can be reused by non-OF code. Then, it adds support for setting up PCI device DMA coherency from ACPI _CCA object that should normally be specified in the DSDT node of its PCI host bridge.. Signed-off-by: Su