Re: [WATCHDOG] v2.6.13 watchdog-patches

2005-09-07 Thread Wim Van Sebroeck
Hi Arjen, > this looks ENTIRELY like the wrong solution! To be honoust: I'm not in favour of using refcounts unnecessarily either. > Isn't it a LOT easier to just del_timer_sync() the timer from the module > exit code? Mucking with module refcounts in a driver is almost always a > sign of a bug

Re: [WATCHDOG] v2.6.13 watchdog-patches

2005-09-07 Thread Wim Van Sebroeck
Hi Arjen, this looks ENTIRELY like the wrong solution! To be honoust: I'm not in favour of using refcounts unnecessarily either. Isn't it a LOT easier to just del_timer_sync() the timer from the module exit code? Mucking with module refcounts in a driver is almost always a sign of a bug or

Re: [WATCHDOG] v2.6.13 watchdog-patches

2005-09-06 Thread Josh Boyer
On Sat, 2005-09-03 at 22:11 +0200, Arjan van de Ven wrote: > On Sat, 2005-09-03 at 22:04 +0200, Wim Van Sebroeck wrote: > > Author: Chuck Ebbert <[EMAIL PROTECTED]> > > Date: Fri Aug 19 14:14:07 2005 +0200 > > > > [WATCHDOG] softdog-timer-running-oops.patch > > > > The softdog

Re: [WATCHDOG] v2.6.13 watchdog-patches

2005-09-06 Thread Josh Boyer
On Sat, 2005-09-03 at 22:11 +0200, Arjan van de Ven wrote: On Sat, 2005-09-03 at 22:04 +0200, Wim Van Sebroeck wrote: Author: Chuck Ebbert [EMAIL PROTECTED] Date: Fri Aug 19 14:14:07 2005 +0200 [WATCHDOG] softdog-timer-running-oops.patch The softdog watchdog timer has

Re: [WATCHDOG] v2.6.13 watchdog-patches

2005-09-03 Thread Chuck Ebbert
In-Reply-To: <[EMAIL PROTECTED]> On Sat, 03 Sep 2005 at 22:11:41 +0200, Arjan van de Ven wrote: > this looks ENTIRELY like the wrong solution! > Isn't it a LOT easier to just del_timer_sync() the timer from the module > exit code? But we want to prevent module unload so the timer can fire

Re: [WATCHDOG] v2.6.13 watchdog-patches

2005-09-03 Thread Arjan van de Ven
On Sat, 2005-09-03 at 22:04 +0200, Wim Van Sebroeck wrote: > Author: Chuck Ebbert <[EMAIL PROTECTED]> > Date: Fri Aug 19 14:14:07 2005 +0200 > > [WATCHDOG] softdog-timer-running-oops.patch > > The softdog watchdog timer has a bug that can create an oops: > > 1. Load the

[WATCHDOG] v2.6.13 watchdog-patches

2005-09-03 Thread Wim Van Sebroeck
Hi Linus, please do a git pull rsync://rsync.kernel.org/pub/scm/linux/kernel/git/wim/linux-2.6-watchdog.git This will update the following files: drivers/char/watchdog/Kconfig| 43 - drivers/char/watchdog/Makefile | 71 +++-

[WATCHDOG] v2.6.13 watchdog-patches

2005-09-03 Thread Wim Van Sebroeck
Hi Linus, please do a git pull rsync://rsync.kernel.org/pub/scm/linux/kernel/git/wim/linux-2.6-watchdog.git This will update the following files: drivers/char/watchdog/Kconfig| 43 - drivers/char/watchdog/Makefile | 71 +++-

Re: [WATCHDOG] v2.6.13 watchdog-patches

2005-09-03 Thread Arjan van de Ven
On Sat, 2005-09-03 at 22:04 +0200, Wim Van Sebroeck wrote: Author: Chuck Ebbert [EMAIL PROTECTED] Date: Fri Aug 19 14:14:07 2005 +0200 [WATCHDOG] softdog-timer-running-oops.patch The softdog watchdog timer has a bug that can create an oops: 1. Load the module

Re: [WATCHDOG] v2.6.13 watchdog-patches

2005-09-03 Thread Chuck Ebbert
In-Reply-To: [EMAIL PROTECTED] On Sat, 03 Sep 2005 at 22:11:41 +0200, Arjan van de Ven wrote: this looks ENTIRELY like the wrong solution! Isn't it a LOT easier to just del_timer_sync() the timer from the module exit code? But we want to prevent module unload so the timer can fire properly.