Re: [Xen-devel] [PATCH] xen-blkback: constify instance of "struct attribute_group"

2016-07-08 Thread Konrad Rzeszutek Wilk
On Thu, Jul 07, 2016 at 09:57:10AM -0600, Jan Beulich wrote: > >>> On 07.07.16 at 17:37, wrote: > > On Thu, Jul 07, 2016 at 10:52:18AM +0100, Andrew Cooper wrote: > >> On 07/07/16 10:45, Roger Pau Monne wrote: > >> > On Thu, Jul 07, 2016 at 01:38:58AM -0600, Jan Beulich wrote: > >> >> The function

Re: [Xen-devel] [PATCH] xen-blkback: constify instance of "struct attribute_group"

2016-07-07 Thread Jan Beulich
>>> On 07.07.16 at 17:37, wrote: > On Thu, Jul 07, 2016 at 10:52:18AM +0100, Andrew Cooper wrote: >> On 07/07/16 10:45, Roger Pau Monne wrote: >> > On Thu, Jul 07, 2016 at 01:38:58AM -0600, Jan Beulich wrote: >> >> The functions such get passed to have been taking pointers to const >> >> since at

Re: [Xen-devel] [PATCH] xen-blkback: constify instance of "struct attribute_group"

2016-07-07 Thread Konrad Rzeszutek Wilk
On Thu, Jul 07, 2016 at 10:52:18AM +0100, Andrew Cooper wrote: > On 07/07/16 10:45, Roger Pau Monne wrote: > > On Thu, Jul 07, 2016 at 01:38:58AM -0600, Jan Beulich wrote: > >> The functions such get passed to have been taking pointers to const > >> since at least 2.6.16. > >> > >> Signed-off-by: J

Re: [Xen-devel] [PATCH] xen-blkback: constify instance of "struct attribute_group"

2016-07-07 Thread Andrew Cooper
On 07/07/16 10:45, Roger Pau Monne wrote: > On Thu, Jul 07, 2016 at 01:38:58AM -0600, Jan Beulich wrote: >> The functions such get passed to have been taking pointers to const >> since at least 2.6.16. >> >> Signed-off-by: Jan Beulich > Acked-by: Roger Pau Monné > > Although the wording in the co