Re: [Xen-devel] [PATCH v4 0/3] x86: modify_ldt improvement, test, and config option

On 07/30/2015 04:05 PM, Andy Lutomirski wrote: On Thu, Jul 30, 2015 at 1:01 PM, Boris Ostrovsky wrote: On 07/30/2015 02:54 PM, Andrew Cooper wrote: On 30/07/15 19:30, Andy Lutomirski wrote: On Wed, Jul 29, 2015 at 5:29 PM, Andrew Cooper wrote: On 30/07/2015 00:13, Andy Lutomirski wrote: On

Re: [Xen-devel] [PATCH v4 0/3] x86: modify_ldt improvement, test, and config option

On Thu, Jul 30, 2015 at 1:01 PM, Boris Ostrovsky wrote: > On 07/30/2015 02:54 PM, Andrew Cooper wrote: >> >> On 30/07/15 19:30, Andy Lutomirski wrote: >>> >>> On Wed, Jul 29, 2015 at 5:29 PM, Andrew Cooper >>> wrote: On 30/07/2015 00:13, Andy Lutomirski wrote: > > On Wed, Jul 29

Re: [Xen-devel] [PATCH v4 0/3] x86: modify_ldt improvement, test, and config option

On 07/30/2015 02:54 PM, Andrew Cooper wrote: On 30/07/15 19:30, Andy Lutomirski wrote: On Wed, Jul 29, 2015 at 5:29 PM, Andrew Cooper wrote: On 30/07/2015 00:13, Andy Lutomirski wrote: On Wed, Jul 29, 2015 at 4:02 PM, Andrew Cooper wrote: On 29/07/2015 23:49, Boris Ostrovsky wrote: On 07/2

Re: [Xen-devel] [PATCH v4 0/3] x86: modify_ldt improvement, test, and config option

On 30/07/15 19:30, Andy Lutomirski wrote: > On Wed, Jul 29, 2015 at 5:29 PM, Andrew Cooper > wrote: >> On 30/07/2015 00:13, Andy Lutomirski wrote: >>> On Wed, Jul 29, 2015 at 4:02 PM, Andrew Cooper >>> wrote: On 29/07/2015 23:49, Boris Ostrovsky wrote: > On 07/29/2015 06:46 PM, David Vra

Re: [Xen-devel] [PATCH v4 0/3] x86: modify_ldt improvement, test, and config option

On Wed, Jul 29, 2015 at 5:29 PM, Andrew Cooper wrote: > On 30/07/2015 00:13, Andy Lutomirski wrote: >> On Wed, Jul 29, 2015 at 4:02 PM, Andrew Cooper >> wrote: >>> On 29/07/2015 23:49, Boris Ostrovsky wrote: On 07/29/2015 06:46 PM, David Vrabel wrote: > On 29/07/2015 23:11, Andrew Cooper

Re: [Xen-devel] [PATCH v4 0/3] x86: modify_ldt improvement, test, and config option

On 30/07/2015 00:13, Andy Lutomirski wrote: > On Wed, Jul 29, 2015 at 4:02 PM, Andrew Cooper > wrote: >> On 29/07/2015 23:49, Boris Ostrovsky wrote: >>> On 07/29/2015 06:46 PM, David Vrabel wrote: On 29/07/2015 23:11, Andrew Cooper wrote: > On 29/07/2015 23:05, Andy Lutomirski wrote:

Re: [Xen-devel] [PATCH v4 0/3] x86: modify_ldt improvement, test, and config option

On Wed, Jul 29, 2015 at 4:02 PM, Andrew Cooper wrote: > On 29/07/2015 23:49, Boris Ostrovsky wrote: >> On 07/29/2015 06:46 PM, David Vrabel wrote: >>> >>> On 29/07/2015 23:11, Andrew Cooper wrote: On 29/07/2015 23:05, Andy Lutomirski wrote: > On Wed, Jul 29, 2015 at 2:37 PM, Andrew Cooper

Re: [Xen-devel] [PATCH v4 0/3] x86: modify_ldt improvement, test, and config option

On 29/07/2015 23:11, Andrew Cooper wrote: > On 29/07/2015 23:05, Andy Lutomirski wrote: >> On Wed, Jul 29, 2015 at 2:37 PM, Andrew Cooper >> wrote: >>> On 29/07/2015 22:26, Andy Lutomirski wrote: On Wed, Jul 29, 2015 at 2:23 PM, Boris Ostrovsky wrote: > On 07/29/2015 03:03 PM, And

Re: [Xen-devel] [PATCH v4 0/3] x86: modify_ldt improvement, test, and config option

On 29/07/2015 23:49, Boris Ostrovsky wrote: > On 07/29/2015 06:46 PM, David Vrabel wrote: >> >> On 29/07/2015 23:11, Andrew Cooper wrote: >>> On 29/07/2015 23:05, Andy Lutomirski wrote: On Wed, Jul 29, 2015 at 2:37 PM, Andrew Cooper wrote: > On 29/07/2015 22:26, Andy Lutomirski wrote

Re: [Xen-devel] [PATCH v4 0/3] x86: modify_ldt improvement, test, and config option

On 29/07/2015 23:49, Boris Ostrovsky wrote: > On 07/29/2015 06:46 PM, David Vrabel wrote: >> >> On 29/07/2015 23:11, Andrew Cooper wrote: >>> On 29/07/2015 23:05, Andy Lutomirski wrote: On Wed, Jul 29, 2015 at 2:37 PM, Andrew Cooper wrote: > On 29/07/2015 22:26, Andy Lutomirski wro

Re: [Xen-devel] [PATCH v4 0/3] x86: modify_ldt improvement, test, and config option

On 07/29/2015 06:46 PM, David Vrabel wrote: On 29/07/2015 23:11, Andrew Cooper wrote: On 29/07/2015 23:05, Andy Lutomirski wrote: On Wed, Jul 29, 2015 at 2:37 PM, Andrew Cooper wrote: On 29/07/2015 22:26, Andy Lutomirski wrote: On Wed, Jul 29, 2015 at 2:23 PM, Boris Ostrovsky wrote: On 07

Re: [Xen-devel] [PATCH v4 0/3] x86: modify_ldt improvement, test, and config option

On 07/29/2015 06:11 PM, Andrew Cooper wrote: On 29/07/2015 23:05, Andy Lutomirski wrote: On Wed, Jul 29, 2015 at 2:37 PM, Andrew Cooper wrote: On 29/07/2015 22:26, Andy Lutomirski wrote: On Wed, Jul 29, 2015 at 2:23 PM, Boris Ostrovsky wrote: On 07/29/2015 03:03 PM, Andrew Cooper wrote: On

Re: [Xen-devel] [PATCH v4 0/3] x86: modify_ldt improvement, test, and config option

On 29/07/2015 23:05, Andy Lutomirski wrote: > On Wed, Jul 29, 2015 at 2:37 PM, Andrew Cooper > wrote: >> On 29/07/2015 22:26, Andy Lutomirski wrote: >>> On Wed, Jul 29, 2015 at 2:23 PM, Boris Ostrovsky >>> wrote: On 07/29/2015 03:03 PM, Andrew Cooper wrote: > On 29/07/15 15:43, Boris Ost

Re: [Xen-devel] [PATCH v4 0/3] x86: modify_ldt improvement, test, and config option

On Wed, Jul 29, 2015 at 2:37 PM, Andrew Cooper wrote: > On 29/07/2015 22:26, Andy Lutomirski wrote: >> On Wed, Jul 29, 2015 at 2:23 PM, Boris Ostrovsky >> wrote: >>> On 07/29/2015 03:03 PM, Andrew Cooper wrote: On 29/07/15 15:43, Boris Ostrovsky wrote: > FYI, I have got a repro now and a

Re: [Xen-devel] [PATCH v4 0/3] x86: modify_ldt improvement, test, and config option

On 29/07/2015 22:26, Andy Lutomirski wrote: > On Wed, Jul 29, 2015 at 2:23 PM, Boris Ostrovsky > wrote: >> On 07/29/2015 03:03 PM, Andrew Cooper wrote: >>> On 29/07/15 15:43, Boris Ostrovsky wrote: FYI, I have got a repro now and am investigating. >>> Good and bad news. This bug has nothing

Re: [Xen-devel] [PATCH v4 0/3] x86: modify_ldt improvement, test, and config option

On 07/29/2015 05:26 PM, Andy Lutomirski wrote: On Wed, Jul 29, 2015 at 2:23 PM, Boris Ostrovsky wrote: On 07/29/2015 03:03 PM, Andrew Cooper wrote: On 29/07/15 15:43, Boris Ostrovsky wrote: FYI, I have got a repro now and am investigating. Good and bad news. This bug has nothing to do with

Re: [Xen-devel] [PATCH v4 0/3] x86: modify_ldt improvement, test, and config option

On Wed, Jul 29, 2015 at 2:23 PM, Boris Ostrovsky wrote: > On 07/29/2015 03:03 PM, Andrew Cooper wrote: >> >> On 29/07/15 15:43, Boris Ostrovsky wrote: >>> >>> FYI, I have got a repro now and am investigating. >> >> Good and bad news. This bug has nothing to do with LDTs themselves. >> >> I have w

Re: [Xen-devel] [PATCH v4 0/3] x86: modify_ldt improvement, test, and config option

On 07/29/2015 03:03 PM, Andrew Cooper wrote: On 29/07/15 15:43, Boris Ostrovsky wrote: FYI, I have got a repro now and am investigating. Good and bad news. This bug has nothing to do with LDTs themselves. I have worked out what is going on, but this: diff --git a/arch/x86/xen/enlighten.c b/a

Re: [Xen-devel] [PATCH v4 0/3] x86: modify_ldt improvement, test, and config option

On 29/07/15 15:43, Boris Ostrovsky wrote: > FYI, I have got a repro now and am investigating. Good and bad news. This bug has nothing to do with LDTs themselves. I have worked out what is going on, but this: diff --git a/arch/x86/xen/enlighten.c b/arch/x86/xen/enlighten.c index 5abeaac..7e1a82e

Re: [Xen-devel] [PATCH v4 0/3] x86: modify_ldt improvement, test, and config option

On 07/29/2015 10:21 AM, Andrew Cooper wrote: On 29/07/15 06:28, Andy Lutomirski wrote: On Tue, Jul 28, 2015 at 8:01 PM, Boris Ostrovsky wrote: On 07/28/2015 08:47 PM, Andrew Cooper wrote: On 29/07/2015 01:21, Andy Lutomirski wrote: On Tue, Jul 28, 2015 at 10:10 AM, Boris Ostrovsky wrote: O

Re: [Xen-devel] [PATCH v4 0/3] x86: modify_ldt improvement, test, and config option

On 29/07/15 06:28, Andy Lutomirski wrote: > On Tue, Jul 28, 2015 at 8:01 PM, Boris Ostrovsky > wrote: >> On 07/28/2015 08:47 PM, Andrew Cooper wrote: >>> On 29/07/2015 01:21, Andy Lutomirski wrote: On Tue, Jul 28, 2015 at 10:10 AM, Boris Ostrovsky wrote: > On 07/28/2015 01:07 PM, An

Re: [Xen-devel] [PATCH v4 0/3] x86: modify_ldt improvement, test, and config option

On Tue, Jul 28, 2015 at 8:01 PM, Boris Ostrovsky wrote: > On 07/28/2015 08:47 PM, Andrew Cooper wrote: >> >> On 29/07/2015 01:21, Andy Lutomirski wrote: >>> >>> On Tue, Jul 28, 2015 at 10:10 AM, Boris Ostrovsky >>> wrote: On 07/28/2015 01:07 PM, Andy Lutomirski wrote: > > On Tue

Re: [Xen-devel] [PATCH v4 0/3] x86: modify_ldt improvement, test, and config option

On Tue, Jul 28, 2015 at 8:01 PM, Boris Ostrovsky wrote: > On 07/28/2015 08:47 PM, Andrew Cooper wrote: >> >> On 29/07/2015 01:21, Andy Lutomirski wrote: >>> >>> On Tue, Jul 28, 2015 at 10:10 AM, Boris Ostrovsky >>> wrote: On 07/28/2015 01:07 PM, Andy Lutomirski wrote: > > On Tue

Re: [Xen-devel] [PATCH v4 0/3] x86: modify_ldt improvement, test, and config option

On 07/28/2015 08:47 PM, Andrew Cooper wrote: On 29/07/2015 01:21, Andy Lutomirski wrote: On Tue, Jul 28, 2015 at 10:10 AM, Boris Ostrovsky wrote: On 07/28/2015 01:07 PM, Andy Lutomirski wrote: On Tue, Jul 28, 2015 at 9:30 AM, Andrew Cooper wrote: I suspect that the set_ldt(NULL, 0) call has

Re: [Xen-devel] [PATCH v4 0/3] x86: modify_ldt improvement, test, and config option

On 29/07/2015 01:21, Andy Lutomirski wrote: > On Tue, Jul 28, 2015 at 10:10 AM, Boris Ostrovsky > wrote: >> On 07/28/2015 01:07 PM, Andy Lutomirski wrote: >>> On Tue, Jul 28, 2015 at 9:30 AM, Andrew Cooper >>> wrote: I suspect that the set_ldt(NULL, 0) call hasn't reached Xen before xen

Re: [Xen-devel] [PATCH v4 0/3] x86: modify_ldt improvement, test, and config option

On Tue, Jul 28, 2015 at 10:10 AM, Boris Ostrovsky wrote: > On 07/28/2015 01:07 PM, Andy Lutomirski wrote: >> >> On Tue, Jul 28, 2015 at 9:30 AM, Andrew Cooper >> wrote: >>> >>> I suspect that the set_ldt(NULL, 0) call hasn't reached Xen before >>> xen_free_ldt() is attempting to nab back the page

Re: [Xen-devel] [PATCH v4 0/3] x86: modify_ldt improvement, test, and config option

On 07/28/2015 01:07 PM, Andy Lutomirski wrote: On Tue, Jul 28, 2015 at 9:30 AM, Andrew Cooper wrote: I suspect that the set_ldt(NULL, 0) call hasn't reached Xen before xen_free_ldt() is attempting to nab back the pages which Xen still has mapped as an LDT. I just instrumented it with yet more

Re: [Xen-devel] [PATCH v4 0/3] x86: modify_ldt improvement, test, and config option

On 07/28/2015 11:23 AM, Andrew Cooper wrote: On 28/07/15 15:50, Boris Ostrovsky wrote: On 07/28/2015 10:35 AM, Andrew Cooper wrote: On 28/07/15 15:05, Boris Ostrovsky wrote: On 07/28/2015 06:29 AM, Andrew Cooper wrote: After forward-porting my virtio patches, I got this thing to run on Xen.