Re: [alsa-devel] [PATCH] ASoC: atmel_ssc_dai: fix spelling mistake: "Stoping" -> "Stopping"

On Wed, Apr 04, 2018 at 01:24:26PM +0300, Dan Carpenter wrote: > Trivial patches should just be trivial instead of evolving into a thread > that lasts for days. Indeed, and it's usually easier to just send a further trivial patch rather than just talk about it. > Why is "buff += 8;" indented

Re: [alsa-devel] [PATCH] ASoC: atmel_ssc_dai: fix spelling mistake: "Stoping" -> "Stopping"

On Wed, Apr 04, 2018 at 01:24:26PM +0300, Dan Carpenter wrote: > Trivial patches should just be trivial instead of evolving into a thread > that lasts for days. Indeed, and it's usually easier to just send a further trivial patch rather than just talk about it. > Why is "buff += 8;" indented

Re: [alsa-devel] [PATCH] ASoC: atmel_ssc_dai: fix spelling mistake: "Stoping" -> "Stopping"

On Wed, Apr 04, 2018 at 11:41:23AM +0100, Colin Ian King wrote: > On 04/04/18 11:24, Dan Carpenter wrote: > > On Tue, Apr 03, 2018 at 03:45:40PM +0200, Ladislav Michl wrote: > >> On Fri, Mar 30, 2018 at 04:44:20PM +0100, Colin King wrote: > >>> From: Colin Ian King > >>

Re: [alsa-devel] [PATCH] ASoC: atmel_ssc_dai: fix spelling mistake: "Stoping" -> "Stopping"

On Wed, Apr 04, 2018 at 11:41:23AM +0100, Colin Ian King wrote: > On 04/04/18 11:24, Dan Carpenter wrote: > > On Tue, Apr 03, 2018 at 03:45:40PM +0200, Ladislav Michl wrote: > >> On Fri, Mar 30, 2018 at 04:44:20PM +0100, Colin King wrote: > >>> From: Colin Ian King > >> > >> Hello Colin, > >> >

Re: [alsa-devel] [PATCH] ASoC: atmel_ssc_dai: fix spelling mistake: "Stoping" -> "Stopping"

On 04/04/18 11:24, Dan Carpenter wrote: > On Tue, Apr 03, 2018 at 03:45:40PM +0200, Ladislav Michl wrote: >> On Fri, Mar 30, 2018 at 04:44:20PM +0100, Colin King wrote: >>> From: Colin Ian King >> >> Hello Colin, >> >>> Trivial fix to spelling mistake in pr_debug message

Re: [alsa-devel] [PATCH] ASoC: atmel_ssc_dai: fix spelling mistake: "Stoping" -> "Stopping"

On 04/04/18 11:24, Dan Carpenter wrote: > On Tue, Apr 03, 2018 at 03:45:40PM +0200, Ladislav Michl wrote: >> On Fri, Mar 30, 2018 at 04:44:20PM +0100, Colin King wrote: >>> From: Colin Ian King >> >> Hello Colin, >> >>> Trivial fix to spelling mistake in pr_debug message text >> >> would you mind

Re: [alsa-devel] [PATCH] ASoC: atmel_ssc_dai: fix spelling mistake: "Stoping" -> "Stopping"

On Tue, Apr 03, 2018 at 03:45:40PM +0200, Ladislav Michl wrote: > On Fri, Mar 30, 2018 at 04:44:20PM +0100, Colin King wrote: > > From: Colin Ian King > > Hello Colin, > > > Trivial fix to spelling mistake in pr_debug message text > > would you mind making this patch

Re: [alsa-devel] [PATCH] ASoC: atmel_ssc_dai: fix spelling mistake: "Stoping" -> "Stopping"

On Tue, Apr 03, 2018 at 03:45:40PM +0200, Ladislav Michl wrote: > On Fri, Mar 30, 2018 at 04:44:20PM +0100, Colin King wrote: > > From: Colin Ian King > > Hello Colin, > > > Trivial fix to spelling mistake in pr_debug message text > > would you mind making this patch a bit less non-trivial and

Re: [alsa-devel] [PATCH] ASoC: atmel_ssc_dai: fix spelling mistake: "Stoping" -> "Stopping"

On Tue, 2018-04-03 at 20:54 +0200, Ladislav Michl wrote: > > > > No dai device. > > As all call sites are already providing error message, so what about just > removing this one completely? No idea, none of this is code I know or care about. Do what's appropriate.

Re: [alsa-devel] [PATCH] ASoC: atmel_ssc_dai: fix spelling mistake: "Stoping" -> "Stopping"

On Tue, 2018-04-03 at 20:54 +0200, Ladislav Michl wrote: > > > > No dai device. > > As all call sites are already providing error message, so what about just > removing this one completely? No idea, none of this is code I know or care about. Do what's appropriate.

Re: [alsa-devel] [PATCH] ASoC: atmel_ssc_dai: fix spelling mistake: "Stoping" -> "Stopping"

On Tue, Apr 03, 2018 at 11:17:03AM -0700, Joe Perches wrote: > On Tue, 2018-04-03 at 19:30 +0200, Ladislav Michl wrote: > > On Tue, Apr 03, 2018 at 08:49:57AM -0700, Joe Perches wrote: > > > On Tue, 2018-04-03 at 15:45 +0200, Ladislav Michl wrote: > > > > On Fri, Mar 30, 2018 at 04:44:20PM +0100,

Re: [alsa-devel] [PATCH] ASoC: atmel_ssc_dai: fix spelling mistake: "Stoping" -> "Stopping"

On Tue, Apr 03, 2018 at 11:17:03AM -0700, Joe Perches wrote: > On Tue, 2018-04-03 at 19:30 +0200, Ladislav Michl wrote: > > On Tue, Apr 03, 2018 at 08:49:57AM -0700, Joe Perches wrote: > > > On Tue, 2018-04-03 at 15:45 +0200, Ladislav Michl wrote: > > > > On Fri, Mar 30, 2018 at 04:44:20PM +0100,

Re: [alsa-devel] [PATCH] ASoC: atmel_ssc_dai: fix spelling mistake: "Stoping" -> "Stopping"

On Tue, 2018-04-03 at 19:30 +0200, Ladislav Michl wrote: > On Tue, Apr 03, 2018 at 08:49:57AM -0700, Joe Perches wrote: > > On Tue, 2018-04-03 at 15:45 +0200, Ladislav Michl wrote: > > > On Fri, Mar 30, 2018 at 04:44:20PM +0100, Colin King wrote: > > > > From: Colin Ian King

Re: [alsa-devel] [PATCH] ASoC: atmel_ssc_dai: fix spelling mistake: "Stoping" -> "Stopping"

On Tue, 2018-04-03 at 19:30 +0200, Ladislav Michl wrote: > On Tue, Apr 03, 2018 at 08:49:57AM -0700, Joe Perches wrote: > > On Tue, 2018-04-03 at 15:45 +0200, Ladislav Michl wrote: > > > On Fri, Mar 30, 2018 at 04:44:20PM +0100, Colin King wrote: > > > > From: Colin Ian King > > > > > > Hello

Re: [alsa-devel] [PATCH] ASoC: atmel_ssc_dai: fix spelling mistake: "Stoping" -> "Stopping"

On Tue, Apr 03, 2018 at 08:49:57AM -0700, Joe Perches wrote: > On Tue, 2018-04-03 at 15:45 +0200, Ladislav Michl wrote: > > On Fri, Mar 30, 2018 at 04:44:20PM +0100, Colin King wrote: > > > From: Colin Ian King > > > > Hello Colin, > > > > > Trivial fix to spelling

Re: [alsa-devel] [PATCH] ASoC: atmel_ssc_dai: fix spelling mistake: "Stoping" -> "Stopping"

On Tue, Apr 03, 2018 at 08:49:57AM -0700, Joe Perches wrote: > On Tue, 2018-04-03 at 15:45 +0200, Ladislav Michl wrote: > > On Fri, Mar 30, 2018 at 04:44:20PM +0100, Colin King wrote: > > > From: Colin Ian King > > > > Hello Colin, > > > > > Trivial fix to spelling mistake in pr_debug message

Re: [alsa-devel] [PATCH] ASoC: atmel_ssc_dai: fix spelling mistake: "Stoping" -> "Stopping"

On Tue, 2018-04-03 at 15:45 +0200, Ladislav Michl wrote: > On Fri, Mar 30, 2018 at 04:44:20PM +0100, Colin King wrote: > > From: Colin Ian King > > Hello Colin, > > > Trivial fix to spelling mistake in pr_debug message text > > would you mind making this patch a bit

Re: [alsa-devel] [PATCH] ASoC: atmel_ssc_dai: fix spelling mistake: "Stoping" -> "Stopping"

On Tue, 2018-04-03 at 15:45 +0200, Ladislav Michl wrote: > On Fri, Mar 30, 2018 at 04:44:20PM +0100, Colin King wrote: > > From: Colin Ian King > > Hello Colin, > > > Trivial fix to spelling mistake in pr_debug message text > > would you mind making this patch a bit less non-trivial and >

Re: [alsa-devel] [PATCH] ASoC: atmel_ssc_dai: fix spelling mistake: "Stoping" -> "Stopping"

On Fri, Mar 30, 2018 at 04:44:20PM +0100, Colin King wrote: > From: Colin Ian King Hello Colin, > Trivial fix to spelling mistake in pr_debug message text would you mind making this patch a bit less non-trivial and change pr_debug to dev_dbg dropping Atmel_ssc_dai

Re: [alsa-devel] [PATCH] ASoC: atmel_ssc_dai: fix spelling mistake: "Stoping" -> "Stopping"

On Fri, Mar 30, 2018 at 04:44:20PM +0100, Colin King wrote: > From: Colin Ian King Hello Colin, > Trivial fix to spelling mistake in pr_debug message text would you mind making this patch a bit less non-trivial and change pr_debug to dev_dbg dropping Atmel_ssc_dai prefix? Thank you. >