Re: [alsa-devel] [PATCH] ASoC: fsl: fix fsl_spdif.c build errors

2016-11-08 Thread Kees Cook
On Sun, Nov 6, 2016 at 1:40 PM, Randy Dunlap wrote: > On 11/06/16 11:43, Fabio Estevam wrote: >> Hi Randy, >> >> On Sat, Nov 5, 2016 at 9:16 PM, Randy Dunlap wrote: >>> From: Randy Dunlap >>> >>> Fix build errors in sound/soc/fsl/fsl_spdif.c by selecting BITREVERSE. >>> Fixes these build errors:

Re: [alsa-devel] [PATCH] ASoC: fsl: fix fsl_spdif.c build errors

2016-11-06 Thread Randy Dunlap
On 11/06/16 11:43, Fabio Estevam wrote: > Hi Randy, > > On Sat, Nov 5, 2016 at 9:16 PM, Randy Dunlap wrote: >> From: Randy Dunlap >> >> Fix build errors in sound/soc/fsl/fsl_spdif.c by selecting BITREVERSE. >> Fixes these build errors: > > Care to explain why the error is happening? The driver

Re: [alsa-devel] [PATCH] ASoC: fsl: fix fsl_spdif.c build errors

2016-11-06 Thread Fabio Estevam
Hi Randy, On Sun, Nov 6, 2016 at 7:40 PM, Randy Dunlap wrote: > The driver uses bitreverse functions but does not select BITREVERSE > in its kconfig description, so the bitrev functions are not built > into the kernel. In the kbuild robot supplied config file, > FSL_SPDIF=y and BITREVERSE=m, wh

Re: [alsa-devel] [PATCH] ASoC: fsl: fix fsl_spdif.c build errors

2016-11-06 Thread Fabio Estevam
Hi Randy, On Sat, Nov 5, 2016 at 9:16 PM, Randy Dunlap wrote: > From: Randy Dunlap > > Fix build errors in sound/soc/fsl/fsl_spdif.c by selecting BITREVERSE. > Fixes these build errors: Care to explain why the error is happening? > sound/built-in.o: In function `spdif_write_channel_status': >