Re: [alsa-devel] [PATCH] ASoC: sgtl5000: only check VDDD-supply, not revision

2016-06-06 Thread Fabio Estevam
On Mon, Jun 6, 2016 at 1:45 PM, Clemens Gruber wrote: > Yes, I think so too. However I am unsure if we should also remove > SGTL5000_CHIP_LINREG_CTRL from the defaults as in Eric's patch 3/6 or > only keep the parts of the patch dealing with SGTL5000_CHIP_ANA_POWER.

Re: [alsa-devel] [PATCH] ASoC: sgtl5000: only check VDDD-supply, not revision

2016-06-06 Thread Fabio Estevam
On Mon, Jun 6, 2016 at 1:45 PM, Clemens Gruber wrote: > Yes, I think so too. However I am unsure if we should also remove > SGTL5000_CHIP_LINREG_CTRL from the defaults as in Eric's patch 3/6 or > only keep the parts of the patch dealing with SGTL5000_CHIP_ANA_POWER. > What do you think? I think

Re: [alsa-devel] [PATCH] ASoC: sgtl5000: only check VDDD-supply, not revision

2016-06-06 Thread Clemens Gruber
Hi Fabio, On Sun, Jun 05, 2016 at 10:22:55PM -0300, Fabio Estevam wrote: > Hi Clemens, > > On Sun, Jun 5, 2016 at 8:16 PM, Clemens Gruber > wrote: > > > I looked into this today and discovered the following: > > > > With my patch applied, if I reset the board just

Re: [alsa-devel] [PATCH] ASoC: sgtl5000: only check VDDD-supply, not revision

2016-06-06 Thread Clemens Gruber
Hi Fabio, On Sun, Jun 05, 2016 at 10:22:55PM -0300, Fabio Estevam wrote: > Hi Clemens, > > On Sun, Jun 5, 2016 at 8:16 PM, Clemens Gruber > wrote: > > > I looked into this today and discovered the following: > > > > With my patch applied, if I reset the board just after playback, at the > >

Re: [alsa-devel] [PATCH] ASoC: sgtl5000: only check VDDD-supply, not revision

2016-06-05 Thread Fabio Estevam
Hi Clemens, On Sun, Jun 5, 2016 at 8:16 PM, Clemens Gruber wrote: > I looked into this today and discovered the following: > > With my patch applied, if I reset the board just after playback, at the > next boot, the sgtl5000_fill_defaults function does not succeed:

Re: [alsa-devel] [PATCH] ASoC: sgtl5000: only check VDDD-supply, not revision

2016-06-05 Thread Fabio Estevam
Hi Clemens, On Sun, Jun 5, 2016 at 8:16 PM, Clemens Gruber wrote: > I looked into this today and discovered the following: > > With my patch applied, if I reset the board just after playback, at the > next boot, the sgtl5000_fill_defaults function does not succeed: Writing > the default value

Re: [alsa-devel] [PATCH] ASoC: sgtl5000: only check VDDD-supply, not revision

2016-06-05 Thread Clemens Gruber
Hi Eric, Fabio, Mark, On Sat, Jun 04, 2016 at 07:15:25PM +0200, Clemens Gruber wrote: > please don't merge the patch yet, I just observed a strange effect when > resetting the board during playback / just after playback stops. > At next boot time, sometimes the following error occurs: >

Re: [alsa-devel] [PATCH] ASoC: sgtl5000: only check VDDD-supply, not revision

2016-06-05 Thread Clemens Gruber
Hi Eric, Fabio, Mark, On Sat, Jun 04, 2016 at 07:15:25PM +0200, Clemens Gruber wrote: > please don't merge the patch yet, I just observed a strange effect when > resetting the board during playback / just after playback stops. > At next boot time, sometimes the following error occurs: >