Re: [alsa-devel] [PATCH v1 1/4] ASoC: codec: Inno codec driver for RK3036 SoC

2015-10-19 Thread Mark Brown
On Mon, Oct 19, 2015 at 08:56:51AM +0200, Ricard Wanderlof wrote: > On Tue, 13 Oct 2015, Shunqian Zheng wrote: > > +static const struct of_device_id rk3036_codec_of_match[] = { > > + { .compatible = "rk3036-codec", }, > > + {} > > +}; > > +MODULE_DEVICE_TABLE(of,

Re: [alsa-devel] [PATCH v1 1/4] ASoC: codec: Inno codec driver for RK3036 SoC

2015-10-19 Thread Ricard Wanderlof
On Tue, 13 Oct 2015, Shunqian Zheng wrote: > +static const struct of_device_id rk3036_codec_of_match[] = { > + { .compatible = "rk3036-codec", }, > + {} > +}; > +MODULE_DEVICE_TABLE(of, rk3036_codec_of_match); Isn't a compatible string normally in the form "rockchip,rk3036-codec" ?

Re: [alsa-devel] [PATCH v1 1/4] ASoC: codec: Inno codec driver for RK3036 SoC

2015-10-19 Thread Ricard Wanderlof
On Tue, 13 Oct 2015, Shunqian Zheng wrote: > +static const struct of_device_id rk3036_codec_of_match[] = { > + { .compatible = "rk3036-codec", }, > + {} > +}; > +MODULE_DEVICE_TABLE(of, rk3036_codec_of_match); Isn't a compatible string normally in the form "rockchip,rk3036-codec" ?

Re: [alsa-devel] [PATCH v1 1/4] ASoC: codec: Inno codec driver for RK3036 SoC

2015-10-19 Thread Mark Brown
On Mon, Oct 19, 2015 at 08:56:51AM +0200, Ricard Wanderlof wrote: > On Tue, 13 Oct 2015, Shunqian Zheng wrote: > > +static const struct of_device_id rk3036_codec_of_match[] = { > > + { .compatible = "rk3036-codec", }, > > + {} > > +}; > > +MODULE_DEVICE_TABLE(of,