Re: [alsa-devel] [PATCH v2 09/11] ASoC: Intel: hdac_hdmi: Set ops to NULL on remove

2019-06-24 Thread Amadeusz Sławiński
On Thu, 20 Jun 2019 08:17:33 +0200 Pierre-Louis Bossart wrote: > > Could you please give a bit more context on what error you see > > when this happens? > > Hi, > > I get Oops. This is what happens with all other patches in this > series and only this one revert

Re: [alsa-devel] [PATCH v2 09/11] ASoC: Intel: hdac_hdmi: Set ops to NULL on remove

2019-06-19 Thread Pierre-Louis Bossart
Could you please give a bit more context on what error you see when this happens? Hi, I get Oops. This is what happens with all other patches in this series and only this one reverted: root@APL:~# rmmod snd_soc_sst_bxt_rt298 root@APL:~# rmmod snd_soc_hdac_hdmi root@APL:~# rmmod snd_soc_skl

Re: [alsa-devel] [PATCH v2 09/11] ASoC: Intel: hdac_hdmi: Set ops to NULL on remove

2019-06-19 Thread Ranjani Sridharan
On Wed, 2019-06-19 at 10:38 +0200, Amadeusz Sławiński wrote: > On Tue, 18 Jun 2019 08:58:22 -0700 > Ranjani Sridharan wrote: > > > On Tue, 2019-06-18 at 13:00 +0200, Amadeusz Sławiński wrote: > > > On Mon, 17 Jun 2019 13:51:42 -0700 > > > Ranjani Sridharan wrote: > > > > > > > On Mon, 2019-06

Re: [alsa-devel] [PATCH v2 09/11] ASoC: Intel: hdac_hdmi: Set ops to NULL on remove

2019-06-19 Thread Amadeusz Sławiński
On Tue, 18 Jun 2019 08:58:22 -0700 Ranjani Sridharan wrote: > On Tue, 2019-06-18 at 13:00 +0200, Amadeusz Sławiński wrote: > > On Mon, 17 Jun 2019 13:51:42 -0700 > > Ranjani Sridharan wrote: > > > > > On Mon, 2019-06-17 at 13:36 +0200, Amadeusz Sławiński wrote: > > > > When we unload Skylak

Re: [alsa-devel] [PATCH v2 09/11] ASoC: Intel: hdac_hdmi: Set ops to NULL on remove

2019-06-18 Thread Ranjani Sridharan
On Tue, 2019-06-18 at 13:00 +0200, Amadeusz Sławiński wrote: > On Mon, 17 Jun 2019 13:51:42 -0700 > Ranjani Sridharan wrote: > > > On Mon, 2019-06-17 at 13:36 +0200, Amadeusz Sławiński wrote: > > > When we unload Skylake driver we may end up calling > > > hdac_component_master_unbind(), it uses a

Re: [alsa-devel] [PATCH v2 09/11] ASoC: Intel: hdac_hdmi: Set ops to NULL on remove

2019-06-18 Thread Amadeusz Sławiński
On Mon, 17 Jun 2019 13:51:42 -0700 Ranjani Sridharan wrote: > On Mon, 2019-06-17 at 13:36 +0200, Amadeusz Sławiński wrote: > > When we unload Skylake driver we may end up calling > > hdac_component_master_unbind(), it uses acomp->audio_ops, which we > > set > > in hdmi_codec_probe(), so we need t

Re: [alsa-devel] [PATCH v2 09/11] ASoC: Intel: hdac_hdmi: Set ops to NULL on remove

2019-06-18 Thread Takashi Iwai
On Tue, 18 Jun 2019 06:19:15 +0200, Ranjani Sridharan wrote: > > On Mon, 2019-06-17 at 23:36 +0200, Takashi Iwai wrote: > > On Mon, 17 Jun 2019 22:51:42 +0200, > > Ranjani Sridharan wrote: > > > > > > On Mon, 2019-06-17 at 13:36 +0200, Amadeusz Sławiński wrote: > > > > When we unload Skylake driv

Re: [alsa-devel] [PATCH v2 09/11] ASoC: Intel: hdac_hdmi: Set ops to NULL on remove

2019-06-17 Thread Ranjani Sridharan
On Mon, 2019-06-17 at 23:36 +0200, Takashi Iwai wrote: > On Mon, 17 Jun 2019 22:51:42 +0200, > Ranjani Sridharan wrote: > > > > On Mon, 2019-06-17 at 13:36 +0200, Amadeusz Sławiński wrote: > > > When we unload Skylake driver we may end up calling > > > hdac_component_master_unbind(), it uses acomp

Re: [alsa-devel] [PATCH v2 09/11] ASoC: Intel: hdac_hdmi: Set ops to NULL on remove

2019-06-17 Thread Takashi Iwai
On Mon, 17 Jun 2019 22:51:42 +0200, Ranjani Sridharan wrote: > > On Mon, 2019-06-17 at 13:36 +0200, Amadeusz Sławiński wrote: > > When we unload Skylake driver we may end up calling > > hdac_component_master_unbind(), it uses acomp->audio_ops, which we > > set > > in hdmi_codec_probe(), so we need

Re: [alsa-devel] [PATCH v2 09/11] ASoC: Intel: hdac_hdmi: Set ops to NULL on remove

2019-06-17 Thread Ranjani Sridharan
On Mon, 2019-06-17 at 13:36 +0200, Amadeusz Sławiński wrote: > When we unload Skylake driver we may end up calling > hdac_component_master_unbind(), it uses acomp->audio_ops, which we > set > in hdmi_codec_probe(), so we need to set it to NULL in > hdmi_codec_remove(), > otherwise we will dereferen