Re: [alsa-devel] [PATCH v3 2/2] ASoC: imx-wm8962: Fix codec_clk cleanup

2017-03-29 Thread Mark Brown
On Wed, Mar 29, 2017 at 02:38:23PM +0300, Daniel Baluta wrote: > If I read the code correctly, both machine and codec driver are doing: > * codec_clk = clk_get(...) > I guess that the codec driver is the first to be loaded and it will call: > * __clk_create_clk > which will do the allocation.

Re: [alsa-devel] [PATCH v3 2/2] ASoC: imx-wm8962: Fix codec_clk cleanup

2017-03-29 Thread Mark Brown
On Wed, Mar 29, 2017 at 02:38:23PM +0300, Daniel Baluta wrote: > If I read the code correctly, both machine and codec driver are doing: > * codec_clk = clk_get(...) > I guess that the codec driver is the first to be loaded and it will call: > * __clk_create_clk > which will do the allocation.

Re: [alsa-devel] [PATCH v3 2/2] ASoC: imx-wm8962: Fix codec_clk cleanup

2017-03-29 Thread Daniel Baluta
On Tue, Mar 28, 2017 at 6:24 PM, Mark Brown wrote: > On Tue, Mar 28, 2017 at 12:53:06PM +0100, Charles Keepax wrote: >> On Tue, Mar 28, 2017 at 01:47:04PM +0300, Daniel Baluta wrote: > >> > >> - codec_clk = devm_clk_get(_dev->dev, NULL); >> > >> + codec_clk =

Re: [alsa-devel] [PATCH v3 2/2] ASoC: imx-wm8962: Fix codec_clk cleanup

2017-03-29 Thread Daniel Baluta
On Tue, Mar 28, 2017 at 6:24 PM, Mark Brown wrote: > On Tue, Mar 28, 2017 at 12:53:06PM +0100, Charles Keepax wrote: >> On Tue, Mar 28, 2017 at 01:47:04PM +0300, Daniel Baluta wrote: > >> > >> - codec_clk = devm_clk_get(_dev->dev, NULL); >> > >> + codec_clk = clk_get(_dev->dev, NULL); >

Re: [alsa-devel] [PATCH v3 2/2] ASoC: imx-wm8962: Fix codec_clk cleanup

2017-03-28 Thread Charles Keepax
On Tue, Mar 28, 2017 at 04:24:57PM +0100, Mark Brown wrote: > On Tue, Mar 28, 2017 at 12:53:06PM +0100, Charles Keepax wrote: > > On Tue, Mar 28, 2017 at 01:47:04PM +0300, Daniel Baluta wrote: > > > > >> - codec_clk = devm_clk_get(_dev->dev, NULL); > > > >> + codec_clk =

Re: [alsa-devel] [PATCH v3 2/2] ASoC: imx-wm8962: Fix codec_clk cleanup

2017-03-28 Thread Charles Keepax
On Tue, Mar 28, 2017 at 04:24:57PM +0100, Mark Brown wrote: > On Tue, Mar 28, 2017 at 12:53:06PM +0100, Charles Keepax wrote: > > On Tue, Mar 28, 2017 at 01:47:04PM +0300, Daniel Baluta wrote: > > > > >> - codec_clk = devm_clk_get(_dev->dev, NULL); > > > >> + codec_clk =

Re: [alsa-devel] [PATCH v3 2/2] ASoC: imx-wm8962: Fix codec_clk cleanup

2017-03-28 Thread Mark Brown
On Tue, Mar 28, 2017 at 12:53:06PM +0100, Charles Keepax wrote: > On Tue, Mar 28, 2017 at 01:47:04PM +0300, Daniel Baluta wrote: > > >> - codec_clk = devm_clk_get(_dev->dev, NULL); > > >> + codec_clk = clk_get(_dev->dev, NULL); > > is different from _dev->dev. > I get that they are

Re: [alsa-devel] [PATCH v3 2/2] ASoC: imx-wm8962: Fix codec_clk cleanup

2017-03-28 Thread Mark Brown
On Tue, Mar 28, 2017 at 12:53:06PM +0100, Charles Keepax wrote: > On Tue, Mar 28, 2017 at 01:47:04PM +0300, Daniel Baluta wrote: > > >> - codec_clk = devm_clk_get(_dev->dev, NULL); > > >> + codec_clk = clk_get(_dev->dev, NULL); > > is different from _dev->dev. > I get that they are

Re: [alsa-devel] [PATCH v3 2/2] ASoC: imx-wm8962: Fix codec_clk cleanup

2017-03-28 Thread Charles Keepax
On Tue, Mar 28, 2017 at 01:47:04PM +0300, Daniel Baluta wrote: > On Tue, Mar 28, 2017 at 12:21 PM, Charles Keepax > wrote: > > On Tue, Mar 28, 2017 at 11:58:52AM +0300, Daniel Baluta wrote: > >> Resource managed devm_clk_get only works with platform's device

Re: [alsa-devel] [PATCH v3 2/2] ASoC: imx-wm8962: Fix codec_clk cleanup

2017-03-28 Thread Charles Keepax
On Tue, Mar 28, 2017 at 01:47:04PM +0300, Daniel Baluta wrote: > On Tue, Mar 28, 2017 at 12:21 PM, Charles Keepax > wrote: > > On Tue, Mar 28, 2017 at 11:58:52AM +0300, Daniel Baluta wrote: > >> Resource managed devm_clk_get only works with platform's device dev. > >> > > > > I feel like this

Re: [alsa-devel] [PATCH v3 2/2] ASoC: imx-wm8962: Fix codec_clk cleanup

2017-03-28 Thread Daniel Baluta
On Tue, Mar 28, 2017 at 12:21 PM, Charles Keepax wrote: > On Tue, Mar 28, 2017 at 11:58:52AM +0300, Daniel Baluta wrote: >> Resource managed devm_clk_get only works with platform's device dev. >> > > I feel like this could use an explaination of why not using

Re: [alsa-devel] [PATCH v3 2/2] ASoC: imx-wm8962: Fix codec_clk cleanup

2017-03-28 Thread Daniel Baluta
On Tue, Mar 28, 2017 at 12:21 PM, Charles Keepax wrote: > On Tue, Mar 28, 2017 at 11:58:52AM +0300, Daniel Baluta wrote: >> Resource managed devm_clk_get only works with platform's device dev. >> > > I feel like this could use an explaination of why not using devm > is the correct fix, rather

Re: [alsa-devel] [PATCH v3 2/2] ASoC: imx-wm8962: Fix codec_clk cleanup

2017-03-28 Thread Charles Keepax
On Tue, Mar 28, 2017 at 11:58:52AM +0300, Daniel Baluta wrote: > Resource managed devm_clk_get only works with platform's device dev. > I feel like this could use an explaination of why not using devm is the correct fix, rather than just using the platform device for the call. Its not obvious to

Re: [alsa-devel] [PATCH v3 2/2] ASoC: imx-wm8962: Fix codec_clk cleanup

2017-03-28 Thread Charles Keepax
On Tue, Mar 28, 2017 at 11:58:52AM +0300, Daniel Baluta wrote: > Resource managed devm_clk_get only works with platform's device dev. > I feel like this could use an explaination of why not using devm is the correct fix, rather than just using the platform device for the call. Its not obvious to