Re: [alsa-devel] [PATCH v5 6/9] ASoC: mediatek: add mt2701 platform driver implementation.

2016-07-03 Thread Garlic Tseng
On Thu, 2016-06-30 at 21:39 +0800, Garlic Tseng wrote: > On Wed, 2016-06-29 at 20:13 +0100, Mark Brown wrote: > > On Fri, Jun 17, 2016 at 03:43:57PM +0800, Garlic Tseng wrote: > > > > > +static int mt2701_afe_i2s_set_clkdiv(struct snd_soc_dai *dai, int div_id, > > > +

Re: [alsa-devel] [PATCH v5 6/9] ASoC: mediatek: add mt2701 platform driver implementation.

2016-07-03 Thread Garlic Tseng
On Thu, 2016-06-30 at 21:39 +0800, Garlic Tseng wrote: > On Wed, 2016-06-29 at 20:13 +0100, Mark Brown wrote: > > On Fri, Jun 17, 2016 at 03:43:57PM +0800, Garlic Tseng wrote: > > > > > +static int mt2701_afe_i2s_set_clkdiv(struct snd_soc_dai *dai, int div_id, > > > +

Re: [alsa-devel] [PATCH v5 6/9] ASoC: mediatek: add mt2701 platform driver implementation.

2016-06-30 Thread Garlic Tseng
On Wed, 2016-06-29 at 20:13 +0100, Mark Brown wrote: > On Fri, Jun 17, 2016 at 03:43:57PM +0800, Garlic Tseng wrote: > > > +static int mt2701_afe_i2s_set_clkdiv(struct snd_soc_dai *dai, int div_id, > > +int div) > > +{ > > Why are we adding a set_clkdiv()

Re: [alsa-devel] [PATCH v5 6/9] ASoC: mediatek: add mt2701 platform driver implementation.

2016-06-30 Thread Garlic Tseng
On Wed, 2016-06-29 at 20:13 +0100, Mark Brown wrote: > On Fri, Jun 17, 2016 at 03:43:57PM +0800, Garlic Tseng wrote: > > > +static int mt2701_afe_i2s_set_clkdiv(struct snd_soc_dai *dai, int div_id, > > +int div) > > +{ > > Why are we adding a set_clkdiv()

Re: [alsa-devel] [PATCH v5 6/9] ASoC: mediatek: add mt2701 platform driver implementation.

2016-06-30 Thread Mark Brown
On Fri, Jun 17, 2016 at 03:43:57PM +0800, Garlic Tseng wrote: > +static int mt2701_afe_i2s_set_clkdiv(struct snd_soc_dai *dai, int div_id, > + int div) > +{ Why are we adding a set_clkdiv() operation? I would expect the driver to be able to figure things out

Re: [alsa-devel] [PATCH v5 6/9] ASoC: mediatek: add mt2701 platform driver implementation.

2016-06-30 Thread Mark Brown
On Fri, Jun 17, 2016 at 03:43:57PM +0800, Garlic Tseng wrote: > +static int mt2701_afe_i2s_set_clkdiv(struct snd_soc_dai *dai, int div_id, > + int div) > +{ Why are we adding a set_clkdiv() operation? I would expect the driver to be able to figure things out

[alsa-devel] [PATCH v5 6/9] ASoC: mediatek: add mt2701 platform driver implementation.

2016-06-17 Thread Garlic Tseng
Add mt2701 platform driver implementation for playback and capture. The implement follow DAPM structure (memory interface as FE and I2S as BE). Because of the hardware design, i2s out required to be enabled when we need to enable i2s in. This patch includes the implementation. Signed-off-by:

[alsa-devel] [PATCH v5 6/9] ASoC: mediatek: add mt2701 platform driver implementation.

2016-06-17 Thread Garlic Tseng
Add mt2701 platform driver implementation for playback and capture. The implement follow DAPM structure (memory interface as FE and I2S as BE). Because of the hardware design, i2s out required to be enabled when we need to enable i2s in. This patch includes the implementation. Signed-off-by: