Re: [alsa-devel] [PATCH v5 7/9] ASoC: bt-sco: extend rate and add a general compatible string

On Sat, 2016-07-02 at 17:05 +0800, Chen-Yu Tsai wrote: Hi, > Could we also make this driver directly configurable from Kconfig, > and not just selected by platforms (currently Samsung) or by building > all coddecs? > > Thanks > ChenYu I'll add configure prompt for SND_SOC_BT_SCO in next

Re: [alsa-devel] [PATCH v5 7/9] ASoC: bt-sco: extend rate and add a general compatible string

On Sat, 2016-07-02 at 17:05 +0800, Chen-Yu Tsai wrote: Hi, > Could we also make this driver directly configurable from Kconfig, > and not just selected by platforms (currently Samsung) or by building > all coddecs? > > Thanks > ChenYu I'll add configure prompt for SND_SOC_BT_SCO in next

Re: [alsa-devel] [PATCH v5 7/9] ASoC: bt-sco: extend rate and add a general compatible string

Hi, On Sat, Jul 2, 2016 at 12:11 AM, Mark Brown wrote: > On Fri, Jul 01, 2016 at 10:49:46AM +0800, Garlic Tseng wrote: >> On Thu, 2016-06-30 at 20:55 +0800, Garlic Tseng wrote: > >> > If you worry about some potential risk (I don't see any) maybe we have >> > to develop

Re: [alsa-devel] [PATCH v5 7/9] ASoC: bt-sco: extend rate and add a general compatible string

Hi, On Sat, Jul 2, 2016 at 12:11 AM, Mark Brown wrote: > On Fri, Jul 01, 2016 at 10:49:46AM +0800, Garlic Tseng wrote: >> On Thu, 2016-06-30 at 20:55 +0800, Garlic Tseng wrote: > >> > If you worry about some potential risk (I don't see any) maybe we have >> > to develop another dummy bt-sco

Re: [alsa-devel] [PATCH v5 7/9] ASoC: bt-sco: extend rate and add a general compatible string

On Fri, Jul 01, 2016 at 10:49:46AM +0800, Garlic Tseng wrote: > On Thu, 2016-06-30 at 20:55 +0800, Garlic Tseng wrote: > > If you worry about some potential risk (I don't see any) maybe we have > > to develop another dummy bt-sco codec driver which support both 8k and > > 16k? > Ah! If someone

Re: [alsa-devel] [PATCH v5 7/9] ASoC: bt-sco: extend rate and add a general compatible string

On Fri, Jul 01, 2016 at 10:49:46AM +0800, Garlic Tseng wrote: > On Thu, 2016-06-30 at 20:55 +0800, Garlic Tseng wrote: > > If you worry about some potential risk (I don't see any) maybe we have > > to develop another dummy bt-sco codec driver which support both 8k and > > 16k? > Ah! If someone

Re: [alsa-devel] [PATCH v5 7/9] ASoC: bt-sco: extend rate and add a general compatible string

On Thu, 2016-06-30 at 20:55 +0800, Garlic Tseng wrote: > On Wed, 2016-06-29 at 20:15 +0100, Mark Brown wrote: > > On Fri, Jun 17, 2016 at 03:43:58PM +0800, Garlic Tseng wrote: > > > Add supports for 16k (wideband BT) and add a general compatible > > > string "linux,bt-sco" > > > > This will claim

Re: [alsa-devel] [PATCH v5 7/9] ASoC: bt-sco: extend rate and add a general compatible string

On Thu, 2016-06-30 at 20:55 +0800, Garlic Tseng wrote: > On Wed, 2016-06-29 at 20:15 +0100, Mark Brown wrote: > > On Fri, Jun 17, 2016 at 03:43:58PM +0800, Garlic Tseng wrote: > > > Add supports for 16k (wideband BT) and add a general compatible > > > string "linux,bt-sco" > > > > This will claim

Re: [alsa-devel] [PATCH v5 7/9] ASoC: bt-sco: extend rate and add a general compatible string

On Wed, 2016-06-29 at 20:15 +0100, Mark Brown wrote: > On Fri, Jun 17, 2016 at 03:43:58PM +0800, Garlic Tseng wrote: > > Add supports for 16k (wideband BT) and add a general compatible > > string "linux,bt-sco" > > This will claim that we support 16k on existing systems which we clearly > don't.

Re: [alsa-devel] [PATCH v5 7/9] ASoC: bt-sco: extend rate and add a general compatible string

On Wed, 2016-06-29 at 20:15 +0100, Mark Brown wrote: > On Fri, Jun 17, 2016 at 03:43:58PM +0800, Garlic Tseng wrote: > > Add supports for 16k (wideband BT) and add a general compatible > > string "linux,bt-sco" > > This will claim that we support 16k on existing systems which we clearly > don't.

Re: [alsa-devel] [PATCH v5 7/9] ASoC: bt-sco: extend rate and add a general compatible string

On Fri, Jun 17, 2016 at 03:43:58PM +0800, Garlic Tseng wrote: > Add supports for 16k (wideband BT) and add a general compatible > string "linux,bt-sco" This will claim that we support 16k on existing systems which we clearly don't. It also seems unwise to advertise multiple rates when we've no

Re: [alsa-devel] [PATCH v5 7/9] ASoC: bt-sco: extend rate and add a general compatible string

On Fri, Jun 17, 2016 at 03:43:58PM +0800, Garlic Tseng wrote: > Add supports for 16k (wideband BT) and add a general compatible > string "linux,bt-sco" This will claim that we support 16k on existing systems which we clearly don't. It also seems unwise to advertise multiple rates when we've no

[alsa-devel] [PATCH v5 7/9] ASoC: bt-sco: extend rate and add a general compatible string

Add supports for 16k (wideband BT) and add a general compatible string "linux,bt-sco" Signed-off-by: Garlic Tseng --- Documentation/devicetree/bindings/sound/bt-sco.txt | 2 +- sound/soc/codecs/bt-sco.c | 5 +++-- 2 files changed, 4

[alsa-devel] [PATCH v5 7/9] ASoC: bt-sco: extend rate and add a general compatible string

Add supports for 16k (wideband BT) and add a general compatible string "linux,bt-sco" Signed-off-by: Garlic Tseng --- Documentation/devicetree/bindings/sound/bt-sco.txt | 2 +- sound/soc/codecs/bt-sco.c | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff