Re: [alsa-devel] [RFC/RFT PATCH] ASoC: topology: Improve backwards compatibility with v4 topology files

2018-05-25 Thread Guenter Roeck
On Fri, May 25, 2018 at 7:09 AM Guenter Roeck wrote: > On Fri, May 25, 2018 at 6:42 AM Shreyas NC wrote: > > > > > +struct skl_dfw_v4_pipe { > > > > > + u8 pipe_id; > > > > > + u8 pipe_priority; > > > > > + u16 conn_type:4; > > > > > + u16 rsvd:4; > > > > > + u16 memory_page

Re: [alsa-devel] [RFC/RFT PATCH] ASoC: topology: Improve backwards compatibility with v4 topology files

2018-05-25 Thread Guenter Roeck
On Fri, May 25, 2018 at 6:42 AM Shreyas NC wrote: > > > > +struct skl_dfw_v4_pipe { > > > > + u8 pipe_id; > > > > + u8 pipe_priority; > > > > + u16 conn_type:4; > > > > + u16 rsvd:4; > > > > + u16 memory_pages:8; > > > > +} __packed; > > > > + > > > > +struct skl_dfw_v4_module

Re: [alsa-devel] [RFC/RFT PATCH] ASoC: topology: Improve backwards compatibility with v4 topology files

2018-05-25 Thread Shreyas NC
> > > +struct skl_dfw_v4_pipe { > > > + u8 pipe_id; > > > + u8 pipe_priority; > > > + u16 conn_type:4; > > > + u16 rsvd:4; > > > + u16 memory_pages:8; > > > +} __packed; > > > + > > > +struct skl_dfw_v4_module { > > > + char uuid[SKL_UUID_STR_SZ]; > > > + Any reason to not

Re: [alsa-devel] [RFC/RFT PATCH] ASoC: topology: Improve backwards compatibility with v4 topology files

2018-05-25 Thread Guenter Roeck
On Fri, May 25, 2018 at 2:04 AM Lin, Mengdong wrote: > > -Original Message- > > From: alsa-devel-boun...@alsa-project.org [mailto: alsa-devel-bounces@alsa- > > project.org] On Behalf Of Mark Brown > > Sent: Thursday, May 24, 2018 11:12 PM > > On Thu, May 24, 2018 at 07:55:06AM -0700, Gue

RE: [alsa-devel] [RFC/RFT PATCH] ASoC: topology: Improve backwards compatibility with v4 topology files

2018-05-25 Thread Lin, Mengdong
> -Original Message- > From: alsa-devel-boun...@alsa-project.org [mailto:alsa-devel-bounces@alsa- > project.org] On Behalf Of Mark Brown > Sent: Thursday, May 24, 2018 11:12 PM > On Thu, May 24, 2018 at 07:55:06AM -0700, Guenter Roeck wrote: > > On Thu, May 24, 2018 at 7:18 AM Mark Brown

Re: [alsa-devel] [RFC/RFT PATCH] ASoC: topology: Improve backwards compatibility with v4 topology files

2018-05-23 Thread Pierre-Louis Bossart
+static int skl_tplg_get_pvt_data_v4(struct snd_soc_tplg_dapm_widget *tplg_w, + struct skl *skl, struct device *dev, + struct skl_module_cfg *mconfig) +{ + struct skl_dfw_v4_module *dfw = + (struct

Re: [alsa-devel] [RFC/RFT PATCH] ASoC: topology: Improve backwards compatibility with v4 topology files

2018-05-23 Thread Guenter Roeck
On Wed, May 23, 2018 at 1:28 PM Pierre-Louis Bossart < pierre-louis.boss...@linux.intel.com> wrote: > On 05/22/2018 11:58 AM, Guenter Roeck wrote: > > From: Guenter Roeck > > > > Commit dc31e741db49 ("ASoC: topology: ABI - Add the types for BE > > DAI") introduced sound topology files version 5.

Re: [alsa-devel] [RFC/RFT PATCH] ASoC: topology: Improve backwards compatibility with v4 topology files

2018-05-23 Thread Pierre-Louis Bossart
On 05/22/2018 11:58 AM, Guenter Roeck wrote: From: Guenter Roeck Commit dc31e741db49 ("ASoC: topology: ABI - Add the types for BE DAI") introduced sound topology files version 5. Initially, this change made the topology code incompatible with v4 topology files. Backwards compatibility with v4

Re: [alsa-devel] [RFC/RFT PATCH] ASoC: topology: Improve backwards compatibility with v4 topology files

2018-05-23 Thread Mark Brown
On Wed, May 23, 2018 at 07:49:35AM -0700, Guenter Roeck wrote: > I want to be able to swap kernel versions without having to update the root > file system. That doesn't work if I have to use v4 configuration files for > v4.4 and older kernels, and v5 configuration files for v4.9 and later > kernel

Re: [alsa-devel] [RFC/RFT PATCH] ASoC: topology: Improve backwards compatibility with v4 topology files

2018-05-23 Thread Takashi Iwai
On Wed, 23 May 2018 16:49:35 +0200, Guenter Roeck wrote: > > On Wed, May 23, 2018 at 6:56 AM Takashi Iwai wrote: > > > > > > > > My point was a bit different: distributions like Gallium start without > > > the relevant topology files and UCM settings, and we should have a > > > reference to quick

Re: [alsa-devel] [RFC/RFT PATCH] ASoC: topology: Improve backwards compatibility with v4 topology files

2018-05-23 Thread Takashi Iwai
On Wed, 23 May 2018 15:42:59 +0200, Pierre-Louis Bossart wrote: > > On 5/23/18 3:24 AM, Mark Brown wrote: > > On Tue, May 22, 2018 at 02:59:35PM -0500, Pierre-Louis Bossart wrote: > > > >> I am also not convinced by the notion that maintaining topology files is > >> only a userspace/distro issue.

Re: [alsa-devel] [RFC/RFT PATCH] ASoC: topology: Improve backwards compatibility with v4 topology files

2018-05-23 Thread Pierre-Louis Bossart
On 5/23/18 3:24 AM, Mark Brown wrote: On Tue, May 22, 2018 at 02:59:35PM -0500, Pierre-Louis Bossart wrote: I am also not convinced by the notion that maintaining topology files is only a userspace/distro issue. This would mean some distros will have access to the required topology files, possi

Re: [alsa-devel] [RFC/RFT PATCH] ASoC: topology: Improve backwards compatibility with v4 topology files

2018-05-23 Thread Mark Brown
On Tue, May 22, 2018 at 02:59:50PM -0700, Guenter Roeck wrote: > Most people are not aware that they have a backwards compatibility problem > with the topology file. They will typically notice and report that it is > impossible to get audio working with an upstream kernel on a recent > Chromebook,

Re: [alsa-devel] [RFC/RFT PATCH] ASoC: topology: Improve backwards compatibility with v4 topology files

2018-05-23 Thread Mark Brown
On Tue, May 22, 2018 at 02:59:35PM -0500, Pierre-Louis Bossart wrote: > I am also not convinced by the notion that maintaining topology files is > only a userspace/distro issue. This would mean some distros will have access > to the required topology files, possibly enabling DSP processing > capab

Re: [alsa-devel] [RFC/RFT PATCH] ASoC: topology: Improve backwards compatibility with v4 topology files

2018-05-22 Thread Pierre-Louis Bossart
On 05/22/2018 11:58 AM, Guenter Roeck wrote: From: Guenter Roeck Commit dc31e741db49 ("ASoC: topology: ABI - Add the types for BE DAI") introduced sound topology files version 5. Initially, this change made the topology code incompatible with v4 topology files. Backwards compatibility with v4