Re: [alsa-devel] [RFC PATCH 01/40] soundwire: add debugfs support

2019-07-26 Thread Pierre-Louis Bossart
Thanks for the feedback Cezary. +static ssize_t sdw_slave_reg_read(struct file *file, char __user *user_buf, +  size_t count, loff_t *ppos) +{ +    struct sdw_slave *slave = file->private_data; +    unsigned int reg; +    char *buf; +    ssize_t ret; +    int i, j; + +    buf =

Re: [alsa-devel] [RFC PATCH 01/40] soundwire: add debugfs support

2019-07-26 Thread Pierre-Louis Bossart
On 7/25/19 5:15 PM, Guennadi Liakhovetski wrote: Hi Pierre, A couple of nitpicks: Thanks for the feedback! create mode 100644 drivers/soundwire/debugfs.c [snip] diff --git a/drivers/soundwire/bus.h b/drivers/soundwire/bus.h index 3048ca153f22..06ac4adb0074 100644 ---

Re: [alsa-devel] [RFC PATCH 01/40] soundwire: add debugfs support

2019-07-26 Thread Guennadi Liakhovetski
Hi Pierre, A couple of nitpicks: On Thu, Jul 25, 2019 at 06:39:53PM -0500, Pierre-Louis Bossart wrote: > Add base debugfs mechanism for SoundWire bus by creating soundwire > root and master-N and slave-x hierarchy. > > Also add SDW Slave SCP, DP0 and DP-N register debug file. > > Registers not