Re: [block:for-3.14/core]: bio_endio: Warn and free bio if bi_end_io is not set.

2014-01-08 Thread Jens Axboe
On 01/07/2014 06:57 PM, Muthu Kumar wrote: > Jens, > In bio_endio if bio doesn't have bi_end_io (should be an error case), > we set bio to NULL and continue silently without freeing the bio. It > would be good to have a WARN and free the bio to avoid memory leak. > > If you agree, here is the patc

[block:for-3.14/core]: bio_endio: Warn and free bio if bi_end_io is not set.

2014-01-07 Thread Muthu Kumar
Jens, In bio_endio if bio doesn't have bi_end_io (should be an error case), we set bio to NULL and continue silently without freeing the bio. It would be good to have a WARN and free the bio to avoid memory leak. If you agree, here is the patch. - bio_endio: Warn and free bio if bi_end_io