Re: [bpf-next 1/2] tcp: replace SOCK_DEBUG() with tcp_stats()

2019-02-12 Thread Yafang Shao
On Wed, Feb 13, 2019 at 10:49 AM Alexei Starovoitov wrote: > > On Tue, Feb 12, 2019 at 6:15 PM Eric Dumazet wrote: > > > > Do not add more debugging stuff unless you can demonstrate > > they actually allowed you to find a real bug and that you sent a > > public fix for it. > > > > Just adding "co

Re: [bpf-next 1/2] tcp: replace SOCK_DEBUG() with tcp_stats()

2019-02-12 Thread Alexei Starovoitov
On Tue, Feb 12, 2019 at 6:15 PM Eric Dumazet wrote: > > Do not add more debugging stuff unless you can demonstrate > they actually allowed you to find a real bug and that you sent a > public fix for it. > > Just adding "cool stuff" in TCP stack does not please me, it is only > more complexity for

Re: [bpf-next 1/2] tcp: replace SOCK_DEBUG() with tcp_stats()

2019-02-12 Thread Yafang Shao
On Wed, Feb 13, 2019 at 10:15 AM Eric Dumazet wrote: > > On Tue, Feb 12, 2019 at 6:07 PM Yafang Shao wrote: > > > > > Let me explain the background for you. > > I want to track some TCP abnormal behavior in TCP/IP stack. But I > > find there's no good way to do it. > > The current MIBs are per n

Re: [bpf-next 1/2] tcp: replace SOCK_DEBUG() with tcp_stats()

2019-02-12 Thread Eric Dumazet
On Tue, Feb 12, 2019 at 6:07 PM Yafang Shao wrote: > > Let me explain the background for you. > I want to track some TCP abnormal behavior in TCP/IP stack. But I > find there's no good way to do it. > The current MIBs are per net, other than per socket, that makes it not > very powerful. > And t

Re: [bpf-next 1/2] tcp: replace SOCK_DEBUG() with tcp_stats()

2019-02-12 Thread Yafang Shao
On Tue, Feb 12, 2019 at 11:07 PM Eric Dumazet wrote: > > > > On 02/12/2019 03:31 AM, Yafang Shao wrote: > > SOCK_DEBUG is a very ancient debugging interface, and it's not very useful > > for debugging. > > So this patch removes the SOCK_DEBUG() and introduce a new function > > tcp_stats() to trace

Re: [bpf-next 1/2] tcp: replace SOCK_DEBUG() with tcp_stats()

2019-02-12 Thread Eric Dumazet
On 02/12/2019 03:31 AM, Yafang Shao wrote: > SOCK_DEBUG is a very ancient debugging interface, and it's not very useful > for debugging. > So this patch removes the SOCK_DEBUG() and introduce a new function > tcp_stats() to trace this kind of events. > Some MIBs are added for these events. > >

[bpf-next 1/2] tcp: replace SOCK_DEBUG() with tcp_stats()

2019-02-12 Thread Yafang Shao
SOCK_DEBUG is a very ancient debugging interface, and it's not very useful for debugging. So this patch removes the SOCK_DEBUG() and introduce a new function tcp_stats() to trace this kind of events. Some MIBs are added for these events. Regarding the SO_DEBUG in sock_{s,g}etsockopt, I think it is