Re: [char-misc-next] Revert "mei: hdcp: Replace one-element array with flexible-array member"

2020-07-28 Thread Gustavo A. R. Silva
On 7/28/20 18:16, Gustavo A. R. Silva wrote: > > > On 7/28/20 18:04, Gustavo A. R. Silva wrote: >> Tomas, >> >> Please, see some comments below... >> >> On 7/28/20 17:29, Winkler, Tomas wrote: >>> >>> Hi Tomas, >>> >>> On 7/28/20 16:41, Tomas Winkler wrote: Greg

Re: [char-misc-next] Revert "mei: hdcp: Replace one-element array with flexible-array member"

2020-07-28 Thread Gustavo A. R. Silva
On 7/28/20 18:04, Gustavo A. R. Silva wrote: > Tomas, > > Please, see some comments below... > > On 7/28/20 17:29, Winkler, Tomas wrote: >> >> Hi Tomas, >> >> On 7/28/20 16:41, Tomas Winkler wrote: >>> Greg please revert, this commit it changes size of struct >>>

RE: [char-misc-next] Revert "mei: hdcp: Replace one-element array with flexible-array member"

2020-07-28 Thread Winkler, Tomas
> On Tue, 2020-07-28 at 22:14 +, Winkler, Tomas wrote: > > > -Original Message- > > > From: Gustavo A. R. Silva > [] > > > I'm using this command: > > > > > > $ scripts/get_maintainer.pl --nokeywords --nogit --nogit-fallback > > > > > > and this is the output for both files: > > > > >

RE: [char-misc-next] Revert "mei: hdcp: Replace one-element array with flexible-array member"

2020-07-28 Thread Winkler, Tomas
> > Tomas, > > Please, see some comments below... > > On 7/28/20 17:29, Winkler, Tomas wrote: > > > > Hi Tomas, > > > > On 7/28/20 16:41, Tomas Winkler wrote: > >> Greg please revert, this commit it changes size of struct > >> wired_cmd_repeater_auth_stream_req_in, this

Re: [char-misc-next] Revert "mei: hdcp: Replace one-element array with flexible-array member"

2020-07-28 Thread Joe Perches
On Tue, 2020-07-28 at 22:14 +, Winkler, Tomas wrote: > > -Original Message- > > From: Gustavo A. R. Silva [] > > I'm using this command: > > > > $ scripts/get_maintainer.pl --nokeywords --nogit --nogit-fallback > > > > and this is the output for both files: > > > > $

Re: [char-misc-next] Revert "mei: hdcp: Replace one-element array with flexible-array member"

2020-07-28 Thread Gustavo A. R. Silva
Tomas, Please, see some comments below... On 7/28/20 17:29, Winkler, Tomas wrote: > > Hi Tomas, > > On 7/28/20 16:41, Tomas Winkler wrote: >> Greg please revert, this commit it changes size of struct >> wired_cmd_repeater_auth_stream_req_in, this is not what firmware

RE: [char-misc-next] Revert "mei: hdcp: Replace one-element array with flexible-array member"

2020-07-28 Thread Winkler, Tomas
> > >> > > >> Hi Tomas, > > >> > > >> On 7/28/20 16:41, Tomas Winkler wrote: > > >>> Greg please revert, this commit it changes size of struct > > >>> wired_cmd_repeater_auth_stream_req_in, this is not what firmware > > >>> is expecting. > > >> > > >> Could you elaborate on what's the firmware

RE: [char-misc-next] Revert "mei: hdcp: Replace one-element array with flexible-array member"

2020-07-28 Thread Winkler, Tomas
;> To: Winkler, Tomas ; Greg Kroah-Hartman > >> > >> Cc: Usyskin, Alexander ; linux- > >> ker...@vger.kernel.org; Gustavo A . R . Silva > >> Subject: Re: [char-misc-next] Revert "mei: hdcp: Replace one-element > >> array with flexible

Re: [char-misc-next] Revert "mei: hdcp: Replace one-element array with flexible-array member"

2020-07-28 Thread Gustavo A. R. Silva
-Hartman >>> >>> Cc: Usyskin, Alexander ; linux- >>> ker...@vger.kernel.org; Gustavo A . R . Silva >>> Subject: Re: [char-misc-next] Revert "mei: hdcp: Replace one-element array >>> with flexible-array member" >>> &g

Re: [char-misc-next] Revert "mei: hdcp: Replace one-element array with flexible-array member"

2020-07-28 Thread Gustavo A. R. Silva
ernel.org; Gustavo A . R . Silva >> Subject: Re: [char-misc-next] Revert "mei: hdcp: Replace one-element array >> with flexible-array member" >> >> Hi Tomas, >> >> On 7/28/20 16:41, Tomas Winkler wrote: >>> Greg please revert, this commit it chang

RE: [char-misc-next] Revert "mei: hdcp: Replace one-element array with flexible-array member"

2020-07-28 Thread Winkler, Tomas
> -Original Message- > From: Gustavo A. R. Silva > Sent: Wednesday, July 29, 2020 00:57 > To: Winkler, Tomas ; Greg Kroah-Hartman > > Cc: Usyskin, Alexander ; linux- > ker...@vger.kernel.org; Gustavo A . R . Silva > Subject: Re: [char-misc-next] Revert "m

Re: [char-misc-next] Revert "mei: hdcp: Replace one-element array with flexible-array member"

2020-07-28 Thread Gustavo A. R. Silva
Hi Tomas, On 7/28/20 16:41, Tomas Winkler wrote: > Greg please revert, this commit it changes size of > struct wired_cmd_repeater_auth_stream_req_in, this is > not what firmware is expecting. Could you elaborate on what's the firmware expecting, exactly? Thanks -- Gustavo > I really do not

[char-misc-next] Revert "mei: hdcp: Replace one-element array with flexible-array member"

2020-07-28 Thread Tomas Winkler
Greg please revert, this commit it changes size of struct wired_cmd_repeater_auth_stream_req_in, this is not what firmware is expecting. I really do not appreciate that the code is bypassing driver maintaner review, I think this is a minimum we can ask for, this is not for a first time. This