RE: [char-misc 3.11 V2] mei: me: fix hardware reset flow

2013-08-04 Thread Winkler, Tomas
> > On Tue, Jul 30, 2013 at 02:28:55PM +, Winkler, Tomas wrote: > > > > > Subject: Re: [char-misc 3.11 V2] mei: me: fix hardware reset flow > > > > > > On Tue, Jul 30, 2013 at 02:11:51PM +0300, Tomas Winkler wrote: > > > > Both H_IS

Re: [char-misc 3.11 V2] mei: me: fix hardware reset flow

2013-08-04 Thread Greg KH
On Tue, Jul 30, 2013 at 02:28:55PM +, Winkler, Tomas wrote: > > > Subject: Re: [char-misc 3.11 V2] mei: me: fix hardware reset flow > > > > On Tue, Jul 30, 2013 at 02:11:51PM +0300, Tomas Winkler wrote: > > > Both H_IS and H_IE needs to be set to receive H_RDY i

RE: [char-misc 3.11 V2] mei: me: fix hardware reset flow

2013-07-31 Thread Winkler, Tomas
> > On 07/30/2013 01:30 PM, Winkler, Tomas wrote: > > > >> > > >>> Both H_IS and H_IE needs to be set to receive H_RDY interrupt > > > > 1. Assert H_IS to clear the interrupts during hw reset and use > > mei_me_reg_write instead of mei_hcsr_set as the later strips down > > the

Re: [char-misc 3.11 V2] mei: me: fix hardware reset flow

2013-07-31 Thread Shuah Khan
On 07/30/2013 01:30 PM, Winkler, Tomas wrote: > >> > >>> Both H_IS and H_IE needs to be set to receive H_RDY interrupt > > 1. Assert H_IS to clear the interrupts during hw reset and use > mei_me_reg_write instead of mei_hcsr_set as the later strips down > the H_IS > > 2. f

RE: [char-misc 3.11 V2] mei: me: fix hardware reset flow

2013-07-30 Thread Winkler, Tomas
> >>> Both H_IS and H_IE needs to be set to receive H_RDY interrupt > >>> > >>> 1. Assert H_IS to clear the interrupts during hw reset and use > >>> mei_me_reg_write instead of mei_hcsr_set as the later strips down > >>> the H_IS > >>> > >>> 2. fix interrupt disablement embarrassing typo > >>>

RE: [char-misc 3.11 V2] mei: me: fix hardware reset flow

2013-07-30 Thread Winkler, Tomas
> Subject: Re: [char-misc 3.11 V2] mei: me: fix hardware reset flow > > On Tue, Jul 30, 2013 at 02:11:51PM +0300, Tomas Winkler wrote: > > Both H_IS and H_IE needs to be set to receive H_RDY interrupt > > > > 1. Assert H_IS to clear the interrupts during hw reset a

Re: [char-misc 3.11 V2] mei: me: fix hardware reset flow

2013-07-30 Thread Shuah Khan
On 07/30/2013 08:21 AM, Greg KH wrote: > On Tue, Jul 30, 2013 at 02:11:51PM +0300, Tomas Winkler wrote: >> Both H_IS and H_IE needs to be set to receive H_RDY >> interrupt >> >> 1. Assert H_IS to clear the interrupts during hw reset >> and use mei_me_reg_write instead of mei_hcsr_set as the later >

Re: [char-misc 3.11 V2] mei: me: fix hardware reset flow

2013-07-30 Thread Greg KH
On Tue, Jul 30, 2013 at 02:11:51PM +0300, Tomas Winkler wrote: > Both H_IS and H_IE needs to be set to receive H_RDY > interrupt > > 1. Assert H_IS to clear the interrupts during hw reset > and use mei_me_reg_write instead of mei_hcsr_set as the later > strips down the H_IS > > 2. fix interrupt

[char-misc 3.11 V2] mei: me: fix hardware reset flow

2013-07-30 Thread Tomas Winkler
Both H_IS and H_IE needs to be set to receive H_RDY interrupt 1. Assert H_IS to clear the interrupts during hw reset and use mei_me_reg_write instead of mei_hcsr_set as the later strips down the H_IS 2. fix interrupt disablement embarrassing typo hcsr |= ~H_IE -> hcsr &= ~H_IE; this will remov